From: Panu Matilainen <pmatilai@redhat.com>
To: Bruce Richardson <bruce.richardson@intel.com>,
Beilei Xing <beilei.xing@intel.com>
Cc: jingjing.wu@intel.com, dev@dpdk.org, thomas.monjalon@6wind.com,
nhorman@tuxdriver.com
Subject: Re: [dpdk-dev] [PATCH v2] i40e: modify the meaning of single VLAN type
Date: Tue, 21 Jun 2016 14:06:38 +0300 [thread overview]
Message-ID: <e00695b0-291c-5a53-e778-42f087d98817@redhat.com> (raw)
In-Reply-To: <20160621102930.GA21016@bricha3-MOBL3>
On 06/21/2016 01:29 PM, Bruce Richardson wrote:
> On Mon, Jun 13, 2016 at 04:03:32PM +0800, Beilei Xing wrote:
>> In current i40e codebase, if single VLAN header is added in a packet,
>> it's treated as inner VLAN. Generally, a single VLAN header is
>> treated as the outer VLAN header. So change corresponding register
>> for single VLAN.
>> At the meanwhile, change the meanings of inner VLAN and outer VLAN.
>>
>> Signed-off-by: Beilei Xing <beilei.xing@intel.com>
>
> This patch changes the ABI, since an app written to the original API as specified
> e.g. to set a single vlan header, would no longer work with this change.
> Therefore, even though the original behaviour was inconsistent with other drivers
> it may still need to be preserved.
>
> I'm thinking that we may need to provide appropriately versioned copies of the
> vlan_offload_set and vlan_tpid_set functions for backward compatibility with
> the old ABI.
>
> Any other comments or thoughts on this?
> Neil, Thomas, Panu - is this fix something that we need to provide backward
> version-compatibility for, or given that the functions are being called through
> a generic ethdev API mean that this can just go in as a straight bug-fix?
Since it's currently inconsistent with everything else, I'd just call it
a bug-fix and leave it at that.
Besides, I dont think you could version it via the ordinary means even
if you wanted to, due to the way its called through eth_dev_ops etc.
- Panu -
next prev parent reply other threads:[~2016-06-21 11:06 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-05-26 7:28 [dpdk-dev] [PATCH] ethdev: change comments of " Beilei Xing
2016-06-03 2:52 ` Lu, Wenzhuo
2016-06-03 3:13 ` Xing, Beilei
2016-06-13 8:03 ` [dpdk-dev] [PATCH v2] i40e: modify the meaning of single " Beilei Xing
2016-06-14 3:33 ` Wu, Jingjing
2016-06-21 10:29 ` Bruce Richardson
2016-06-21 11:06 ` Panu Matilainen [this message]
2016-06-21 11:28 ` Bruce Richardson
2016-06-21 11:30 ` Bruce Richardson
2016-06-22 2:53 ` [dpdk-dev] [PATCH v3] i40e: fix the type issue of a " Beilei Xing
2016-06-24 12:09 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e00695b0-291c-5a53-e778-42f087d98817@redhat.com \
--to=pmatilai@redhat.com \
--cc=beilei.xing@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=nhorman@tuxdriver.com \
--cc=thomas.monjalon@6wind.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).