From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id E7DB6B3D1 for ; Tue, 21 Jun 2016 13:06:41 +0200 (CEST) Received: from int-mx09.intmail.prod.int.phx2.redhat.com (int-mx09.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id EBCE6D2EC9; Tue, 21 Jun 2016 11:06:40 +0000 (UTC) Received: from sopuli.koti.laiskiainen.org (vpn1-6-229.ams2.redhat.com [10.36.6.229]) by int-mx09.intmail.prod.int.phx2.redhat.com (8.14.4/8.14.4) with ESMTP id u5LB6cR3012437; Tue, 21 Jun 2016 07:06:39 -0400 To: Bruce Richardson , Beilei Xing References: <1464247695-4694-1-git-send-email-beilei.xing@intel.com> <1465805012-2907-1-git-send-email-beilei.xing@intel.com> <20160621102930.GA21016@bricha3-MOBL3> Cc: jingjing.wu@intel.com, dev@dpdk.org, thomas.monjalon@6wind.com, nhorman@tuxdriver.com From: Panu Matilainen Message-ID: Date: Tue, 21 Jun 2016 14:06:38 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.1.1 MIME-Version: 1.0 In-Reply-To: <20160621102930.GA21016@bricha3-MOBL3> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.68 on 10.5.11.22 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.38]); Tue, 21 Jun 2016 11:06:41 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v2] i40e: modify the meaning of single VLAN type X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Jun 2016 11:06:42 -0000 On 06/21/2016 01:29 PM, Bruce Richardson wrote: > On Mon, Jun 13, 2016 at 04:03:32PM +0800, Beilei Xing wrote: >> In current i40e codebase, if single VLAN header is added in a packet, >> it's treated as inner VLAN. Generally, a single VLAN header is >> treated as the outer VLAN header. So change corresponding register >> for single VLAN. >> At the meanwhile, change the meanings of inner VLAN and outer VLAN. >> >> Signed-off-by: Beilei Xing > > This patch changes the ABI, since an app written to the original API as specified > e.g. to set a single vlan header, would no longer work with this change. > Therefore, even though the original behaviour was inconsistent with other drivers > it may still need to be preserved. > > I'm thinking that we may need to provide appropriately versioned copies of the > vlan_offload_set and vlan_tpid_set functions for backward compatibility with > the old ABI. > > Any other comments or thoughts on this? > Neil, Thomas, Panu - is this fix something that we need to provide backward > version-compatibility for, or given that the functions are being called through > a generic ethdev API mean that this can just go in as a straight bug-fix? Since it's currently inconsistent with everything else, I'd just call it a bug-fix and leave it at that. Besides, I dont think you could version it via the ordinary means even if you wanted to, due to the way its called through eth_dev_ops etc. - Panu -