DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Jiawen Wu <jiawenwu@trustnetic.com>, dev@dpdk.org
Cc: jianwang@trustnetic.com, yuhongzhang@trustnetic.com
Subject: Re: [dpdk-dev] [PATCH] net: add a new network PMD named txgbe
Date: Thu, 20 Aug 2020 12:48:38 +0100	[thread overview]
Message-ID: <e01af7ef-e8e1-8e69-a4f1-0de66b9c1b02@intel.com> (raw)
In-Reply-To: <20200820030231.1382984-1-jiawenwu@trustnetic.com>

On 8/20/2020 4:02 AM, Jiawen Wu wrote:
> This is a new network PMD named txgbe provides poll mode driver support for Wangxun 10Gb Ethernet NICs.
> 
> Beijing WangXun Technology Co., Ltd. is a high-tech company specializing in the design of high-end integrated circuit chips and providing independent innovation solutions for enterprise network and storage products. Founded in May 2014, the company is headquartered in Beijing YuQuanHuiGu Science and Technology Park, with branches in Hangzhou City. Welcome to reach us on website https://www.net-swift.com.
> 
> This patch is created base on the main branch in main repository. Our goal is to validate and commit txgbe driver into the 20.11 official release, and then continue the development and maintenance in community.
> 
> Waiting for your reviews sincerely.
> 
> Signed-off-by: Jiawen Wu <jiawenwu@trustnetic.com>

Hi Jiawen,

Thanks for the patch.

Without looking into any detail, a very high level comment is, it is very hard
to review a new PMD (40K+ loc) as a single patch.

Can you please split the patch into multiple patches, which gradually build the
PMD by adding a feature with each patch, starting from an empty skeleton.

Last as few upstreamed PMDs as example:
ionic:
https://patches.dpdk.org/project/dpdk/list/?series=8206&state=%2A&archive=both

pfe:
https://patches.dpdk.org/project/dpdk/list/?series=6777&state=%2A&archive=both

octeontx2 (one of the good samples I suggest checking):
https://patches.dpdk.org/project/dpdk/list/?series=5302&state=%2A&archive=both


Also you can skip all Makefile build system related changes, since it will be
removed in this release, no need to spend time for it.

Thanks,
ferruh

  reply	other threads:[~2020-08-20 11:48 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-08-20  3:02 Jiawen Wu
2020-08-20 11:48 ` Ferruh Yigit [this message]
2020-08-21  2:21   ` jiawenwu
2020-09-01 11:52   ` jiawenwu
2020-09-09 17:45     ` Ferruh Yigit
2020-09-10  7:16       ` jiawenwu
2020-09-10 11:22         ` Ferruh Yigit
2020-09-11  6:46           ` jiawenwu
2020-09-11 11:15             ` Ferruh Yigit
2020-09-09 17:58 ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e01af7ef-e8e1-8e69-a4f1-0de66b9c1b02@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=dev@dpdk.org \
    --cc=jianwang@trustnetic.com \
    --cc=jiawenwu@trustnetic.com \
    --cc=yuhongzhang@trustnetic.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).