From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
 by dpdk.org (Postfix) with ESMTP id EC6DD1023
 for <dev@dpdk.org>; Tue, 24 Jan 2017 12:58:45 +0100 (CET)
Received: from orsmga003.jf.intel.com ([10.7.209.27])
 by orsmga102.jf.intel.com with ESMTP; 24 Jan 2017 03:58:44 -0800
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.33,278,1477983600"; d="scan'208";a="926029651"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.38])
 ([10.237.220.38])
 by orsmga003.jf.intel.com with ESMTP; 24 Jan 2017 03:58:43 -0800
To: Matej Vido <vido@cesnet.cz>, dev@dpdk.org
References: <1485254992-12545-1-git-send-email-vido@cesnet.cz>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <e01e4fda-eadd-49cc-4a31-7147817ce822@intel.com>
Date: Tue, 24 Jan 2017 11:58:43 +0000
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101
 Thunderbird/45.6.0
MIME-Version: 1.0
In-Reply-To: <1485254992-12545-1-git-send-email-vido@cesnet.cz>
Content-Type: text/plain; charset=windows-1252
Content-Transfer-Encoding: 8bit
Subject: Re: [dpdk-dev] [PATCH] net/szedata2: fix incorrect device memory
 access
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Tue, 24 Jan 2017 11:58:46 -0000

On 1/24/2017 10:49 AM, Matej Vido wrote:
> Fixes: 8acba705b119 ("net/szedata2: localize handling of PCI resources")
> 
> Signed-off-by: Matej Vido <vido@cesnet.cz>

Unrelated from this patch, in maintainers file, you have your other mail
address: "Matej Vido <matejvido@gmail.com>", do you want to update it?

> ---
>  drivers/net/szedata2/rte_eth_szedata2.h | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/szedata2/rte_eth_szedata2.h b/drivers/net/szedata2/rte_eth_szedata2.h
> index b58adb6..afe8a38 100644
> --- a/drivers/net/szedata2/rte_eth_szedata2.h
> +++ b/drivers/net/szedata2/rte_eth_szedata2.h
> @@ -192,7 +192,7 @@ struct szedata {
>  }
>  
>  #define SZEDATA2_PCI_RESOURCE_PTR(rsc, offset, type) \
> -	((type)((uint8_t *)(rsc)->addr) + (offset))
> +	((type)(((uint8_t *)(rsc)->addr) + (offset)))

Although output will be same, (in all uses, type is a pointer), this
seems the intention, so:

Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>

btw, following will do same, right, not sure if it is better:
((type)(rsc)->addr + (offset))

>  
>  enum szedata2_link_speed {
>  	SZEDATA2_LINK_SPEED_DEFAULT = 0,
>