From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 24EC2A034F; Mon, 11 Oct 2021 19:04:19 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 0A022410F6; Mon, 11 Oct 2021 19:04:19 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id 6B6D6410EF for ; Mon, 11 Oct 2021 19:04:17 +0200 (CEST) Received: from [192.168.1.192] (unknown [188.242.181.57]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits)) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 8C4247F50A; Mon, 11 Oct 2021 20:04:16 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 8C4247F50A DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1633971857; bh=yGn83rQri+e5OwyhhDWxbzVIc1vyp1+kmLFpRO6CZ6Q=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=oFMFoEeZxhOFF5Rrx+T+K80Lf3gWx0GFf4OrzlBcVxN+GyypuJDkl/hdjAKF4GbV1 E+D04twpIPioA7UMVt2EL8qSoqJE6SCRJGNUfM2qByPHjDVgFqsI+MRiZmqC28HRXW e5WiGQLWBERKKbVWtN5jjiD7S5j3xEw8o4FFG3zA= To: "Ananyev, Konstantin" , "dev@dpdk.org" Cc: "Li, Xiaoyun" , "anoobj@marvell.com" , "jerinj@marvell.com" , "ndabilpuram@marvell.com" , "adwivedi@marvell.com" , "shepard.siegel@atomicrules.com" , "ed.czeck@atomicrules.com" , "john.miller@atomicrules.com" , "irusskikh@marvell.com" , "ajit.khaparde@broadcom.com" , "somnath.kotur@broadcom.com" , "rahul.lakkireddy@chelsio.com" , "hemant.agrawal@nxp.com" , "sachin.saxena@oss.nxp.com" , "Wang, Haiyue" , "Daley, John" , "hyonkim@cisco.com" , "Zhang, Qi Z" , "Wang, Xiao W" , "humin29@huawei.com" , "yisen.zhuang@huawei.com" , "oulijun@huawei.com" , "Xing, Beilei" , "Wu, Jingjing" , "Yang, Qiming" , "matan@nvidia.com" , "viacheslavo@nvidia.com" , "sthemmin@microsoft.com" , "longli@microsoft.com" , "heinrich.kuhn@corigine.com" , "kirankumark@marvell.com" , "mczekaj@marvell.com" , "jiawenwu@trustnetic.com" , "jianwang@trustnetic.com" , "maxime.coquelin@redhat.com" , "Xia, Chenbo" , "thomas@monjalon.net" , "Yigit, Ferruh" , "mdr@ashroe.eu" , "Jayatheerthan, Jay" References: <20211004135603.20593-1-konstantin.ananyev@intel.com> <20211007112750.25526-1-konstantin.ananyev@intel.com> <20211007112750.25526-8-konstantin.ananyev@intel.com> <9b125d31-8245-6b7b-d9ab-403c44021c8f@oktetlabs.ru> From: Andrew Rybchenko Message-ID: Date: Mon, 11 Oct 2021 20:04:16 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH v5 7/7] ethdev: hide eth dev related structures X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/11/21 6:54 PM, Ananyev, Konstantin wrote: > > >> >> On 10/7/21 2:27 PM, Konstantin Ananyev wrote: >>> Move rte_eth_dev, rte_eth_dev_data, rte_eth_rxtx_callback and related >>> data into private header (ethdev_driver.h). >>> Few minor changes to keep DPDK building after that. >>> >>> Signed-off-by: Konstantin Ananyev >> >> [snip] >> >> I realize that many notes below correspond to just >> moved code, but I still think that ti would be nice >> to fix anyway. > > Yes, that’s just cut and paste from rte_ethdev_core.h and ethdev_driver.h > It is probably a good idea to clean-up and might be re-layout rte_eth_dev and friends, > but I don't think it has to be part of this patch-set. > After all, if it will become internal structure, that work could be done for any DPDK release. > OK, I can do cleanup as a follow up patch.