From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qt0-f178.google.com (mail-qt0-f178.google.com [209.85.216.178]) by dpdk.org (Postfix) with ESMTP id AFA0D1AFFC for ; Mon, 2 Apr 2018 20:57:39 +0200 (CEST) Received: by mail-qt0-f178.google.com with SMTP id s2so16596341qti.2 for ; Mon, 02 Apr 2018 11:57:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=subject:to:references:from:message-id:date:user-agent:mime-version :in-reply-to:content-transfer-encoding:content-language; bh=6Kfznc7wDwCBAzoylMt2DN8pJf8uU0KdRZsYLn3DVOc=; b=F99x6JbvNR23L8F13/8V+QPRm2olDDeR6W3hY04hhEvG+0LZG3h/v87vTWdlzP2yKz DjXCfkkthAj7f/04Aes7kBzaLVDFJNyRmJCJOstCyMMbBPBH1kYWUo8jpSkfptT/OzZ5 iS7+hcmBJby55awVVeNWIApwodwzFJ/3Ws4ng= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-transfer-encoding :content-language; bh=6Kfznc7wDwCBAzoylMt2DN8pJf8uU0KdRZsYLn3DVOc=; b=cMBUaDb72tpRkY7G2eCDUHej4UpVqXQDNdNIXcAjmuYJ/Scx44qhVWIE9635Cw+89K 4i3oknS4yNaQYpQIoEKZLOasShgLXgclKJ7RPZ9QgZJ7wkFIZDrFWN5nGCZ8SDBFN82k gfmK72nPo1qP3yOdtwGOOSmXyDE69NmPZSLD9BZ+NeddMHwKoXUw8vkSQX14r5SBVnq1 KaNUywymSNhnqkbWDKhOxXBSQLERVPuxB0Fj40klJCbt8n7kbtYixy/KXIoibfC2iM6N 5jzRNlYya+yGVZ+C6+f8HWGARvq4UnAxc94ZY/v1Ek3RjSoXtdxm5lK/UMyyQELnF2An BgCQ== X-Gm-Message-State: ALQs6tCaLwdtafXenPpy6YxXXSK7KxiEjqUx9tXd54bnUPPaUObEy2HE bDoHeHF0P85ZKK1WHoEasCsgFkkR X-Google-Smtp-Source: AIpwx48drBmj1CxHTioyw1l66I/Y7ug+so2ZxahFz/Fl2E+mUVldM4bfF2GkH8rwjHvLvCmoP9sBpw== X-Received: by 10.237.59.253 with SMTP id s58mr15612616qte.83.1522695458745; Mon, 02 Apr 2018 11:57:38 -0700 (PDT) Received: from [10.136.13.65] ([192.19.224.250]) by smtp.gmail.com with ESMTPSA id f30sm767734qtg.63.2018.04.02.11.57.36 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 02 Apr 2018 11:57:37 -0700 (PDT) To: Ferruh Yigit , Ajit Khaparde , dev@dpdk.org, Hemant Agrawal , Olivier MATZ References: <20180329164021.51728-1-ajit.khaparde@broadcom.com> <7c992ec1-3cef-7a08-2a45-1142798b6af4@intel.com> <22338bee-e88c-13d0-9cd4-333f8e1c59f3@intel.com> From: Scott Branden Message-ID: Date: Mon, 2 Apr 2018 11:57:31 -0700 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <22338bee-e88c-13d0-9cd4-333f8e1c59f3@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-US Subject: Re: [dpdk-dev] [PATCH v2] net/bnxt: convert to SPDX license tag X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 02 Apr 2018 18:57:39 -0000 On 18-03-31 02:08 PM, Ferruh Yigit wrote: > On 3/30/2018 7:10 PM, Scott Branden wrote: >> Hi Ferruh, >> >> >> On 18-03-30 03:35 AM, Ferruh Yigit wrote: >>> On 3/29/2018 5:40 PM, Ajit Khaparde wrote: >>>> From: Scott Branden >>>> >>>> Update the license header on bnxt files to be the standard >>>> BSD-3-Clause license used for the rest of DPDK, >>>> bring the files in compliance with the DPDK licensing policy. >>>> >>>> Signed-off-by: Scott Branden >>>> Signed-off-by: Ajit Khaparde >>>> Cc:hemant.agrawal@nxp.com >>>> ---- >>>> v1->v2: modify first line of SPDX identifer as per review comment. >>>> --- >>>> doc/guides/nics/bnxt.rst | 30 ++---------------------------- >>>> drivers/net/bnxt/bnxt.h | 32 ++------------------------------ >>>> drivers/net/bnxt/bnxt_cpr.c | 32 ++------------------------------ >>>> drivers/net/bnxt/bnxt_cpr.h | 32 ++------------------------------ >>>> drivers/net/bnxt/bnxt_ethdev.c | 32 ++------------------------------ >>>> drivers/net/bnxt/bnxt_filter.c | 32 ++------------------------------ >>>> drivers/net/bnxt/bnxt_filter.h | 32 ++------------------------------ >>>> drivers/net/bnxt/bnxt_hwrm.c | 32 ++------------------------------ >>>> drivers/net/bnxt/bnxt_hwrm.h | 32 ++------------------------------ >>>> drivers/net/bnxt/bnxt_irq.c | 32 ++------------------------------ >>>> drivers/net/bnxt/bnxt_irq.h | 32 ++------------------------------ >>>> drivers/net/bnxt/bnxt_nvm_defs.h | 11 +++-------- >>>> drivers/net/bnxt/bnxt_ring.c | 32 ++------------------------------ >>>> drivers/net/bnxt/bnxt_ring.h | 32 ++------------------------------ >>>> drivers/net/bnxt/bnxt_rxq.c | 32 ++------------------------------ >>>> drivers/net/bnxt/bnxt_rxq.h | 32 ++------------------------------ >>>> drivers/net/bnxt/bnxt_rxr.c | 32 ++------------------------------ >>>> drivers/net/bnxt/bnxt_rxr.h | 32 ++------------------------------ >>>> drivers/net/bnxt/bnxt_stats.c | 32 ++------------------------------ >>>> drivers/net/bnxt/bnxt_stats.h | 32 ++------------------------------ >>>> drivers/net/bnxt/bnxt_txq.c | 32 ++------------------------------ >>>> drivers/net/bnxt/bnxt_txq.h | 32 ++------------------------------ >>>> drivers/net/bnxt/bnxt_txr.c | 32 ++------------------------------ >>>> drivers/net/bnxt/bnxt_txr.h | 32 ++------------------------------ >>>> drivers/net/bnxt/bnxt_vnic.c | 32 ++------------------------------ >>>> drivers/net/bnxt/bnxt_vnic.h | 32 ++------------------------------ >>>> drivers/net/bnxt/hsi_struct_def_dpdk.h | 32 ++------------------------------ >>>> drivers/net/bnxt/rte_pmd_bnxt.c | 32 ++------------------------------ >>>> drivers/net/bnxt/rte_pmd_bnxt.h | 32 ++------------------------------ >>>> 29 files changed, 59 insertions(+), 846 deletions(-) >>> Can you please update Makefile too, but I can see it has multiple coypright, it >>> can be better to send it as a separate patch to not block this one. >> Yes, Makefile change should be in another patch. >> I don't know how to change the header on that one though. >> Intel and 6WIND shouldn't really have any copyright on the Makefile, though? >> It looks like somebody just cut and paste the license header from >> another Makefile. >> Please suggest what should be done with this file. > Most probably it is because of copy-paste as you stated, and I don't know what > does it mean to hold the copyright in the makefile indeed J. cc'ed Hemant and > Olivier. > > But removing an existing copyright may mean involving legal and may take time, > unfortunately. > > It may be easier to just do the SPDX updates with existing coypright, but if you > have motivation I suggest try to fix this. If the other companies remove their copyrights from the file then I would clean it up as the incorrect copyrights have been removed. Otherwise, I'm just leaving the Makefile alone for now. > >>> <...> >>> >>>> @@ -1,34 +1,6 @@ >>>> -/*- >>>> - * BSD LICENSE >>>> - * >>>> - * Copyright(c) Broadcom Limited. >>>> +/* SPDX-License-Identifier: BSD-3-Clause >>>> + * Copyright(c) 2014-2018 Broadcom >>>> * All rights reserved. >>> It might be nit-picking but we don't have leading spaces [1] in format, are they >>> intentional? >>> If not it is easy to fix when introduced otherwise will stay as it is forever J >> Yes, it was intentional. > Why? What is the practical reason of intentionally diverging from defined syntax? The practical reason was to minimize the number of changes to the comments.  Simply stripping the BSD license info and leaving the rest of the comment lines in place.  I'll reformat the rest of the comment to remove this concern. > >>> [1] >>> /* SPDX-License-Identifier: BSD-3-Clause >>> * Copyright(c) 2014-2018 Broadcom >>> * All rights reserved. >>> */ >>> >>> <...> >> Thanks, >>  Scott >>