From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1BFE6A0582; Wed, 19 Oct 2022 12:26:46 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B153E40E03; Wed, 19 Oct 2022 12:26:45 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id C225C40A8B for ; Wed, 19 Oct 2022 12:26:44 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (4096 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id E58E962; Wed, 19 Oct 2022 13:26:43 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru E58E962 DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1666175203; bh=MztmZqNcDXVTvsXTtP0YmooBfKiTDdn4mvg2eKVf8+w=; h=Date:Subject:To:Cc:References:From:In-Reply-To:From; b=uqaAC3JZhLBYYbU0JeuaHjYk9YZHAAvvBUKG9dH41zLRuXaz6V3XjlomekHJUpBum +mJq9RXa7SrgxD1c1w0Nu/GFxNMUDuPlYT2bH+StN0ly0lPnZ9mJUdGhryCpzGlZgA xvTjijkjeVb8koHQAu3ACci2pLNQhaNKjD3Admrg= Message-ID: Date: Wed, 19 Oct 2022 13:26:43 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.3.0 Subject: Re: [PATCH v2] net/bonding: make bonded device configure method re-entrant Content-Language: en-US To: Ivan Malov , dev@dpdk.org Cc: Chas Williams <3chas3@gmail.com>, "Min Hu (Connor)" , Chas Williams , Anatoly Burakov References: <20220911122405.3995083-1-ivan.malov@oktetlabs.ru> <20221018194549.635113-1-ivan.malov@oktetlabs.ru> From: Andrew Rybchenko Organization: OKTET Labs In-Reply-To: <20221018194549.635113-1-ivan.malov@oktetlabs.ru> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/18/22 22:45, Ivan Malov wrote: > According to the documentation, rte_eth_dev_configure() > can be invoked repeatedly while in stopped state. > The current implementation in the bonding driver > allows for that (technically), but the user sees > warnings which say that back-end devices have > already been harnessed. Re-factor the code > to have cleanup before each (re-)configure. > > Signed-off-by: Ivan Malov > Reviewed-by: Andrew Rybchenko > Acked-by: Chas Williams <3chas3@gmail.com> Applied to dpdk-next-net/main, thanks.