From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk0-f195.google.com (mail-qk0-f195.google.com [209.85.220.195]) by dpdk.org (Postfix) with ESMTP id BCFB6324A for ; Fri, 1 Dec 2017 23:30:34 +0100 (CET) Received: by mail-qk0-f195.google.com with SMTP id b184so15066416qkc.13 for ; Fri, 01 Dec 2017 14:30:34 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=scylladb-com.20150623.gappssmtp.com; s=20150623; h=subject:from:to:cc:references:message-id:date:user-agent :mime-version:in-reply-to:content-language; bh=v7d75nrI9zTrZaSOy11rE6ywMivVKjQKdk4cUN4ROlU=; b=lAgOz4cIsX3MGpm4zzTFjb4B5PgolFov4+o0GQ8PTYqvfzt4Qatxmy3vE/PuMWEQHu 4sizSk5V16WRY/oajSIoEdGOpJe0OQULczqqP6Nlu6bVJQH1K5FD+2JsFzwDTtEBgAZh RYe1IWa98Fz1ngNn56ycDE8SriumDYG5c6boQChTj3KgN+lj8PshNdMAgdJ3AwsStSzq TA3J8j5BQDII8oLCnRuYaE6kdorUck/eM2mUoQXV65h03suMgVzQoAeZKicbSVmbOiIE QA5VtoBgv4jo3eBpWC54/pDmti7U9CCByid5/tvWjkUPuRWp582C6ixJiWOI+R8r/jAa q+oQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:from:to:cc:references:message-id:date :user-agent:mime-version:in-reply-to:content-language; bh=v7d75nrI9zTrZaSOy11rE6ywMivVKjQKdk4cUN4ROlU=; b=nmExkCbQZfoVwDkbwqrWdgEQz5ysRHE479KGReDG068xyYAoYtLnJ02zDH+bx1cSlt 7o3WNNNIVjMSfZS7QaaAPF5Do3/nUFodcvqWdab7rVGVE1EPs6iHUYryixLn0nEplPBQ Mbu370aXrmOQ/eaRrINLjjks1vF1E869stXsaqf1RU2v2Zp8tzPc07f3Sln0Qd8pCBY8 4fvAdL7OEeCz0Y/EiNeHxjqpHvYGY2dkq+/cL5tz3hqMVc4weHYidiCm9ucK0D1d9wz7 IqRADR7H9R/2WFlMlrGMFH48tlAUraka4cy2hfzciTYf/gag6BvuX9MwbAVHzOaklvKQ Zx2Q== X-Gm-Message-State: AKGB3mJORs/5GmaORMW7ZtvKqu1QSsQpalGLil3yG2iNy7cGhShxIf2M uQjhRHRxw0+AnBbnrQrp5mGmrw== X-Google-Smtp-Source: AGs4zMYmC+jUNEmaH8GCXAgIvSZrrETZ8WpcxCj1cqAo1zR/WFH95p540cwhde9g/ZF0mvw8slc4Rg== X-Received: by 10.55.22.7 with SMTP id g7mr10231148qkh.82.1512167433895; Fri, 01 Dec 2017 14:30:33 -0800 (PST) Received: from [192.168.1.138] (ool-68f614aa.dyn.optonline.net. [104.246.20.170]) by smtp.googlemail.com with ESMTPSA id c50sm5415228qte.38.2017.12.01.14.30.32 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Fri, 01 Dec 2017 14:30:32 -0800 (PST) From: Vlad Zolotarov To: Ferruh Yigit , Thomas Monjalon Cc: dev@dpdk.org, vladz@cloudius-systems.com References: <20171201022957.64329-1-ferruh.yigit@intel.com> <49eb13f1-e12f-071a-b58b-1cd4852b7c8b@scylladb.com> Message-ID: Date: Fri, 1 Dec 2017 17:30:31 -0500 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <49eb13f1-e12f-071a-b58b-1cd4852b7c8b@scylladb.com> Content-Language: en-US Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH 1/7] ethdev: remove unused flag from header X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 01 Dec 2017 22:30:35 -0000 resending after registering with the new email domain ;) Please, see my comments below. On 12/01/2017 05:17 PM, Vlad Zolotarov wrote: > > > On 11/30/2017 09:29 PM, Ferruh Yigit wrote: >> remove RTE_ETHDEV_HAS_LRO_SUPPORT flag from header. >> >> Flag seems added with the patch that adds LRO support, and intention >> looks like giving a pointer to application that library supports LRO. > > Exactly. Removing this flag may make the existing application "think" > that LRO is not supported. > Why do you want to remove it to begin with? > >> Fixes: 8eecb3295aed ("ixgbe: add LRO support") >> Cc:vladz@cloudius-systems.com >> >> Signed-off-by: Ferruh Yigit >> --- >> lib/librte_ether/rte_ethdev.h | 3 --- >> 1 file changed, 3 deletions(-) >> >> diff --git a/lib/librte_ether/rte_ethdev.h b/lib/librte_ether/rte_ethdev.h >> index 341c2d624..e620c3706 100644 >> --- a/lib/librte_ether/rte_ethdev.h >> +++ b/lib/librte_ether/rte_ethdev.h >> @@ -172,9 +172,6 @@ extern "C" { >> >> #include >> >> -/* Use this macro to check if LRO API is supported */ >> -#define RTE_ETHDEV_HAS_LRO_SUPPORT >> - >> #include >> #include >> #include >