From: "Guo, Jia" <jia.guo@intel.com>
To: "Yang, MurphyX" <murphyx.yang@intel.com>, "dev@dpdk.org" <dev@dpdk.org>
Cc: "Yang, Qiming" <qiming.yang@intel.com>,
"Yang, SteveX" <stevex.yang@intel.com>,
"Wu, Jingjing" <jingjing.wu@intel.com>,
"Xing, Beilei" <beilei.xing@intel.com>,
"Yang, MurphyX" <murphyx.yang@intel.com>
Subject: Re: [dpdk-dev] [PATCH v2] net/iavf: fix negative GTP-U flow rules create successfully
Date: Wed, 23 Dec 2020 02:32:49 +0000 [thread overview]
Message-ID: <e0521afdc0554421ae64654e4e441273@intel.com> (raw)
In-Reply-To: <20201218061843.72422-1-murphyx.yang@intel.com>
Hi, murphy
> -----Original Message-----
> From: Murphy Yang <murphyx.yang@intel.com>
> Sent: Friday, December 18, 2020 2:19 PM
> To: dev@dpdk.org
> Cc: Yang, Qiming <qiming.yang@intel.com>; Yang, SteveX
> <stevex.yang@intel.com>; Guo, Jia <jia.guo@intel.com>; Wu, Jingjing
> <jingjing.wu@intel.com>; Xing, Beilei <beilei.xing@intel.com>; Yang,
> MurphyX <murphyx.yang@intel.com>
> Subject: [PATCH v2] net/iavf: fix negative GTP-U flow rules create
> successfully
>
> Currently, when use 'flow' command to create a negative GTP-U rule, it will
> be created successfully.
>
> The list shows the impacted outer and inner 'ipv4' GTP-U patterns with 'ipv4'
> or 'gtpu' type:
> - iavf_pattern_eth_ipv4_gtpu_ipv4_udp
> - iavf_pattern_eth_ipv4_gtpu_eh_ipv4_udp
> - iavf_pattern_eth_ipv4_gtpu_ipv4_tcp
> - iavf_pattern_eth_ipv4_gtpu_eh_ipv4_tcp
> - more impacted patterns with 'gtpu' type:
> > iavf_pattern_eth_ipv4_gtpu_ipv4
> > iavf_pattern_eth_ipv4_gtpu_eh_ipv4
>
> Same as the outer and inner 'ipv6' GTP-U patterns.
>
> So, this commit adds the invalid RSS combinations in 'invalid_rss_comb'
> array to make result correct.
>
> The list of added invalid RSS combinations:
> - ETH_RSS_IPV4 | ETH_RSS_NONFRAG_IPV4_TCP
> - ETH_RSS_IPV6 | ETH_RSS_NONFRAG_IPV6_TCP
> - ETH_RSS_GTPU | IAVF_RSS_TYPE_INNER_IPV4
> - ETH_RSS_GTPU | IAVF_RSS_TYPE_INNER_IPV4_UDP
> - ETH_RSS_GTPU | IAVF_RSS_TYPE_INNER_IPV4_TCP
> - ETH_RSS_GTPU | IAVF_RSS_TYPE_INNER_IPV6
> - ETH_RSS_GTPU | IAVF_RSS_TYPE_INNER_IPV6_UDP
> - ETH_RSS_GTPU | IAVF_RSS_TYPE_INNER_IPV6_TCP
>
Seem that you add some specific negative flow case for the "ipv4(outer/inner) + gtpu" and "ipv4(outer/inner) + ipv4-udp(tcp)" in the currently invalid checking mode, so you commit log could be more clear and clean for that, thanks.
> Fixes: 91f27b2e39ab ("net/iavf: refactor RSS")
>
> Signed-off-by: Murphy Yang <murphyx.yang@intel.com>
> ---
> v2:
> - add invalid RSS combinations
>
> drivers/net/iavf/iavf_hash.c | 8 ++++++++
> 1 file changed, 8 insertions(+)
>
> diff --git a/drivers/net/iavf/iavf_hash.c b/drivers/net/iavf/iavf_hash.c index
> c4c73e6644..8393d8535b 100644
> --- a/drivers/net/iavf/iavf_hash.c
> +++ b/drivers/net/iavf/iavf_hash.c
> @@ -806,7 +806,15 @@ static void iavf_refine_proto_hdrs(struct
> virtchnl_proto_hdrs *proto_hdrs,
>
> static uint64_t invalid_rss_comb[] = {
> ETH_RSS_IPV4 | ETH_RSS_NONFRAG_IPV4_UDP,
> + ETH_RSS_IPV4 | ETH_RSS_NONFRAG_IPV4_TCP,
> ETH_RSS_IPV6 | ETH_RSS_NONFRAG_IPV6_UDP,
> + ETH_RSS_IPV6 | ETH_RSS_NONFRAG_IPV6_TCP,
> + ETH_RSS_GTPU | IAVF_RSS_TYPE_INNER_IPV4,
> + ETH_RSS_GTPU | IAVF_RSS_TYPE_INNER_IPV4_UDP,
> + ETH_RSS_GTPU | IAVF_RSS_TYPE_INNER_IPV4_TCP,
> + ETH_RSS_GTPU | IAVF_RSS_TYPE_INNER_IPV6,
> + ETH_RSS_GTPU | IAVF_RSS_TYPE_INNER_IPV6_UDP,
> + ETH_RSS_GTPU | IAVF_RSS_TYPE_INNER_IPV6_TCP,
Shouldn't it be " ETH_RSS_GTPU | ETH_RSS_IPV4" if outer ip case is the same? Whatever you should considerate both if you check one.
> RTE_ETH_RSS_L3_PRE32 | RTE_ETH_RSS_L3_PRE40 |
> RTE_ETH_RSS_L3_PRE48 | RTE_ETH_RSS_L3_PRE56 |
> RTE_ETH_RSS_L3_PRE96
> --
> 2.17.1
next prev parent reply other threads:[~2020-12-23 2:32 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-09 7:14 [dpdk-dev] [PATCH] " Murphy Yang
2020-12-18 6:18 ` [dpdk-dev] [PATCH v2] " Murphy Yang
2020-12-23 2:32 ` Guo, Jia [this message]
2020-12-23 6:21 ` [dpdk-dev] [PATCH v3] net/iavf: fix invalid RSS combinations rule can be created Murphy Yang
2020-12-23 8:03 ` [dpdk-dev] [PATCH v4] " Murphy Yang
2020-12-23 8:14 ` Guo, Jia
2020-12-24 2:20 ` [dpdk-dev] [PATCH v5] " Murphy Yang
2020-12-28 2:28 ` [dpdk-dev] [PATCH v6] " Murphy Yang
2021-01-07 7:58 ` [dpdk-dev] [PATCH v7] " Murphy Yang
2021-01-07 9:17 ` [dpdk-dev] [PATCH v8] " Murphy Yang
2021-01-07 9:33 ` Guo, Jia
2021-01-12 4:52 ` Zhang, Qi Z
2021-01-13 5:13 ` Huang, ZhiminX
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0521afdc0554421ae64654e4e441273@intel.com \
--to=jia.guo@intel.com \
--cc=beilei.xing@intel.com \
--cc=dev@dpdk.org \
--cc=jingjing.wu@intel.com \
--cc=murphyx.yang@intel.com \
--cc=qiming.yang@intel.com \
--cc=stevex.yang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).