From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1D512A0613 for ; Wed, 28 Aug 2019 09:02:39 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 09FFA1C1FA; Wed, 28 Aug 2019 09:02:38 +0200 (CEST) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id CE7311C1F7 for ; Wed, 28 Aug 2019 09:02:36 +0200 (CEST) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us4.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 599AA800056; Wed, 28 Aug 2019 07:02:35 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Wed, 28 Aug 2019 08:02:29 +0100 To: Aaron Conole CC: Thomas Monjalon , Ferruh Yigit , "dev@dpdk.org" , Ivan Ilchenko References: <1566915962-5472-1-git-send-email-arybchenko@solarflare.com> From: Andrew Rybchenko Message-ID: Date: Wed, 28 Aug 2019 10:02:26 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-24874.003 X-TM-AS-Result: No-6.833800-8.000000-10 X-TMASE-MatchedRID: L8tZF6zWW2o4Q7K/HmUF53bspjK6JP6qJuDBbd4NSqQNWA0aQ3FdiCGU b2JNxi1q2RIa0u5oeaZOYuXMsEGdZb9z4PlYm1BmiS8eKdD/7uTkJIYDKPF738uSXx71bvSLVtO 0mkb0wEE+NfMMkHtdnHn08LPIYQ+CDC95KVTkYTNl1tleYYUuJ1TOtbWMttjRmJBe2bRXwlPZXi 1JO1AnlWucv55egCLuffLk5O83BXuh3teCk0woM6Hs7urN7C7gfS0Ip2eEHny+qryzYw2E8CKve Q4wmYdMFBpuM64i9KELbigRnpKlKWxlRJiH4397/8vbVljwnVWNTZ5HInELTr8vNZJpAKbtAmgG X5xEluYzHTHAlhj2Zw== X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--6.833800-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-24874.003 X-MDID: 1566975756-qR1o-X_Rrgap Subject: Re: [dpdk-dev] [PATCH 00/51] ethdev: change rte_eth_dev_info_get() return value to int X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/27/19 11:47 PM, Aaron Conole wrote: > Andrew Rybchenko writes: > >> It is the first patch series to get rid of void returning functions >> in ethdev in accordance with deprecation notice [1]. > This is a huge series, and I suggest to combine some of the work, and/or > break it up. I can send patches for examples separately, but it will not help a lot. I can squash changes in examples, but I think it is wrong since it would make review harder - different maintainers and different practices to handle error in different examples (and we tried to take it into account). Other ideas? > Additionally, this patch breaks the ring_pmd_autotest unit test, but I > didn't bisect it to find out where. Many thanks, we'll take a look.