From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 4840423A for ; Tue, 21 Nov 2017 19:10:41 +0100 (CET) Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga101.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 21 Nov 2017 10:10:40 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.44,432,1505804400"; d="scan'208";a="4889725" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.224.243]) ([10.241.224.243]) by orsmga003.jf.intel.com with ESMTP; 21 Nov 2017 10:10:40 -0800 To: Pavan Nikhilesh Bhagavatula , Thomas Monjalon , olivier.matz@6wind.com Cc: dev@dpdk.org References: <20171116103144.4197-1-pbhagavatula@caviumnetworks.com> <1772478.GecVQuhyhE@xps> <20171121111416.yffsbci3cswwpzx5@Pavan-LT> <5684106.7xpmVRmQS0@xps> <20171121140451.hq4niywykhqgvzbx@Pavan-LT> From: Ferruh Yigit Message-ID: Date: Tue, 21 Nov 2017 10:10:40 -0800 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.4.0 MIME-Version: 1.0 In-Reply-To: <20171121140451.hq4niywykhqgvzbx@Pavan-LT> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 2/2] eal: fix dynamic logs failing to print X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 21 Nov 2017 18:10:42 -0000 On 11/21/2017 6:04 AM, Pavan Nikhilesh Bhagavatula wrote: > On Tue, Nov 21, 2017 at 02:30:48PM +0100, Thomas Monjalon wrote: >> 21/11/2017 12:14, Pavan Nikhilesh Bhagavatula: >>> On Tue, Nov 21, 2017 at 11:55:00AM +0100, Thomas Monjalon wrote: >>>> 20/11/2017 19:40, Ferruh Yigit: > >>> >>> I will be sending out the patch set soon. >> >> These are only the legacy static log types. >> Are you sure you want to change them? >> They should be removed when using dynamic logging. > > Actually this same struct is used for registering dynamic logs for legacy > modules currently, > > /* register legacy log types */ > for (i = 0; i < RTE_DIM(logtype_strings); i++) > __rte_log_register(logtype_strings[i].logtype, > logtype_strings[i].log_id); > > I have just prefixed them with "lib.". If we remove this form here then each > module has to use constructor style initialisation for logs which would be a > lot of rework. That work of each library registering dynamic log themselves needs to be done somehow but that is bigger task, for this patch just renaming static ones to be consistent can be enough I think. Thanks, ferruh