DPDK patches and discussions
 help / color / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: "Wei Hu (Xavier)" <xavier.huwei@tom.com>, dev@dpdk.org, stable@dpdk.org
Cc: huwei87@hisilicon.com
Subject: Re: [dpdk-dev] [PATCH] net/hns3: fix checking enough Tx BDs
Date: Mon, 25 Nov 2019 15:55:30 +0000
Message-ID: <e072bc02-fdec-ce2a-153f-bd2faa4c2661@intel.com> (raw)
In-Reply-To: <20191125090053.974-1-xavier.huwei@tom.com>

On 11/25/2019 9:00 AM, Wei Hu (Xavier) wrote:
> From: "Wei Hu (Xavier)" <xavier.huwei@huawei.com>
> 
> In .tx_pkt_burst ops implementation function of hns3 PMD driver,
> there is one check whether there are enough BDs in the TX queue.

Out of curiosity, is BD refers to "buffer descriptor"? What is the difference
between Tx descriptor and TX BD?

> If not, driver will stop sending the packets.
> 
> Currently in the 'for' process loop, the next_to_use member of
> TX queue is not updated in time after processing BDs of one packet,
> which results in the invalid action of checking whether there are
> enough BDs and failure in sending packets.
> 
> This patch fixes it by moving the assignment statment of the
> next_to_use member of TX queue to the place after porcessing TX BDs
> in the 'for' loop.
> 
> Fixes: bba636698316 ("net/hns3: support Rx/Tx and related operations")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Hongbo Zheng <zhenghongbo3@huawei.com>
> Signed-off-by: Huisong Li <lihuisong@huawei.com>
> Signed-off-by: Wei Hu (Xavier) <xavier.huwei@huawei.com>
> ---
>  drivers/net/hns3/hns3_rxtx.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/net/hns3/hns3_rxtx.c b/drivers/net/hns3/hns3_rxtx.c
> index 34cb7faf9..816644713 100644
> --- a/drivers/net/hns3/hns3_rxtx.c
> +++ b/drivers/net/hns3/hns3_rxtx.c
> @@ -1649,6 +1649,7 @@ hns3_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
>  		} while (m_seg != NULL);
>  
>  		nb_hold += i;
> +		txq->next_to_use = tx_next_use;
>  	}
>  
>  end_of_tx:
> @@ -1656,7 +1657,6 @@ hns3_xmit_pkts(void *tx_queue, struct rte_mbuf **tx_pkts, uint16_t nb_pkts)
>  	if (likely(nb_tx)) {
>  		hns3_queue_xmit(txq, nb_hold);
>  		txq->next_to_clean = tx_next_clean;
> -		txq->next_to_use   = tx_next_use;
>  		txq->tx_bd_ready   = tx_bd_ready - nb_hold;
>  	}
>  
> 


  reply index

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-11-25  9:00 Wei Hu (Xavier)
2019-11-25 15:55 ` Ferruh Yigit [this message]
2019-11-25 16:12 ` Ferruh Yigit

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e072bc02-fdec-ce2a-153f-bd2faa4c2661@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=dev@dpdk.org \
    --cc=huwei87@hisilicon.com \
    --cc=stable@dpdk.org \
    --cc=xavier.huwei@tom.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
		dev@dpdk.org
	public-inbox-index dev


Newsgroup available over NNTP:
	nntp://inbox.dpdk.org/inbox.dpdk.dev


AGPL code for this site: git clone https://public-inbox.org/ public-inbox