From: Maxime Coquelin <maxime.coquelin@redhat.com>
To: Tiwei Bie <tiwei.bie@intel.com>, zhihong.wang@intel.com, dev@dpdk.org
Subject: Re: [dpdk-dev] [PATCH 1/2] net/virtio: drop duplicated reset method
Date: Tue, 30 Oct 2018 10:10:20 +0100 [thread overview]
Message-ID: <e0927b03-b70f-aa74-b3e4-1da86489f4ab@redhat.com> (raw)
In-Reply-To: <20181025094659.25492-2-tiwei.bie@intel.com>
On 10/25/18 11:46 AM, Tiwei Bie wrote:
> Drop the duplicated reset() method in virtio_pci_ops. Currently
> vtpci_reset() is implemented on set_status() and get_status()
> directly. The reset() method in virtio_pci_ops isn't used and
> its implementation in the legacy device isn't right.
>
> Signed-off-by: Tiwei Bie <tiwei.bie@intel.com>
> ---
> drivers/net/virtio/virtio_pci.c | 15 ---------------
> drivers/net/virtio/virtio_pci.h | 1 -
> drivers/net/virtio/virtio_user_ethdev.c | 1 -
> 3 files changed, 17 deletions(-)
>
Reviewed-by: Maxime Coquelin <maxime.coquelin@redhat.com>
Thanks,
Maxime
next prev parent reply other threads:[~2018-10-30 9:10 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-10-25 9:46 [dpdk-dev] [PATCH 0/2] Some fixes for virtio and vhost Tiwei Bie
2018-10-25 9:46 ` [dpdk-dev] [PATCH 1/2] net/virtio: drop duplicated reset method Tiwei Bie
2018-10-30 9:10 ` Maxime Coquelin [this message]
2018-10-25 9:46 ` [dpdk-dev] [PATCH 2/2] net/vhost: fix parameters string Tiwei Bie
2018-10-30 9:10 ` Maxime Coquelin
2018-10-30 10:56 ` [dpdk-dev] [PATCH 0/2] Some fixes for virtio and vhost Maxime Coquelin
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e0927b03-b70f-aa74-b3e4-1da86489f4ab@redhat.com \
--to=maxime.coquelin@redhat.com \
--cc=dev@dpdk.org \
--cc=tiwei.bie@intel.com \
--cc=zhihong.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).