From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 25113FE5 for ; Fri, 31 Mar 2017 11:26:26 +0200 (CEST) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 8FA0D5713; Fri, 31 Mar 2017 09:26:25 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 8FA0D5713 Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx06.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=maxime.coquelin@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 8FA0D5713 Received: from [10.36.112.26] (ovpn-112-26.ams2.redhat.com [10.36.112.26]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 6976617C32; Fri, 31 Mar 2017 09:26:24 +0000 (UTC) To: Yuanhan Liu , dev@dpdk.org References: <1490253059-28112-1-git-send-email-yuanhan.liu@linux.intel.com> <1490705142-893-1-git-send-email-yuanhan.liu@linux.intel.com> <1490705142-893-22-git-send-email-yuanhan.liu@linux.intel.com> Cc: Harris James R , Liu Changpeng From: Maxime Coquelin Message-ID: Date: Fri, 31 Mar 2017 11:26:22 +0200 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1490705142-893-22-git-send-email-yuanhan.liu@linux.intel.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.30]); Fri, 31 Mar 2017 09:26:25 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH v3 21/22] vhost: do not destroy device on repeat mem table message X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 31 Mar 2017 09:26:27 -0000 On 03/28/2017 02:45 PM, Yuanhan Liu wrote: > It doesn't make any sense to invoke destroy_device() callback at > while handling SET_MEM_TABLE message. > > From the vhost-user spec, it's the GET_VRING_BASE message indicates > the end of a vhost device: the destroy_device() should be invoked > from there (luckily, we already did that). > > Signed-off-by: Yuanhan Liu > --- > lib/librte_vhost/vhost_user.c | 6 ------ > 1 file changed, 6 deletions(-) Reviewed-by: Maxime Coquelin Thanks, Maxime