From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <ferruh.yigit@intel.com> Received: from mga09.intel.com (mga09.intel.com [134.134.136.24]) by dpdk.org (Postfix) with ESMTP id 4098B5597 for <dev@dpdk.org>; Thu, 16 Feb 2017 11:07:59 +0100 (CET) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by orsmga102.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 16 Feb 2017 02:07:58 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.35,168,1484035200"; d="scan'208";a="65868788" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.252.0.57]) ([10.252.0.57]) by fmsmga005.fm.intel.com with ESMTP; 16 Feb 2017 02:07:57 -0800 To: Thomas Monjalon <thomas.monjalon@6wind.com> References: <20170214151326.7554-1-ferruh.yigit@intel.com> <3106919.K5kYvNu2Ff@xps13> <d8920be0-5629-2ee2-fe90-9265fb07b0d6@intel.com> <2590637.Rj3BpoAWc4@xps13> Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>, John McNamara <john.mcnamara@intel.com>, Keith Wiles <keith.wiles@intel.com> From: Ferruh Yigit <ferruh.yigit@intel.com> Message-ID: <e0a14acc-a6e7-0aaf-414c-01cbee16fb20@intel.com> Date: Thu, 16 Feb 2017 10:07:56 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.7.1 MIME-Version: 1.0 In-Reply-To: <2590637.Rj3BpoAWc4@xps13> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 2/4] mk: do not build tests by default X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <http://dpdk.org/ml/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://dpdk.org/ml/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <http://dpdk.org/ml/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Thu, 16 Feb 2017 10:08:00 -0000 On 2/16/2017 8:53 AM, Thomas Monjalon wrote: > 2017-02-15 17:30, Ferruh Yigit: >> On 2/15/2017 4:58 PM, Thomas Monjalon wrote: >>> 2017-02-15 15:26, Ferruh Yigit: >>>> +.PHONY: test-buid >>>> +test-build: >>>> + $(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdkconfig.mk checkconfig >>>> + $(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdkbuild.mk test >>> >>> Why not rely on default rule below? >>> >>> # all other build targets >>> %: >>> $(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdkconfig.mk checkconfig >>> $(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdkbuild.mk $@ >> >> >> Because generic rule is using "rte.sdkbuild.mk $@" rule, >> for unit-test, $@ is test-build, but sdkbuild rule is "test" >> >> This can be solved with adding following to sdkbuild.mk: >> >> --- a/mk/rte.sdkbuild.mk >> +++ b/mk/rte.sdkbuild.mk >> @@ -72,6 +72,9 @@ clean: $(CLEANDIRS) >> $(Q)$(MAKE) -f $(RTE_SDK)/GNUmakefile gcovclean >> @echo Clean complete >> >> +.PHONY: test-build >> +test-build: test >> + >> .SECONDEXPANSION: >> .PHONY: $(ROOTDIRS-y) test >> $(ROOTDIRS-y) tes >> >> >> I can update if you think this is better? > > Yes it seems better. Or you can just rename test into test-build > in rte.sdkbuild.mk. Can't update to "test-build" in rte.sdkbuild.mk, it needs to be folder name. I will send new version with above update. Thanks, ferruh