From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id A9F62A00C2; Thu, 31 Oct 2019 09:26:03 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 4C8F81C1EC; Thu, 31 Oct 2019 09:26:03 +0100 (CET) Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [148.163.129.52]) by dpdk.org (Postfix) with ESMTP id AF4551C1EB for ; Thu, 31 Oct 2019 09:26:01 +0100 (CET) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 9F8F1A80071; Thu, 31 Oct 2019 08:25:59 +0000 (UTC) Received: from [192.168.38.17] (91.220.146.112) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1395.4; Thu, 31 Oct 2019 08:25:51 +0000 To: Ori Kam , John McNamara , Marko Kovacevic , Thomas Monjalon , Ferruh Yigit CC: , , References: <1569479349-36962-1-git-send-email-orika@mellanox.com> <1572479604-178752-1-git-send-email-orika@mellanox.com> <1572479604-178752-3-git-send-email-orika@mellanox.com> From: Andrew Rybchenko Message-ID: Date: Thu, 31 Oct 2019 11:25:47 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.9.0 MIME-Version: 1.0 In-Reply-To: <1572479604-178752-3-git-send-email-orika@mellanox.com> Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 8bit Content-Language: en-GB X-Originating-IP: [91.220.146.112] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.5.1010-25012.003 X-TM-AS-Result: No-12.178400-8.000000-10 X-TMASE-MatchedRID: oTBA/+sdKabmLzc6AOD8DTIjK23O9D33t3aeg7g/usAw9y3BDa9b9zlC Rr8Hb3qiXbLhfvpbIkhJgn8XPCcYRnT3K3VineCfUyxW4vmvLt1p4xorO9dSmQL+e4+Xk/QWUgA DWWOEbmOlU76g3hjL6Y9CL1e45ag4e8IZZuexAA1j/0faIOjwJcu99zcLpJbCvn1ivDdpAIfZKH JWG1IbEMY8S4CNjYg31NYOJTtXRe0GaM8Sbi/kM9dFDwSoLmcbfS0Ip2eEHnzUHQeTVDUrItRnE QCUU+jzjoczmuoPCq3A9Tvkj/YsjRsqZtVT7Ip6V5Mzdy+2CDqwMdPGGy60NAtyTWUf8XsF X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-TMASE-Result: 10--12.178400-8.000000 X-TMASE-Version: SMEX-12.5.0.1300-8.5.1010-25012.003 X-MDID: 1572510361-1M-0YFK6fBxP Subject: Re: [dpdk-dev] [PATCH v7 02/14] ethdev: add support for hairpin queue X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/31/19 2:53 AM, Ori Kam wrote: > This commit introduce hairpin queue type. > > The hairpin queue in build from Rx queue binded to Tx queue. > It is used to offload traffic coming from the wire and redirect it back > to the wire. > > There are 3 new functions: > - rte_eth_dev_hairpin_capability_get > - rte_eth_rx_hairpin_queue_setup > - rte_eth_tx_hairpin_queue_setup > > In order to use the queue, there is a need to create rte_flow > with queue / RSS action that targets one or more of the Rx queues. > > Signed-off-by: Ori Kam > Reviewed-by: Andrew Rybchenko LGTM, one note below which could be fixed on applying > diff --git a/lib/librte_ethdev/rte_ethdev_version.map b/lib/librte_ethdev/rte_ethdev_version.map > index e59d516..48b5389 100644 > --- a/lib/librte_ethdev/rte_ethdev_version.map > +++ b/lib/librte_ethdev/rte_ethdev_version.map > @@ -288,4 +288,7 @@ EXPERIMENTAL { > rte_eth_rx_burst_mode_get; > rte_eth_tx_burst_mode_get; > rte_eth_burst_mode_option_name; > + rte_eth_rx_hairpin_queue_setup; > + rte_eth_tx_hairpin_queue_setup; > + rte_eth_dev_hairpin_capability_get; > }; As I understand  rte_eth_dev_is_rx_hairpin_queue() and rte_eth_dev_is_tx_hairpin_queue() should be listed above. Yes, these functions are internal, but used in header inline functions and should be visible outside. We have discussed similar case recently in [1]. [1] http://inbox.dpdk.org/dev/20191030142938.bpi4txlrebqfq7uw@platinum/