From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 3E118A04AD; Fri, 1 May 2020 16:03:00 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 1838C1DA3F; Fri, 1 May 2020 16:03:00 +0200 (CEST) Received: from mail-wm1-f66.google.com (mail-wm1-f66.google.com [209.85.128.66]) by dpdk.org (Postfix) with ESMTP id DFE561D9D9 for ; Fri, 1 May 2020 16:02:57 +0200 (CEST) Received: by mail-wm1-f66.google.com with SMTP id x25so6056386wmc.0 for ; Fri, 01 May 2020 07:02:57 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:message-id:subject:from:to:cc:date:in-reply-to :references:content-transfer-encoding:user-agent:mime-version; bh=Y/7WrLnHSvYiHGv8QYvoLHJpRYaM38VhN3nzjexIMCY=; b=r8+yZ2kAP/vNxLnrZgW4+2hm2nEcBnx+3qD8kGUoZv+dl6TMXleltKTLDIZkkiEcRQ ErK43obXB6FErurTUC/RohiC6OtOYwcemSvzgQ2cmfzc3uDx0ksrKB3oft/rZmN/UL8B x+HndlDvlSe4zGSnMry/bI8GvQjNa53nwlu9w+ggDHVR8C29HIi32Go871npqc+XI8ih KUWBnAqTIQwYfv6NWyxhvdQ/eGm8pfBwu/Yqf9ev/u4uAaOmUAwLTovQa+zOUUOseyXG iog0TpPu/yeESxk60Oy33KlYPqsopfQTD72bpZe260YWJDcMmnzAdkQSvaiwGcj8Z1SA v3SQ== X-Gm-Message-State: AGi0PuasKCw0IlOJdQob2PIWhyfV86dnZvjAGoorw4CHjulQ5caG0L0V /Nopi4JXbf7rAX9eecxB6HM= X-Google-Smtp-Source: APiQypKViayMUhgBuoXy6soomCo6aOypptiX/AV1nv2UMPjpz7JMOYVPu7PVc/hT0Y4pvWZcomkTXQ== X-Received: by 2002:a1c:2e91:: with SMTP id u139mr4084243wmu.18.1588341777585; Fri, 01 May 2020 07:02:57 -0700 (PDT) Received: from localhost ([88.98.246.218]) by smtp.gmail.com with ESMTPSA id m188sm4062068wme.47.2020.05.01.07.02.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 01 May 2020 07:02:56 -0700 (PDT) Message-ID: From: Luca Boccassi To: Bruce Richardson , dev@dpdk.org Cc: thomas@monjalon.net, david.marchand@redhat.com, ktraynor@redhat.com Date: Fri, 01 May 2020 15:02:56 +0100 In-Reply-To: <20200501135401.28124-1-bruce.richardson@intel.com> References: <20200429100831.398-1-bruce.richardson@intel.com> <20200501135401.28124-1-bruce.richardson@intel.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 0/7] improve DPDK static builds with meson X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On Fri, 2020-05-01 at 14:53 +0100, Bruce Richardson wrote: > This set fixes a number of minor issues with static builds when using > meson, both for linking apps/examples as part of a meson build itself or > when using pkg-config subsequently. >=20 > Following this patchset, all DPDK static builds should be linking with > --whole-archive to ensure all lib and driver constructors are included, > and the use of pkg-config for doing static builds is simplified. The > downside is that for correctness we need two .pc files for DPDK rather > than just one. >=20 > v2: improved log messages for a number of patches, and clearly marked > internal-only pkg-config file as such >=20 > Bruce Richardson (7): > build: always link-whole DPDK static libraries > build: remove unnecessary variable > devtools/test-meson-builds.sh: add pkg-config static builds > build: move pkg-config creation to separate file > build/pkg-config: output driver libs first for static build > build/pkg-config: improve static linking flags > build/pkg-config: prevent overlinking >=20 > app/meson.build | 2 +- > app/test/meson.build | 2 +- > buildtools/pkg-config/meson.build | 43 +++++++++++++++++++ > .../pkg-config/set-static-linker-flags.py | 38 ++++++++++++++++ > devtools/test-meson-builds.sh | 2 +- > doc/guides/prog_guide/build-sdk-meson.rst | 2 +- > drivers/meson.build | 2 +- > examples/bbdev_app/Makefile | 2 +- > examples/bond/Makefile | 2 +- > examples/cmdline/Makefile | 2 +- > examples/distributor/Makefile | 2 +- > examples/eventdev_pipeline/Makefile | 2 +- > examples/fips_validation/Makefile | 2 +- > examples/flow_classify/Makefile | 2 +- > examples/flow_filtering/Makefile | 2 +- > examples/helloworld/Makefile | 2 +- > examples/ioat/Makefile | 2 +- > examples/ip_fragmentation/Makefile | 2 +- > examples/ip_pipeline/Makefile | 2 +- > examples/ip_reassembly/Makefile | 2 +- > examples/ipsec-secgw/Makefile | 2 +- > examples/ipv4_multicast/Makefile | 2 +- > examples/kni/Makefile | 2 +- > examples/l2fwd-cat/Makefile | 2 +- > examples/l2fwd-crypto/Makefile | 2 +- > examples/l2fwd-event/Makefile | 2 +- > examples/l2fwd-jobstats/Makefile | 2 +- > examples/l2fwd-keepalive/Makefile | 2 +- > examples/l2fwd/Makefile | 2 +- > examples/l3fwd-acl/Makefile | 2 +- > examples/l3fwd-power/Makefile | 2 +- > examples/l3fwd/Makefile | 2 +- > examples/link_status_interrupt/Makefile | 2 +- > examples/meson.build | 6 +-- > examples/ntb/Makefile | 2 +- > examples/packet_ordering/Makefile | 2 +- > examples/ptpclient/Makefile | 2 +- > examples/qos_meter/Makefile | 2 +- > examples/qos_sched/Makefile | 2 +- > examples/rxtx_callbacks/Makefile | 2 +- > examples/service_cores/Makefile | 2 +- > examples/skeleton/Makefile | 2 +- > examples/tep_termination/Makefile | 2 +- > examples/timer/Makefile | 2 +- > examples/vdpa/Makefile | 2 +- > examples/vhost/Makefile | 2 +- > examples/vhost_blk/Makefile | 2 +- > examples/vhost_crypto/Makefile | 2 +- > examples/vmdq/Makefile | 2 +- > examples/vmdq_dcb/Makefile | 2 +- > lib/librte_telemetry/meson.build | 1 - > lib/meson.build | 2 +- > meson.build | 26 +---------- > 53 files changed, 134 insertions(+), 76 deletions(-) > create mode 100644 buildtools/pkg-config/meson.build > create mode 100644 buildtools/pkg-config/set-static-linker-flags.py Series-acked-by: Luca Boccassi --=20 Kind regards, Luca Boccassi