Re: [dpdk-dev] [PATCH 0/2] Non-supported offloads are ignored

[Ferruh Yigit <ferruh.yigit@intel.com>]

On 4/20/2018 11:45 AM, Sunil Kumar Kori wrote:
> Currently DPAA/DPAA2 driver returns error if non-supported offloads
> (Rx or Tx) are requested from user which causes init failures in
> multiple application.
> 
> Some offloads may be enabled by default in many hardware and cannot
> be disabled. These offloads cannot be part of capability as toggling
> is not allowed (Like CRC STRIP). Thus DPAA/DPAA2 driver will ignore
> such offloads and rather print warning message.

Hi Sunil,

I understand the usecase, and some PMDs already do same thing.

But instead of ignoring all offloads provided by user, can it be possible to
keep another list of offloads that are free to ignore and return warning for them.

For rest of the offloads you can still return error.

This lets application to get error if a really wrong offload set, also add more
information into driver about offload support and expectations, what do you think?

> 
> Sunil Kumar Kori (2):
>   net/dpaa: non supported offloads are ignored with warning
>   net/dpaa2: non supported offloads are ignored with warning
> 
>  drivers/net/dpaa/dpaa_ethdev.c   | 6 ++----
>  drivers/net/dpaa2/dpaa2_ethdev.c | 6 ++----
>  2 files changed, 4 insertions(+), 8 deletions(-)
>