From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id E83C1A0547; Fri, 10 Sep 2021 12:06:07 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 76C0640DDE; Fri, 10 Sep 2021 12:06:07 +0200 (CEST) Received: from shelob.oktetlabs.ru (shelob.oktetlabs.ru [91.220.146.113]) by mails.dpdk.org (Postfix) with ESMTP id F18FD406B4; Fri, 10 Sep 2021 12:06:05 +0200 (CEST) Received: from [192.168.38.17] (aros.oktetlabs.ru [192.168.38.17]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by shelob.oktetlabs.ru (Postfix) with ESMTPSA id 7B3687F4FE; Fri, 10 Sep 2021 13:06:05 +0300 (MSK) DKIM-Filter: OpenDKIM Filter v2.11.0 shelob.oktetlabs.ru 7B3687F4FE DKIM-Signature: v=1; a=rsa-sha256; c=simple/simple; d=oktetlabs.ru; s=default; t=1631268365; bh=o1Wql/dMPnPu3QrWHX43gp5HgFE4Rl9iSpWNg9X8FwI=; h=Subject:To:Cc:References:From:Date:In-Reply-To; b=CPhEAyDGi6Q1XwEpWOpWrQhb2VrE47ULK61dEy5/3OGW+doMJflJuZOMrjlyzxW6e 8hPB7yh9cdMnpcFV2rmpMl9aRAw1xDSBwkqR8q9n8Fd57QhnTC0/qwbNcyrKCVY9ej bVZkOc9dj4PM/jPqNqXlW8Tl2+guVxqAy+EcOjv8= To: Maxime Coquelin , dev@dpdk.org, chenbo.xia@intel.com, amorenoz@redhat.com, david.marchand@redhat.com, ferruh.yigit@intel.com, michaelba@nvidia.com, viacheslavo@nvidia.com Cc: stable@dpdk.org, nelio.laranjeiro@6wind.com References: <20210910091734.7023-1-maxime.coquelin@redhat.com> <20210910091734.7023-2-maxime.coquelin@redhat.com> From: Andrew Rybchenko Organization: OKTET Labs Message-ID: Date: Fri, 10 Sep 2021 13:06:05 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.13.0 MIME-Version: 1.0 In-Reply-To: <20210910091734.7023-2-maxime.coquelin@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 1/3] net/virtio: add initial RSS support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 9/10/21 12:17 PM, Maxime Coquelin wrote: > This patch adds RSS support to the Virtio PMD. It provides I'd drop the first sentence since summary already says so and suggest to start the second from "Provide ..." > the capability to update the hash key, hash types and reta reta -> RETA (see devtools/words-case.txt) > table on the fly (without needing to stop/start the > device). However, the key length and the number of reta reta -> RETA > entries are fixed to 40B and 128 entries respectively. This > is done in order to simplify the design, but may be > revisited later as the Virtio spec provides this > flexibility. I've failed to find F_RSS definion in virtio spec. Could you share the reference, please. Without the sepc it is almost impossible to review the code. > > Note that only VIRTIO_NET_F_RSS support is implemented, > VIRTIO_NET_F_HASH_REPORT, which would enable reporting the > packet RSS hash calculated by the device into mbuf.rss, is > not yet supported. > > Regarding the default RSS configuration, it has been > chosen to use the default Intel ixgbe key as default key, > and default reta is a simple modulo between the hash and reta -> RETA > the number of Rx queues. > > Signed-off-by: Maxime Coquelin > --- > doc/guides/nics/features/virtio.ini | 2 + > doc/guides/nics/virtio.rst | 3 + > doc/guides/rel_notes/release_21_11.rst | 5 + > drivers/net/virtio/virtio.h | 31 ++- > drivers/net/virtio/virtio_ethdev.c | 367 ++++++++++++++++++++++++- > drivers/net/virtio/virtio_ethdev.h | 3 +- > drivers/net/virtio/virtqueue.h | 21 ++ > 7 files changed, 426 insertions(+), 6 deletions(-) > > diff --git a/doc/guides/nics/features/virtio.ini b/doc/guides/nics/features/virtio.ini > index 48f6f393b1..883dd1426c 100644 > --- a/doc/guides/nics/features/virtio.ini > +++ b/doc/guides/nics/features/virtio.ini > @@ -14,6 +14,8 @@ Promiscuous mode = Y > Allmulticast mode = Y > Unicast MAC filter = Y > Multicast MAC filter = Y I'd say that RSS has = P should be added here. > +RSS key update = Y > +RSS reta update = Y > VLAN filter = Y > Basic stats = Y > Stats per queue = Y > diff --git a/doc/guides/nics/virtio.rst b/doc/guides/nics/virtio.rst > index 82ce7399ce..6e451cd67c 100644 > --- a/doc/guides/nics/virtio.rst > +++ b/doc/guides/nics/virtio.rst > @@ -73,6 +73,9 @@ In this release, the virtio PMD driver provides the basic functionality of packe > > * Virtio supports using port IO to get PCI resource when UIO module is not available. > > +* Virtio supports RSS Rx mode with 40B configurable hash key len, 128 len -> length > + configurable reta entries and configurable hash types. reta -> RETA > + > Prerequisites > ------------- > > diff --git a/doc/guides/rel_notes/release_21_11.rst b/doc/guides/rel_notes/release_21_11.rst > index d707a554ef..21d2b09838 100644 > --- a/doc/guides/rel_notes/release_21_11.rst > +++ b/doc/guides/rel_notes/release_21_11.rst > @@ -55,6 +55,11 @@ New Features > Also, make sure to start the actual text at the margin. > ======================================================= > > + * **Added initial RSS support to Virtio PMD.** > + > + Initial support for RSS receive mode has been added to the Virtio PMD, > + with the capability for the application to configure the hash Key, the > + reta and the hash types. Virtio hash reporting is yet to be added. reta -> RETA Please, add one more empty line to have two empty lines before the next section. > > Removed Items > ------------- [snip]