From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 48AB4A0546; Fri, 30 Apr 2021 22:59:21 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id C2C0B4014F; Fri, 30 Apr 2021 22:59:20 +0200 (CEST) Received: from mga05.intel.com (mga05.intel.com [192.55.52.43]) by mails.dpdk.org (Postfix) with ESMTP id 111E44013F for ; Fri, 30 Apr 2021 22:59:18 +0200 (CEST) IronPort-SDR: 2RZickPthHtiljUPSJdAoFbp29Cv2l6/DPEm+EPVfCmPOdm4mZTF4DWnc39f59ZPf04YOd8rD9 FiAehd2Q4IFA== X-IronPort-AV: E=McAfee;i="6200,9189,9970"; a="282718143" X-IronPort-AV: E=Sophos;i="5.82,263,1613462400"; d="scan'208";a="282718143" Received: from orsmga008.jf.intel.com ([10.7.209.65]) by fmsmga105.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Apr 2021 13:59:17 -0700 IronPort-SDR: YzHdXG1GjjU3FAeVd7537vgwtxjvGCiwk0Ol8sBTCsHMevJmYv+NVuiNFUgK3LXwI89upGCcty TpqQoDNuIgag== X-IronPort-AV: E=Sophos;i="5.82,263,1613462400"; d="scan'208";a="431617179" Received: from dwdohert-mobl1.ger.corp.intel.com (HELO [10.213.192.57]) ([10.213.192.57]) by orsmga008-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 30 Apr 2021 13:59:14 -0700 To: Ciara Power , dev@dpdk.org Cc: thomas@monjalon.net, gakhil@marvell.com, aconole@redhat.com, hemant.agrawal@nxp.com, anoobj@marvell.com, ruifeng.wang@arm.com, asomalap@amd.com, ajit.khaparde@broadcom.com, g.singh@nxp.com References: <20210423161820.2135053-1-ciara.power@intel.com> <20210423161820.2135053-4-ciara.power@intel.com> From: "Doherty, Declan" Message-ID: Date: Fri, 30 Apr 2021 21:59:10 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.10.0 MIME-Version: 1.0 In-Reply-To: <20210423161820.2135053-4-ciara.power@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 3/7] test/crypto: refactor to use sub-testsuites X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 23/04/2021 5:18 PM, Ciara Power wrote: > The existing implementation runs a giant cryptodev testsuite for most > autotests, which in turns runs one setup function regardless of device. > > This is now broken down into multiple testsuites, > that are used as sub-testsuites. Each autotest runs a general crypto > parent test suite, to which the sub-testsuites are added. > > For example, the AESNI_MB test runs "Cryptodev Unit Test Suite", > which has a setup function only to configure testsuite params. > Creation of vdevs in the setup function is no longer supported, > it is expected the user does this when running the app. > This autotest previously just ran the cryptodev_testsuite, > but now has the smaller sub-testsuites added to the parent suite instead. > The same test cases are being run as before. > > The scheduler autotest creates its own parent testsuite with nested > sub-testsuites, rather than using the cryptodev testsuite mentioned above. > This is due to it being more complex in execution, > by requiring setting different modes before running tests. > The scheduler autotest no longer requires the extra test cases to > attach/set mode/detach when running the blockcipher test cases for > each mode. The attach/set mode/detach functionality is now tested in a > sub-testsuite. When running the sub-testsuites for each mode, > the attach/set mode/detach happens in the setup and teardown functions > for that sub-testsuite. > > Signed-off-by: Ciara Power > .... > Hey Ciara, can you make sure to detail the new requirement in the unit test documentation about the need to create the sw crypto pmds using the --vdev EAL arguments.