From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 35401A034F; Wed, 10 Nov 2021 14:57:40 +0100 (CET) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 1F9024068B; Wed, 10 Nov 2021 14:57:40 +0100 (CET) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by mails.dpdk.org (Postfix) with ESMTP id 680E540683 for ; Wed, 10 Nov 2021 14:57:38 +0100 (CET) X-IronPort-AV: E=McAfee;i="6200,9189,10163"; a="212696741" X-IronPort-AV: E=Sophos;i="5.87,223,1631602800"; d="scan'208";a="212696741" Received: from orsmga001.jf.intel.com ([10.7.209.18]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 10 Nov 2021 05:57:37 -0800 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.87,223,1631602800"; d="scan'208";a="534053170" Received: from fmsmsx606.amr.corp.intel.com ([10.18.126.86]) by orsmga001.jf.intel.com with ESMTP; 10 Nov 2021 05:57:37 -0800 Received: from fmsmsx610.amr.corp.intel.com (10.18.126.90) by fmsmsx606.amr.corp.intel.com (10.18.126.86) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 10 Nov 2021 05:57:36 -0800 Received: from fmsmsx611.amr.corp.intel.com (10.18.126.91) by fmsmsx610.amr.corp.intel.com (10.18.126.90) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12; Wed, 10 Nov 2021 05:57:36 -0800 Received: from fmsedg602.ED.cps.intel.com (10.1.192.136) by fmsmsx611.amr.corp.intel.com (10.18.126.91) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.12 via Frontend Transport; Wed, 10 Nov 2021 05:57:36 -0800 Received: from NAM11-DM6-obe.outbound.protection.outlook.com (104.47.57.169) by edgegateway.intel.com (192.55.55.71) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.12; Wed, 10 Nov 2021 05:57:36 -0800 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=i1eA8St3N1zukiK2EGzdY+tgmt5jOW1IfF9r6J/XeQKw3Be5UwT8QouT6D0IhAE8ovwHQMde8t6wZHeHPo24pKcdWVXRtaLvyOsxhLs2CMaCwjfU32+6IhqIagBOiGMlK79mrB5Cn3dhcoDe8DE5GPXXAujGDUfkvf+N9kUJ8F+fyZBiGzj5rqmark/54nos6erGMU2QMX26uQNVZD3BhdPoGROxAfBZU7GGCtC5uQjnj0rPSqQWFVZPgM8M/MTXHmnZsBX7Jbomnn/t1bL33Xv/JqbPeUgNcyFQAeJEYKTJHFfNw/1MvfFZg1JLjkaBWCHk8PhHv2GI/NQA3fxXjg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=NQUtoU9UD2qlL3mun53ITOCUE2XPLMtfa2294iqLPD0=; b=hVviSSPy7eRm4dl6tEE10SBX8z0YI/sRf6VCRO0j77IxXiJHPO+Hph1hPVlbp1WRL6en94ZI9+ZWq/QdUxpxX4cbvBjqOGNyYWmChZHZkl6TWw2Mpf+LEjB71krSj2hb2B9pa0r//D4mWp4JVuIz+XEgNSZshSHC79iYPFwFKzfZN7LL8hH/b7rhtF+fICfI5xiq8keWjPP13cVvqWuDNqE5lph+zsRIaNwEs9hvprdPDdrU3yHdKSsNMI9S6GMtYD+787fdOglNyNwGjzX3etCRvb6JiUpOkA+H8EM6njhzY0/rmeKxbINNBRN6U2l8BQCGGPoaaCWkB96DGQNJJw== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=NQUtoU9UD2qlL3mun53ITOCUE2XPLMtfa2294iqLPD0=; b=kXzsoTTmO/g+kXqAA6lOXduvNPvYh4NEby6nkez7jDSP0Lpqsv4sEeUtD73euY0y5CCVQ8m7UhM+3ZUi8Z7RDLT48kpMLXS/FC8ri1hVYxrWMj3OZT0PThxhvJ2T5OQ4Z6YrXlcGc1bvPjn+q+owbzfj8eTUYcQ29R+9IOxMyN4= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB5079.namprd11.prod.outlook.com (2603:10b6:510:3d::6) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.15; Wed, 10 Nov 2021 13:57:35 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::bd7d:29be:3342:632c%6]) with mapi id 15.20.4669.017; Wed, 10 Nov 2021 13:57:35 +0000 Message-ID: Date: Wed, 10 Nov 2021 13:57:28 +0000 Content-Language: en-US To: Apeksha Gupta , , CC: , , References: <20211109113432.11876-6-apeksha.gupta@nxp.com> <20211110074829.16654-1-apeksha.gupta@nxp.com> <20211110074829.16654-6-apeksha.gupta@nxp.com> From: Ferruh Yigit Subject: Re: [PATCH v9 5/5] net/enetfec: add features X-User: ferruhy In-Reply-To: <20211110074829.16654-6-apeksha.gupta@nxp.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO4P123CA0461.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1aa::16) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 Received: from [192.168.0.206] (37.228.236.146) by LO4P123CA0461.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1aa::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4690.16 via Frontend Transport; Wed, 10 Nov 2021 13:57:33 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 0f30241c-ccde-4b37-85ab-08d9a4520c29 X-MS-TrafficTypeDiagnostic: PH0PR11MB5079: X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:4125; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: ru/gY44xeGkxxhf9CZzzVp/Dp4R0hT27f1bKDP4mszdQtGiKi2sxeySieydB+8Z63cO5aFtYsYSv/8QQEfSMAnzOPZFPa6u3q2KUHOeUvnGx5pZ2SWZ8kQnCeyZjq01AbWnJm2UQZfNL3TiEZyk2fdSKIaw+8fdsX2Jwv4DOoQ7BV/nlEFr1zJabuGu11WZSnXMtlgAeeXgzQj/aUquwW9Iw7EWISthCMGO7f7WS6MbS66AdyUh+TuEa5F1fSWKR9KCNZHtb9r8I/mBAMJP5dD6pDXA41q7aG5bzA2twzNYKlLPYX5JnBa8y7jO59IhwIM4LXR+Cg2ePLkDpV/30bc51yn0mvRcaGOqDYSPnbMgN7A8KiIXW9MSBTCPIfCj0kUan++6150Hzr5gN25iYMvKxuVHUP0yZJqNMZEF2RRHRFBSQarqShz9nANpSRp4h5QvqQgOBq/Xtwv5Ertv3x5EnuEWMPulc6DeaXgOPecXMddOyQEXFel67NW7QHYxK//EiHI5UpfACVx04IdWB691ihyzn4Nx+v87/1I0KAsg1BpF8a4/C/wi7LmF9tetZ+X/z2XYynUANxo1PWSo6WYDVjE3LF91QtjtYWiKxjBUiwrkzTqppw2QzYFI6+VoHOXMv31Xtoz3WEf1JPe7KCG1WRiK6G4r01+tm552FO6uhizBN45mDZEN/gPzlhNu1lwvMMgA0HuckHBLwq0dqeQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(366004)(508600001)(2616005)(956004)(83380400001)(16576012)(8936002)(4326008)(6486002)(31696002)(6666004)(44832011)(8676002)(36756003)(82960400001)(31686004)(38100700002)(186003)(2906002)(53546011)(66476007)(66556008)(66946007)(26005)(86362001)(316002)(5660300002)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?VkZDUDNTb1JHMXYrRUQxREE1Wmo5YWlVNUhUVEJGUGJFQXJ4NENuakZlYzVF?= =?utf-8?B?K0FGWDJYTldtSDBzeGJJVWdsZ2tqYVl4VVplT281ZDN1QTJrbHlxejRVc0pu?= =?utf-8?B?VjlaMlFUeUhhbEdzcE4rS3BFektnV3JXM3FETzAzQTVubEdpd1NqaGdTZVg1?= =?utf-8?B?Q2IvTktpR2kzTDgrN2p2YjZJVGdEclNoMFhrSzJueHRtSEpaNlZQMDI4Snph?= =?utf-8?B?b3NQcE9lclJJeGhrV1UyZnUxTVNrWnVnQjZNU2I0MjBSNC9SZW1sUExlNHdG?= =?utf-8?B?NFllNUNTbm9HOGx0elV4cFg3bkdWWlZjb3FnSzNJZndkVzJUMHRxazlGRDlU?= =?utf-8?B?ZG5KdDIwZW1YUnlSQWdIVS9haTQ0Nm9uWW5WN04wU1Z2ZkZlMGhIb1A1MS9Q?= =?utf-8?B?MXFIeEdDSzBEdkVlLzdaN2krUjE0d0dKUWFEeGQzS0ZYTWdyaXF5ajYrSEQr?= =?utf-8?B?RndzZVZvcVAraXRrSTJzdktaRHY5MzQxOVV5WmhpOTFRZ1hVMmo5TVJCbWFa?= =?utf-8?B?OGZLMXYwdVpRY1FZcTE5TEU3TXVlem9nUW1wQllla3oxU0I2TXYvSm1ROWsy?= =?utf-8?B?bVNwcFl4a0Rhd1VXeWdvQWNrMWNoY1Y1K3JLSnFZcjZFWHluZWU4MTFLWFUw?= =?utf-8?B?VlZURDRYSlBnc05Fd2FzY204aTc3enhjUWxzcHNQMjhvWCsxTUNWeEhLemxK?= =?utf-8?B?MVlyeVU5bHB2bXdIamU4Sks4MHptbElEWXkrTGZjcnR3Uitka3N4dEZoWnJO?= =?utf-8?B?bTZRSWEwY2JhMmNZa2dESnFNRXRnRG8xcHppTGRxUTFrRlc4UGlvRGZvaW9z?= =?utf-8?B?Yi9BNGVrMHZQTlhQL3MvWklOdklNU3dzV25xdTFpb20wcWE2a213ZHF5emFX?= =?utf-8?B?WEJzMVoyUjQyRnVlVkxrK3pucE01ZkV2YVBxcm5jWGJnU2VKaTkvLzJyMlRX?= =?utf-8?B?ZE9JWWJsWGpTQkpIVEFZdkdJbXBMaE1HV3crWis2NzNyNzE2ajBub3d1S1d6?= =?utf-8?B?OVVTRnlpYkZtaFFlTVJia2dXQlNoTG1iZ05OQUZjRlVsV1R0bVdoQk5kcVRZ?= =?utf-8?B?KzFlZTlTSHU5dFd3UFpQTmgzNk9hd2hNNzRQZndLNU0ySXgzdW9pcmpzaks1?= =?utf-8?B?ZjV3VU56MDAreEgrdjdxYytWNjlhcU0vZG5GcTI4MWJZRlhWeC9Kbk8xOHBY?= =?utf-8?B?L2tUeEVCR3kxVGVzZlVQUFNDNUFCenpaZjYxSGp6ZHVMTVNmUjBuVkxVNFp5?= =?utf-8?B?Sk1qbElKSm1adU1DejljRzVtVE8rNnZEcXkxWndkV1J5dUd1aG9FQmFQZ1p3?= =?utf-8?B?QWhpcG1GQmVtZWQwMzF6UFR5LzkvQnY5Vk9ZU0w1WEdOYkR0T01KUGx4bms0?= =?utf-8?B?MFNJK2dvZU12VUMxeHRQYVV6QWN4ck9MNWxheFltRDAyVExJajhSSG1STHhF?= =?utf-8?B?QkdzUVJhMWljam00Q1NaRGZQTzVlNk1kb0VmNDFoYXByRlZaZkxMRzNTL1oy?= =?utf-8?B?YkU5QXorTkwvNGFBSStzWWFTeWhIcUxKT1ZyMCtnZW92ZmswMXo3eVRvOUwr?= =?utf-8?B?OUxCM3ljRHE3amRqY0xUMVBnQlNMZG91L1ZyZzhVUERWbWJzVGU1WUc4WFB5?= =?utf-8?B?ZHo1QkpYaGhKTDRtVS8xZlhhVHFKdmp6YjcvUFBHSi9CUGJBdWlTZllldFY0?= =?utf-8?B?NkRTeWtEcGY5d3FiR2ZocHBpMVo0V1N2MnE3emFqdkNacDJYbDRoYklNaUZy?= =?utf-8?B?SEVQcmNzMEdvVFU4NWFsS3pMdjVxdE5ONWRlT05IS3hrdUVodTRNaUlZTTdU?= =?utf-8?B?RTE2dWhxOXRFeVhuZGlVV0dseURmZWZaK2NRQW80Qk80eDZhZU1keEhhamZG?= =?utf-8?B?V1BpNmtDYUEyN2FkVnQyYkZDUmsremJyNVFyeUtmNzF0aWlHMEVMRUJRUFVh?= =?utf-8?B?d2hKejMyY3ZxNjlLcThDeUJ5N1Z6NU5kcjR1VEFEZzBLWEhjeGZFZkdkZ2Ew?= =?utf-8?B?NTg5UjRtL2dnMFpDNGl6eFN1S2QyWXFKaGY5V1ZQMTZHU0M4enpBcUYvNmxU?= =?utf-8?B?WWlJZE96eWsvRm16VEpzcGZ3S0V5aEQ0V1FKaCt6STlueURHcHdLNEpVTVl3?= =?utf-8?B?UTNCakpuWVBVd0RHdTFWQmViTFJJT0hEMFMvWlF3UUFRYVFaRmkxZU1UYnpH?= =?utf-8?Q?OrAyVA8bE1DPVaIgR0YbNyo=3D?= X-MS-Exchange-CrossTenant-Network-Message-Id: 0f30241c-ccde-4b37-85ab-08d9a4520c29 X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 10 Nov 2021 13:57:35.0306 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mxlEDD7KYnapMevDJ+/rcesTzW4qGQUbdLD96o/twa9ScIlWWZJbY619ek0Mlc8j0iXLDLtQ9t/SUiF1E/rNVg== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB5079 X-OriginatorOrg: intel.com X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/10/2021 7:48 AM, Apeksha Gupta wrote: > This patch adds checksum and VLAN offloads in enetfec network > poll mode driver. > > Signed-off-by: Sachin Saxena > Signed-off-by: Apeksha Gupta <...> > @@ -191,7 +195,12 @@ enet_free_buffers(struct rte_eth_dev *dev) > static int > enetfec_eth_configure(struct rte_eth_dev *dev) > { > - if (dev->data->dev_conf.rxmode.offloads & DEV_RX_OFFLOAD_KEEP_CRC) Instead of first adding 'DEV_RX_OFFLOAD_KEEP_CRC' and later fixing it in this patch, correct macro should be added at first place. <...> > @@ -86,6 +93,48 @@ enetfec_recv_pkts(void *rxq1, __rte_unused struct rte_mbuf **rx_pkts, > > rx_pkts[pkt_received] = mbuf; > pkt_received++; > + > + /* Extract the enhanced buffer descriptor */ > + ebdp = NULL; > + if (rxq->fep->bufdesc_ex) > + ebdp = (struct bufdesc_ex *)bdp; > + > + /* If this is a VLAN packet remove the VLAN Tag */ > + vlan_packet_rcvd = false; > + if ((rx_offloads & DEV_RX_OFFLOAD_VLAN) && Can you please use updated macro: RTE_ETH_RX_OFFLOAD_VLAN