From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Chas Williams <3chas3@gmail.com>, dev@dpdk.org
Cc: "John W. Linville" <linville@tuxdriver.com>
Subject: Re: [dpdk-dev] [PATCH] net/af_packet: initialize link interrupt callback queue
Date: Wed, 21 Dec 2016 15:26:21 +0000 [thread overview]
Message-ID: <e1100ff1-e429-79d1-5c32-b8067a8a1fba@intel.com> (raw)
In-Reply-To: <1482267451.1677.5.camel@gmail.com>
On 12/20/2016 8:57 PM, Chas Williams wrote:
> On Tue, 2016-12-20 at 14:20 +0000, Ferruh Yigit wrote:
>> On 12/17/2016 6:03 PM, Chas Williams wrote:
>>> This patch initializes the eth_dev->link_intr_cbs queue which is
>>> used when af_packet is passed into rte_eth_ev_callback_register().
>>
>> Why do you want to register callback to af_packet PMD, it won't be
>> calling them?
>
> Because I have a some other code that basically treats all the PMD's
> the same way. Do I really need to write an exception for that code
> that says "if this is driver such and such don't call this API routine?"
No, you shouldn't.
Thanks for the clarification.
>
>>>
>>> Fixes: 4dc294158cac ("ethdev: support optional Rx and Tx callbacks")
>>>
>>> Signed-off-by: Chas Williams <3chas3@gmail.com>
>>
>> Please cc the maintainers...
>
> OK
>
>>
>> CC: John W. Linville <linville@tuxdriver.com>
>>
>>> ---
>>> drivers/net/af_packet/rte_eth_af_packet.c | 1 +
>>> 1 file changed, 1 insertion(+)
>>>
>>> diff --git a/drivers/net/af_packet/rte_eth_af_packet.c b/drivers/net/af_packet/rte_eth_af_packet.c
>>> index a1e13ff..ea5070a 100644
>>> --- a/drivers/net/af_packet/rte_eth_af_packet.c
>>> +++ b/drivers/net/af_packet/rte_eth_af_packet.c
>>> @@ -708,6 +708,7 @@ rte_pmd_init_internals(const char *name,
>>> (*eth_dev)->data->drv_name = pmd_af_packet_drv.driver.name;
>>> (*eth_dev)->data->kdrv = RTE_KDRV_NONE;
>>> (*eth_dev)->data->numa_node = numa_node;
>>> + TAILQ_INIT(&((*eth_dev)->link_intr_cbs));
>>>
>>> return 0;
>>>
>>>
>>
>>
next prev parent reply other threads:[~2016-12-21 15:26 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2016-12-17 18:03 Chas Williams
2016-12-17 23:32 ` Stephen Hemminger
2016-12-20 14:20 ` Ferruh Yigit
2016-12-20 20:57 ` Chas Williams
2016-12-21 15:26 ` Ferruh Yigit [this message]
2016-12-21 15:30 ` Ferruh Yigit
2016-12-21 16:50 ` Ferruh Yigit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e1100ff1-e429-79d1-5c32-b8067a8a1fba@intel.com \
--to=ferruh.yigit@intel.com \
--cc=3chas3@gmail.com \
--cc=dev@dpdk.org \
--cc=linville@tuxdriver.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).