From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id AFC2B45955; Tue, 10 Sep 2024 13:30:54 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 5D1AE402AB; Tue, 10 Sep 2024 13:30:54 +0200 (CEST) Received: from mail-ed1-f52.google.com (mail-ed1-f52.google.com [209.85.208.52]) by mails.dpdk.org (Postfix) with ESMTP id 03863400D6 for ; Tue, 10 Sep 2024 13:30:53 +0200 (CEST) Received: by mail-ed1-f52.google.com with SMTP id 4fb4d7f45d1cf-5c255e3c327so5859091a12.1 for ; Tue, 10 Sep 2024 04:30:53 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=pantheon.tech; s=google; t=1725967852; x=1726572652; darn=dpdk.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ZMc7tj3lok726U5mG5jzJjhPj6orSg4XHbDwjzU1880=; b=dWMMp76zHI3C1zHe0/ldD93mh+aZj0v28bGDaTJbXmEB6XIqKfHyIpI+1ag2hvHSll 2djJTIT+oJWd4ISKxqcpHg8OBWeHAj7bF3Nh8NGKqvNJDHP8Erd6qATKX0iy3yFHiRLm yXoPL0qI5ecfV5JUF3yYYm9HN7tm9md1B91SBqa9YeQ4PZR/EN0oItItD8Wuk2azm9j4 zCJvJiPqUEwGZ8cqf/0fFYxk57XVPy7Er5HbZYk0lxZbOVLgvOor4K+q9WiFizgFc+F4 Kn5u4EC54dfQoWcbXFPNFTQN0jt8wysVNlyKtlIvkB+4brtUKTPCBLDXNMEeh0vTg4TB rifA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1725967852; x=1726572652; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ZMc7tj3lok726U5mG5jzJjhPj6orSg4XHbDwjzU1880=; b=mDqn0bP788znVZV5yaLGyLgBMktQ980+j4A9QHcuMxZV6TaSVdkrzmUpVOSDKGmQEk xfPoc0OJxpbNO2VoGHGOhz6XxXBkcdtLt7DL0qwD80rJAR/8cwDuly3+hf3twRJFCRsz Vgd0bzSPLO6X945ccEiL6HWTV3f/jbKI/ZeJM1R3rTLNKZoS2FxdcsuJ0fknmClyr3Be e3y0+ZHFF4h4jQR3w3KzSjOgAeh+lmJnwKAyhxgb+R1E4vxWb+dBfWYUTNSMWNVcGJp8 geFqFDr0d+lsMjz/DGlpz6dEr7BjKYjcB9Tu+Jq1f4qlWC0+AOIH3zZhkJTZyN82AC/0 pgOQ== X-Gm-Message-State: AOJu0YyeCZv43kU41b93m4EbwdqA3mVxYE72sx//VTJqeVIw+SX3nQ/T 1bruf/21o8VjR5peUjzpF9imYUUIXleaI5ggUCLigpZsXViZIu2AeOYxwuDmlZo= X-Google-Smtp-Source: AGHT+IFL7PSgY4Otfzy/mRKSIDyW2asznVyE0rNzGgeYPyKaPCRY0W+vJTQpffIQxee0SJceXpdVBA== X-Received: by 2002:a05:6402:35d4:b0:5be:fa43:8017 with SMTP id 4fb4d7f45d1cf-5c3dc798e0cmr8917634a12.16.1725967852229; Tue, 10 Sep 2024 04:30:52 -0700 (PDT) Received: from [10.12.0.236] (81.89.53.154.host.vnet.sk. [81.89.53.154]) by smtp.gmail.com with ESMTPSA id 4fb4d7f45d1cf-5c3ebd46853sm4113503a12.22.2024.09.10.04.30.51 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Tue, 10 Sep 2024 04:30:51 -0700 (PDT) Message-ID: Date: Tue, 10 Sep 2024 13:30:51 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/6] dts: Remove build target config and list of devices To: Nicholas Pratte , probb@iol.unh.edu, dmarx@iol.unh.edu, jspewock@iol.unh.edu, luca.vizzarro@arm.com, yoan.picchi@foss.arm.com, Honnappa.Nagarahalli@arm.com, paul.szczepanek@arm.com Cc: dev@dpdk.org References: <20240613201831.9748-3-npratte@iol.unh.edu> <20240705171341.23894-4-npratte@iol.unh.edu> Content-Language: en-US From: =?UTF-8?Q?Juraj_Linke=C5=A1?= In-Reply-To: <20240705171341.23894-4-npratte@iol.unh.edu> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org The subject line should be all lowercase (except for abbreviations and maybe some other exceptions). On 5. 7. 2024 19:13, Nicholas Pratte wrote: > Remove the list of devices from the schema, as these are unuesed. Typo: unuesed > Likewise, removed build-target information since these is not currently > used, and it is unlikely to be used in the future. Adjustments to the > dts.rst are made to reflect these changes. > diff --git a/dts/framework/config/__init__.py b/dts/framework/config/__init__.py > @@ -341,28 +325,20 @@ class BuildTargetConfiguration: > The configuration used for building DPDK. > > Attributes: > - arch: The target architecture to build for. > - os: The target os to build for. > - cpu: The target CPU to build for. > compiler: The compiler executable to use. > compiler_wrapper: This string will be put in front of the compiler when > executing the build. Useful for adding wrapper commands, such as ``ccache``. > name: The name of the compiler. > """ > > - arch: Architecture > - os: OS > - cpu: CPUType > compiler: Compiler > compiler_wrapper: str > - name: str > > @classmethod > def from_dict(cls, d: BuildTargetConfigDict) -> Self: > r"""A convenience method that processes the inputs before creating an instance. > > - `arch`, `os`, `cpu` and `compiler` are converted to :class:`Enum`\s and > - `name` is constructed from `arch`, `os`, `cpu` and `compiler`. > + `compiler` is converted to :class:`Enum`\s > > Args: > d: The configuration dictionary. > @@ -371,12 +347,8 @@ def from_dict(cls, d: BuildTargetConfigDict) -> Self: > The build target configuration instance. > """ > return cls( > - arch=Architecture(d["arch"]), > - os=OS(d["os"]), > - cpu=CPUType(d["cpu"]), > compiler=Compiler(d["compiler"]), > compiler_wrapper=d.get("compiler_wrapper", ""), > - name=f"{d['arch']}-{d['os']}-{d['cpu']}-{d['compiler']}", I think we can still keep this, we can just remove arch, os and cpu (there could be multiple build target, each with different compiler (gcc, clang, etc.)). If there's a reason to remove this, it should be mentioned in the commit message. > ) > > > diff --git a/dts/framework/config/conf_yaml_schema.json b/dts/framework/config/conf_yaml_schema.json > index f02a310bb5..3f7bc2acae 100644 > --- a/dts/framework/config/conf_yaml_schema.json > +++ b/dts/framework/config/conf_yaml_schema.json > @@ -6,76 +6,6 @@ > "ARCH": { > "type": "string", > "enum": [ > @@ -124,12 +54,6 @@ > "other" > ] > }, > - "os": { > - "$ref": "#/definitions/OS" > - }, > - "cpu": { > - "$ref": "#/definitions/cpu" > - }, Should we also remove arch that's above these two? > diff --git a/dts/framework/runner.py b/dts/framework/runner.py > index 6b6f6a05f5..2a1019899a 100644 > --- a/dts/framework/runner.py > +++ b/dts/framework/runner.py > @@ -480,7 +480,7 @@ def _run_build_target( > test_suites_with_cases: The test suites with test cases to run. > """ > self._logger.set_stage(DtsStage.build_target_setup) > - self._logger.info(f"Running build target '{build_target_config.name}'.") > + self._logger.info("Running build target.") If we keep build_target_config.name this should be reverted. > > try: > sut_node.set_up_build_target(build_target_config) > diff --git a/dts/framework/testbed_model/sut_node.py b/dts/framework/testbed_model/sut_node.py > index 2855fe0276..a4511157b7 100644 > --- a/dts/framework/testbed_model/sut_node.py > +++ b/dts/framework/testbed_model/sut_node.py > @@ -115,12 +115,7 @@ def remote_dpdk_build_dir(self) -> PurePath: > This is the directory where DPDK was built. > We assume it was built in a subdirectory of the extracted tarball. > """ > - if self._build_target_config: > - return self.main_session.join_remote_path( > - self._remote_dpdk_dir, self._build_target_config.name > - ) > - else: > - return self.main_session.join_remote_path(self._remote_dpdk_dir, "build") > + return self.main_session.join_remote_path(self._remote_dpdk_dir, "build") > Same here, revert if we keep build_target_config.name.