From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id C0812A04DE; Fri, 23 Oct 2020 02:59:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6FC286A5B; Fri, 23 Oct 2020 02:59:26 +0200 (CEST) Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by dpdk.org (Postfix) with ESMTP id 6C4855A8C; Fri, 23 Oct 2020 02:59:23 +0200 (CEST) IronPort-SDR: TN7yAFpisjFL1Pt0oNVfaFlcAkrBtB4bPmoZswMiaVVglFBGbXWbW/nKE97y0v15VvGUU/pt7x FxEHlFp1VkxA== X-IronPort-AV: E=McAfee;i="6000,8403,9782"; a="154570851" X-IronPort-AV: E=Sophos;i="5.77,404,1596524400"; d="scan'208";a="154570851" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga101.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 22 Oct 2020 17:59:22 -0700 IronPort-SDR: byMmm+IA/JBi4F3Pa3chNJHPwm+1F4RPsj6HtFibIjh9zBfD94EVCmsV0kLkc3/bs5Caz3LwNZ 3q5i4oYEb68A== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.77,404,1596524400"; d="scan'208";a="534195907" Received: from fmsmsx602.amr.corp.intel.com ([10.18.126.82]) by orsmga005.jf.intel.com with ESMTP; 22 Oct 2020 17:59:22 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by fmsmsx602.amr.corp.intel.com (10.18.126.82) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Thu, 22 Oct 2020 17:59:21 -0700 Received: from shsmsx601.ccr.corp.intel.com (10.109.6.141) by SHSMSX601.ccr.corp.intel.com (10.109.6.141) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.1713.5; Fri, 23 Oct 2020 08:59:19 +0800 Received: from shsmsx601.ccr.corp.intel.com ([10.109.6.141]) by SHSMSX601.ccr.corp.intel.com ([10.109.6.141]) with mapi id 15.01.1713.004; Fri, 23 Oct 2020 08:59:19 +0800 From: "Zhang, Qi Z" To: "Wang, Haiyue" , "Walsh, Conor" , "Guo, Jia" , "Yigit, Ferruh" , "Awal, Mohammad Abdul" , "Doherty, Declan" , "stable@dpdk.org" CC: "dev@dpdk.org" Thread-Topic: [PATCH v2 1/2] net/ixgbe: fix unchecked return value Thread-Index: AQHWpwNiqlAzWlfRiU6GPV3Wzf31kqmkYVpw Date: Fri, 23 Oct 2020 00:59:19 +0000 Message-ID: References: <20201019122620.749625-1-conor.walsh@intel.com> <20201020100248.761693-1-conor.walsh@intel.com> <20201020100248.761693-2-conor.walsh@intel.com> In-Reply-To: Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: dlp-reaction: no-action dlp-version: 11.5.1.3 dlp-product: dlpe-windows x-originating-ip: [10.239.127.36] Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: quoted-printable MIME-Version: 1.0 Subject: Re: [dpdk-dev] [PATCH v2 1/2] net/ixgbe: fix unchecked return value X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" > -----Original Message----- > From: dev On Behalf Of Wang, Haiyue > Sent: Wednesday, October 21, 2020 1:06 AM > To: Walsh, Conor ; Guo, Jia ; > Yigit, Ferruh ; Awal, Mohammad Abdul > ; Doherty, Declan > ; stable@dpdk.org > Cc: dev@dpdk.org > Subject: Re: [dpdk-dev] [PATCH v2 1/2] net/ixgbe: fix unchecked return va= lue >=20 > > -----Original Message----- > > From: Walsh, Conor > > Sent: Tuesday, October 20, 2020 18:03 > > To: Guo, Jia ; Wang, Haiyue > > ; Yigit, Ferruh ; Awal, > > Mohammad Abdul ; Doherty, Declan > > ; stable@dpdk.org > > Cc: dev@dpdk.org; Walsh, Conor > > Subject: [PATCH v2 1/2] net/ixgbe: fix unchecked return value > > > > The return value of rte_eth_switch_domain_alloc() was not being > > checked within ixgbe_pf_host_init() which caused a coverity issue. If > > the call fails a warning is logged using PMD_INIT_LOG() and *vfinfo is = free'd. > > ixgbe_pf_host_init() now has a return value which is checked in > > eth_ixgbe_dev_init() > > > > Coverity issue: 362795 > > Fixes: cf80ba6e2038 ("net/ixgbe: add support for representor ports") > > > > Signed-off-by: Conor Walsh > > --- > > drivers/net/ixgbe/ixgbe_ethdev.c | 11 +++++++++-- > > drivers/net/ixgbe/ixgbe_ethdev.h | 2 +- > > drivers/net/ixgbe/ixgbe_pf.c | 16 +++++++++++++--- > > 3 files changed, 23 insertions(+), 6 deletions(-) >=20 > Acked-by: Haiyue Wang Applied to dpdk-next-net-intel. Thanks Qi