DPDK patches and discussions
 help / color / mirror / Atom feed
* [dpdk-dev] [PATCH] net/af_xdp: fix xdp_get_channels_info return value
@ 2019-07-12  7:55 Július Milan
  2019-07-12 15:10 ` Stephen Hemminger
  2019-07-12 15:43 ` Ye Xiaolong
  0 siblings, 2 replies; 10+ messages in thread
From: Július Milan @ 2019-07-12  7:55 UTC (permalink / raw)
  To: dev, xiaolong.ye, qi.z.zhang, david.marchand

Procedure xdp_get_channels_info was returning error code -1 in case of
ioctl command SIOCETHTOOL was not supported. This patch sets return
value back to 0 as it is valid case.

Fixes: 339b88c6a9 ("net/af_xdp: support multi-queue")

Signed-off-by: Július Milan <jmilan.dev@gmail.com>
---
 drivers/net/af_xdp/rte_eth_af_xdp.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c b/drivers/net/af_xdp/rte_eth_af_xdp.c
index ff8e90589..33352e10a 100644
--- a/drivers/net/af_xdp/rte_eth_af_xdp.c
+++ b/drivers/net/af_xdp/rte_eth_af_xdp.c
@@ -852,9 +852,13 @@ xdp_get_channels_info(const char *if_name, int *max_queues,
 	ifr.ifr_data = (void *)&channels;
 	strncpy(ifr.ifr_name, if_name, IFNAMSIZ);
 	ret = ioctl(fd, SIOCETHTOOL, &ifr);
-	if (ret && errno != EOPNOTSUPP) {
-		ret = -errno;
-		goto out;
+	if (ret) {
+		if (errno == EOPNOTSUPP) {
+			ret = 0;
+		} else {
+			ret = -errno;
+			goto out;
+		}
 	}
 
 	if (channels.max_combined == 0 || errno == EOPNOTSUPP) {
-- 
2.21.0


^ permalink raw reply	[flat|nested] 10+ messages in thread
* [dpdk-dev] [PATCH] net/af_xdp: fix xdp_get_channels_info return value
@ 2019-07-12  7:40 Július Milan
  2019-07-12 15:09 ` Stephen Hemminger
  0 siblings, 1 reply; 10+ messages in thread
From: Július Milan @ 2019-07-12  7:40 UTC (permalink / raw)
  To: dev, xiaolong.ye, qi.z.zhang, david.marchand

Procedure xdp_get_channels_info was returning error code -1 in case of
unsupported ioctl command SIOCETHTOOL. This patch sets return
value back to 0 as it is valid case.

Fixes: 339b88c6a9 ("net/af_xdp: support multi-queue")

Signed-off-by: Július Milan <jmilan.dev@gmail.com>
---
 drivers/net/af_xdp/rte_eth_af_xdp.c | 10 +++++++---
 1 file changed, 7 insertions(+), 3 deletions(-)

diff --git a/drivers/net/af_xdp/rte_eth_af_xdp.c
b/drivers/net/af_xdp/rte_eth_af_xdp.c
index ff8e90589..33352e10a 100644
--- a/drivers/net/af_xdp/rte_eth_af_xdp.c
+++ b/drivers/net/af_xdp/rte_eth_af_xdp.c
@@ -852,9 +852,13 @@ xdp_get_channels_info(const char *if_name, int *max_queues,
     ifr.ifr_data = (void *)&channels;
     strncpy(ifr.ifr_name, if_name, IFNAMSIZ);
     ret = ioctl(fd, SIOCETHTOOL, &ifr);
-    if (ret && errno != EOPNOTSUPP) {
-        ret = -errno;
-        goto out;
+    if (ret) {
+        if (errno == EOPNOTSUPP) {
+            ret = 0;
+        } else {
+            ret = -errno;
+            goto out;
+        }
     }

     if (channels.max_combined == 0 || errno == EOPNOTSUPP) {
-- 
2.21.0

^ permalink raw reply	[flat|nested] 10+ messages in thread

end of thread, other threads:[~2019-07-12 16:07 UTC | newest]

Thread overview: 10+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2019-07-12  7:55 [dpdk-dev] [PATCH] net/af_xdp: fix xdp_get_channels_info return value Július Milan
2019-07-12 15:10 ` Stephen Hemminger
2019-07-12 15:35   ` Ferruh Yigit
2019-07-12 15:48     ` Stephen Hemminger
2019-07-12 16:07       ` Ferruh Yigit
2019-07-12 15:43 ` Ye Xiaolong
2019-07-12 15:01   ` Ferruh Yigit
2019-07-12 15:21     ` Stephen Hemminger
  -- strict thread matches above, loose matches on Subject: below --
2019-07-12  7:40 Július Milan
2019-07-12 15:09 ` Stephen Hemminger

This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).