Re: [dpdk-dev] [PATCH] ethdev: add missing buses in dev iterator

[Hemant Agrawal <hemant.agrawal@oss.nxp.com>]

On 4/29/2021 7:23 PM, Morten Brørup wrote:
>> From: dev [mailto:dev-bounces@dpdk.org] On Behalf Of Hemant Agrawal
>> Sent: Thursday, April 29, 2021 7:56 AM
>>
>> This patch fixes issue with OVS 2.15 not working on
>> DPAA/FSLMC based platform due to missing support for
>> these busses in dev_iterate.
>> This patch adds dpaa_bus and fslmc to dev iterator
>> for bus arguments.
>>
>> Fixes: 214ed1acd125 ("ethdev: add iterator to match devargs input")
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Hemant Agrawal <hemant.agrawal@nxp.com>
>> ---
>>   lib/ethdev/rte_ethdev.c | 4 +++-
>>   1 file changed, 3 insertions(+), 1 deletion(-)
>>
>> diff --git a/lib/ethdev/rte_ethdev.c b/lib/ethdev/rte_ethdev.c
>> index a1879765e8..483013ec7a 100644
>> --- a/lib/ethdev/rte_ethdev.c
>> +++ b/lib/ethdev/rte_ethdev.c
>> @@ -260,7 +260,9 @@ rte_eth_iterator_init(struct rte_dev_iterator
>> *iter, const char *devargs_str)
>>   	}
>>
>>   	/* Convert bus args to new syntax for use with new API
>> dev_iterate. */
>> -	if (strcmp(iter->bus->name, "vdev") == 0) {
>> +	if ((strcmp(iter->bus->name, "vdev") == 0) ||
>> +		(strcmp(iter->bus->name, "fslmc") == 0) ||
>> +		(strcmp(iter->bus->name, "dpaa_bus") == 0)) {
> Shouldn't that be "dpaa" instead of "dpaa_bus"?
The registered bus name is "dpaa_bus" only.
>
>>   		bus_param_key = "name";
>>   	} else if (strcmp(iter->bus->name, "pci") == 0) {
>>   		bus_param_key = "addr";
>> --
>> 2.17.1
>>