From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id B6DA55F2A for ; Wed, 14 Mar 2018 12:19:35 +0100 (CET) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga106.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Mar 2018 04:19:34 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.47,470,1515484800"; d="scan'208";a="25604945" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.237.220.112]) ([10.237.220.112]) by orsmga006.jf.intel.com with ESMTP; 14 Mar 2018 04:19:32 -0700 To: Xiao Wang , dev@dpdk.org Cc: zhihong.wang@intel.com, maxime.coquelin@redhat.com, yliu@fridaylinux.org, cunming.liang@intel.com, rosen.xu@intel.com, junjie.j.chen@intel.com, dan.daly@intel.com References: <20180309230809.63361-1-xiao.w.wang@intel.com> <20180309230809.63361-3-xiao.w.wang@intel.com> From: "Burakov, Anatoly" Message-ID: Date: Wed, 14 Mar 2018 11:19:31 +0000 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.6.0 MIME-Version: 1.0 In-Reply-To: <20180309230809.63361-3-xiao.w.wang@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH 2/3] bus/pci: expose sysfs parsing API X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Wed, 14 Mar 2018 11:19:36 -0000 On 09-Mar-18 11:08 PM, Xiao Wang wrote: > Some existing sysfs parsing functions are helpful for the later vDPA > driver, this patch make them global and expose them to shared lib. > > Signed-off-by: Xiao Wang > --- > drivers/bus/pci/linux/pci.c | 9 ++++----- > drivers/bus/pci/linux/pci_init.h | 8 ++++++++ > drivers/bus/pci/rte_bus_pci_version.map | 8 ++++++++ > 3 files changed, 20 insertions(+), 5 deletions(-) > > diff --git a/drivers/bus/pci/linux/pci.c b/drivers/bus/pci/linux/pci.c > index abde64119..81e5e5650 100644 > --- a/drivers/bus/pci/linux/pci.c > +++ b/drivers/bus/pci/linux/pci.c > @@ -32,7 +32,7 @@ > > extern struct rte_pci_bus rte_pci_bus; > > -static int > +int > pci_get_kernel_driver_by_path(const char *filename, char *dri_name) Here and in other places - shouldn't this too be prefixed with rte_? -- Thanks, Anatoly