DPDK patches and discussions
 help / color / Atom feed
From: "Yan, Xiaoping (NSB - CN/Hangzhou)" <xiaoping.yan@nokia-sbell.com>
To: Ye Xiaolong <xiaolong.ye@intel.com>, Jeff Guo <jia.guo@intel.com>
Cc: "beilei.xing@intel.com" <beilei.xing@intel.com>,
	"qi.z.zhang@intel.com" <qi.z.zhang@intel.com>,
	"jianbo.liu@linaro.org" <jianbo.liu@linaro.org>,
	"dev@dpdk.org" <dev@dpdk.org>,
	"olivier.matz@6wind.com" <olivier.matz@6wind.com>
Subject: Re: [dpdk-dev] net/i40e: fix error setting for L2TAG
Date: Thu, 21 May 2020 01:33:38 +0000
Message-ID: <e19841b292d440f4bee18fa0de7ea051@nokia-sbell.com> (raw)
In-Reply-To: <20200521002247.GC99392@intel.com>


In which dpdk release, this fix will be available?
Thank you.

Best regards
Yan Xiaoping

-----Original Message-----
From: Ye Xiaolong <xiaolong.ye@intel.com> 
Sent: 2020Äê5ÔÂ21ÈÕ 8:23
To: Jeff Guo <jia.guo@intel.com>
Cc: beilei.xing@intel.com; qi.z.zhang@intel.com; jianbo.liu@linaro.org; Yan, Xiaoping (NSB - CN/Hangzhou) <xiaoping.yan@nokia-sbell.com>; dev@dpdk.org; olivier.matz@6wind.com
Subject: Re: [dpdk-dev] net/i40e: fix error setting for L2TAG

On 05/20, Jeff Guo wrote:
>Base on HW, if a packet be split into multiple segments, the L2TAG 
>should only be valid on the last Rx descriptor. So fix it by setting 
>L2TAG into mbuf when processing the last split packet.
>Fixes: ca74903b75cf ("net/i40e: extract non-x86 specific code from 
>vector driver")
>Signed-off-by: Jeff Guo <jia.guo@intel.com>
> drivers/net/i40e/i40e_rxtx_vec_common.h | 1 +
> 1 file changed, 1 insertion(+)
>diff --git a/drivers/net/i40e/i40e_rxtx_vec_common.h 
>index 0e6ffa007..31f73f605 100644
>--- a/drivers/net/i40e/i40e_rxtx_vec_common.h
>+++ b/drivers/net/i40e/i40e_rxtx_vec_common.h
>@@ -33,6 +33,7 @@ reassemble_packets(struct i40e_rx_queue *rxq, struct rte_mbuf **rx_bufs,
> 			if (!split_flags[buf_idx]) {
> 				/* it's the last packet of the set */
> 				start->hash = end->hash;
>+				start->vlan_tci = end->vlan_tci;
> 				start->ol_flags = end->ol_flags;
> 				/* we need to strip crc for the whole packet */
> 				start->pkt_len -= rxq->crc_len;

Applied to dpdk-next-net-intel, Thanks.

      reply index

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-05-20 21:25 Jeff Guo
2020-05-20 10:01 ` Zhang, Qi Z
2020-05-21  0:22 ` Ye Xiaolong
2020-05-21  1:33   ` Yan, Xiaoping (NSB - CN/Hangzhou) [this message]

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e19841b292d440f4bee18fa0de7ea051@nokia-sbell.com \
    --to=xiaoping.yan@nokia-sbell.com \
    --cc=beilei.xing@intel.com \
    --cc=dev@dpdk.org \
    --cc=jia.guo@intel.com \
    --cc=jianbo.liu@linaro.org \
    --cc=olivier.matz@6wind.com \
    --cc=qi.z.zhang@intel.com \
    --cc=xiaolong.ye@intel.com \


* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

DPDK patches and discussions

Archives are clonable:
	git clone --mirror http://inbox.dpdk.org/dev/0 dev/git/0.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 dev dev/ http://inbox.dpdk.org/dev \
	public-inbox-index dev

Newsgroup available over NNTP:

AGPL code for this site: git clone https://public-inbox.org/ public-inbox