From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 1DDBB41C23;
	Mon,  6 Feb 2023 17:01:42 +0100 (CET)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 097AB42B7E;
	Mon,  6 Feb 2023 17:01:42 +0100 (CET)
Received: from dfw.source.kernel.org (dfw.source.kernel.org [139.178.84.217])
 by mails.dpdk.org (Postfix) with ESMTP id 21A1D427E9
 for <dev@dpdk.org>; Mon,  6 Feb 2023 17:01:40 +0100 (CET)
Received: from smtp.kernel.org (relay.kernel.org [52.25.139.140])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits))
 (No client certificate requested)
 by dfw.source.kernel.org (Postfix) with ESMTPS id 6123760EC5;
 Mon,  6 Feb 2023 16:01:39 +0000 (UTC)
Received: by smtp.kernel.org (Postfix) with ESMTPSA id 48E4BC433D2;
 Mon,  6 Feb 2023 16:01:38 +0000 (UTC)
DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/simple; d=kernel.org;
 s=k20201202; t=1675699298;
 bh=tY/MK3ADvWunvCahih8f6NTt3EPu4nQ+X+yk/CltOxI=;
 h=Subject:From:To:Cc:Date:In-Reply-To:References:From;
 b=qwb7DCohlLy3qr+94ASmUUoIF/RYfZ+dV0jURvgLAJOCS8fDIkGkJ+GuwdQNp/OH0
 1pwjF2jb+tDQ9l1gUw4RBTf4BxmrotU6PGGGKZTtX3gg2/zrZfLYATTVMlRDB1ZG8k
 UqG1aKUDb9tX2UX1pArHb91K3oWxxEJsjcY/QUpBOJpYT4oHbVwTECUJnBCRaQo8OE
 vg3w9LzOVyArI/2byjaXnoaOCHHGb1AmpQ8i2HuZ39n0KhT8pfcYmbHaU9ujUHAFC8
 7Dm9jT0hDR4laPNCWUgwhOW+sPdS5S/+8dHiVzFgtkTQ8YQfeFfC16qnrL630XSxGU
 WEm95/u9tWlhQ==
Message-ID: <e1a8e9a64dc676fdd5da3b0cf39a8e34e83dac70.camel@kernel.org>
Subject: Re: [PATCH v3 10/10] bus/vdev: check result of rte_vdev_device_name
From: Sinan Kaya <okaya@kernel.org>
To: Thomas Monjalon <thomas@monjalon.net>, Stephen Hemminger
 <stephen@networkplumber.org>
Cc: Ferruh Yigit <ferruh.yigit@amd.com>, Andrew Rybchenko
 <andrew.rybchenko@oktetlabs.ru>, dev@dpdk.org
Date: Mon, 06 Feb 2023 11:01:36 -0500
In-Reply-To: <4942344.1oUyQt6lIG@thomas>
References: <20230120044140.95975-1-okaya@kernel.org>
 <20230120044140.95975-11-okaya@kernel.org>
 <20230120084715.18e0fb24@hermes.local> <4942344.1oUyQt6lIG@thomas>
Content-Type: text/plain; charset="UTF-8"
User-Agent: Evolution 3.36.5-0ubuntu1 
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On Sun, 2023-01-22 at 21:51 +0100, Thomas Monjalon wrote:
> 20/01/2023 17:47, Stephen Hemminger:
> > On Thu, 19 Jan 2023 23:41:40 -0500
> > okaya@kernel.org wrote:
> > 
> > > diff --git a/lib/ethdev/ethdev_vdev.h b/lib/ethdev/ethdev_vdev.h
> > > index 364f140f91..6d94a65d97 100644
> > > --- a/lib/ethdev/ethdev_vdev.h
> > > +++ b/lib/ethdev/ethdev_vdev.h
> > > @@ -34,6 +34,8 @@ rte_eth_vdev_allocate(struct rte_vdev_device
> > > *dev, size_t private_data_size)
> > >  {
> > >  	struct rte_eth_dev *eth_dev;
> > >  	const char *name = rte_vdev_device_name(dev);
> > > +	if (name == NULL)
> > > +		return NULL;
> > 
> > Please add a blank line after declarations and before code.
> > For some reason the DPDK version of checkpatch suppresses this
> > warning.
> 
> The check of "name" is related to the line above,
> so I don't think we should insert a blank line.
> 
> 

While I'm waiting for maintainer feedback, let me know which
way I should go. I can update this for next rev.