From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id B845A1B34B for ; Tue, 30 Jan 2018 07:06:14 +0100 (CET) X-Virus-Scanned: Proofpoint Essentials engine Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16]) (using TLSv1 with cipher ECDHE-RSA-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1-us4.ppe-hosted.com (Proofpoint Essentials ESMTP Server) with ESMTPS id 68A28B40084; Tue, 30 Jan 2018 06:06:12 +0000 (UTC) Received: from [192.168.38.17] (84.52.114.114) by ukex01.SolarFlarecom.com (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1044.25; Tue, 30 Jan 2018 06:06:05 +0000 To: Olivier Matz , , Neil Horman , John McNamara , "Marko Kovacevic" CC: Ferruh Yigit , Thomas Monjalon References: <20180129171339.20896-1-olivier.matz@6wind.com> From: Andrew Rybchenko Message-ID: Date: Tue, 30 Jan 2018 09:06:01 +0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.2 MIME-Version: 1.0 In-Reply-To: <20180129171339.20896-1-olivier.matz@6wind.com> Content-Language: en-GB X-Originating-IP: [84.52.114.114] X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To ukex01.SolarFlarecom.com (10.17.10.4) X-TM-AS-Product-Ver: SMEX-11.0.0.1191-8.100.1062-23628.003 X-TM-AS-Result: No--11.427400-0.000000-31 X-TM-AS-User-Approved-Sender: Yes X-TM-AS-User-Blocked-Sender: No X-MDID: 1517292374-B6ZR3sYcKvAI Content-Type: text/plain; charset="utf-8"; format=flowed Content-Transfer-Encoding: 7bit X-Content-Filtered-By: Mailman/MimeDel 2.1.15 Subject: Re: [dpdk-dev] [PATCH] doc: announce PMD API change for set default MAC X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Tue, 30 Jan 2018 06:06:15 -0000 On 01/29/2018 08:13 PM, Olivier Matz wrote: > Announce internal PMD API change in the function to set the default MAC > address. The objective is to be able to notify errors occurring in the > PMD. > > Link: https://dpdk.org/dev/patchwork/patch/32284/ > > Signed-off-by: Olivier Matz > --- > doc/guides/rel_notes/deprecation.rst | 8 ++++++++ > 1 file changed, 8 insertions(+) > > diff --git a/doc/guides/rel_notes/deprecation.rst b/doc/guides/rel_notes/deprecation.rst > index 43a39d827..8ad4407c2 100644 > --- a/doc/guides/rel_notes/deprecation.rst > +++ b/doc/guides/rel_notes/deprecation.rst > @@ -76,3 +76,11 @@ Deprecation Notices > * mbuf: The mbuf flags ``PKT_TX_VLAN_PKT`` and ``PKT_TX_QINQ_PKT`` are > respectively renamed as ``PKT_TX_VLAN`` and ``PKT_TX_QINQ``. The old > names will be removed in v18.08. > + > +* ethdev: The prototype and the behavior of > + ``dev_ops->eth_mac_addr_set()`` will change in v18.05. A return code > + will be added to notify the caller if an error occurred in the PMD. In > + ``rte_eth_dev_default_mac_addr_set()``, the new default MAC address > + will be copied in ``dev->data->mac_addrs[0]`` only if the operation is > + succesfull. This modification will only impact the PMDs, not the > + applications. Acked-by: Andrew Rybchenko