From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0ADDBA034F; Wed, 6 May 2020 15:43:28 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 687CB1D9E9; Wed, 6 May 2020 15:43:25 +0200 (CEST) Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by dpdk.org (Postfix) with ESMTP id B07281D69F; Wed, 6 May 2020 15:43:22 +0200 (CEST) IronPort-SDR: plK+vRE6TCVLtth6LWRi+ibT/w+bkmof7MYb0ox9wBPT5XBPKoWoLQRHkXPa+JT+S+/a7i5rR5 5OqIE3vfiNQw== X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga106.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 06 May 2020 06:43:22 -0700 IronPort-SDR: 5ZGTG5Hq9MTju6TtIOXvoS4uZOHGLNEpJTIPYO4TSgOeTly6x6Rk9uH+PIC8TNpk9Ia0hnFj6R DzuQZ7yBib3w== X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.73,359,1583222400"; d="scan'208";a="461441865" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.213.197.179]) ([10.213.197.179]) by fmsmga005.fm.intel.com with ESMTP; 06 May 2020 06:43:20 -0700 To: =?UTF-8?Q?Ga=c3=abtan_Rivet?= Cc: dev@dpdk.org, stable@dpdk.org, thomas@monjalon.net References: <8aab6e5eb6d8d4769cd4e47a32403c836a13b5ef.1588705694.git.grive@u256.net> <20200506123344.6ui6wfhwevawbyoh@u256.net> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJsBBMBCgBWAhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEABQkKqZZ8FiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl6ha3sXGHZrczovL2tl eXMub3BlbnBncC5vcmcACgkQ+TPrQ98TYR8uLA//QwltuFliUWe60xwmu9sY38c1DXvX67wk UryQ1WijVdIoj4H8cf/s2KtyIBjc89R254KMEfJDao/LrXqJ69KyGKXFhFPlF3VmFLsN4XiT PSfxkx8s6kHVaB3O183p4xAqnnl/ql8nJ5ph9HuwdL8CyO5/7dC/MjZ/mc4NGq5O9zk3YRGO lvdZAp5HW9VKW4iynvy7rl3tKyEqaAE62MbGyfJDH3C/nV/4+mPc8Av5rRH2hV+DBQourwuC ci6noiDP6GCNQqTh1FHYvXaN4GPMHD9DX6LtT8Fc5mL/V9i9kEVikPohlI0WJqhE+vQHFzR2 1q5nznE+pweYsBi3LXIMYpmha9oJh03dJOdKAEhkfBr6n8BWkWQMMiwfdzg20JX0o7a/iF8H 4dshBs+dXdIKzPfJhMjHxLDFNPNH8zRQkB02JceY9ESEah3wAbzTwz+e/9qQ5OyDTQjKkVOo cxC2U7CqeNt0JZi0tmuzIWrfxjAUulVhBmnceqyMOzGpSCQIkvalb6+eXsC9V1DZ4zsHZ2Mx Hi+7pCksdraXUhKdg5bOVCt8XFmx1MX4AoV3GWy6mZ4eMMvJN2hjXcrreQgG25BdCdcxKgqp e9cMbCtF+RZax8U6LkAWueJJ1QXrav1Jk5SnG8/5xANQoBQKGz+yFiWcgEs9Tpxth15o2v59 gXK5Ag0EV9ZMvgEQAKc0Db17xNqtSwEvmfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ES YpV8QWj0xK4YM0dLxnDU2IYxjEshSB1TqAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4Ai bPtrHuIXWQOBECcVZTTOdZYGAzaYzxiAONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxD UQljeNvKYt1lZE/gAUUxNLWsYyTT+22/vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/ 3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35piVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVj sM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQI3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdc q9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYHfVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH7 1PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZqw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFB VOQOxCvwRG2QCgcJ/UTn5vlivul+cThi6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI 8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJlRr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYC GwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNhHwUCXqFrngUJCKxSYAAKCRD5M+tD3xNhH3YWD/9b cUiWaHJasX+OpiuZ1Li5GG3m9aw4lR/k2lET0UPRer2Jy1JsL+uqzdkxGvPqzFTBXgx/6Byz EMa2mt6R9BCyR286s3lxVS5Bgr5JGB3EkpPcoJT3A7QOYMV95jBiiJTy78Qdzi5LrIu4tW6H o0MWUjpjdbR01cnj6EagKrDx9kAsqQTfvz4ff5JIFyKSKEHQMaz1YGHyCWhsTwqONhs0G7V2 0taQS1bGiaWND0dIBJ/u0pU998XZhmMzn765H+/MqXsyDXwoHv1rcaX/kcZIcN3sLUVcbdxA WHXOktGTQemQfEpCNuf2jeeJlp8sHmAQmV3dLS1R49h0q7hH4qOPEIvXjQebJGs5W7s2vxbA 5u5nLujmMkkfg1XHsds0u7Zdp2n200VC4GQf8vsUp6CSMgjedHeF9zKv1W4lYXpHp576ZV7T GgsEsvveAE1xvHnpV9d7ZehPuZfYlP4qgo2iutA1c0AXZLn5LPcDBgZ+KQZTzm05RU1gkx7n gL9CdTzVrYFy7Y5R+TrE9HFUnsaXaGsJwOB/emByGPQEKrupz8CZFi9pkqPuAPwjN6Wonokv ChAewHXPUadcJmCTj78Oeg9uXR6yjpxyFjx3vdijQIYgi5TEGpeTQBymLANOYxYWYOjXk+ae dYuOYKR9nbPv+2zK9pwwQ2NXbUBystaGyQ== Message-ID: Date: Wed, 6 May 2020 14:43:19 +0100 MIME-Version: 1.0 In-Reply-To: <20200506123344.6ui6wfhwevawbyoh@u256.net> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH v1 2/3] net/ring: fix eth_dev device pointer on allocation X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 5/6/2020 1:33 PM, Gaëtan Rivet wrote: > On 06/05/20 12:48 +0100, Ferruh Yigit wrote: >> On 5/5/2020 8:10 PM, Gaetan Rivet wrote: >>> When a net_ring device is allocated, its device pointer is not set >>> before calling rte_eth_dev_probing_finish, which is incorrect. >>> >>> The following: >>> commit: 96cb19521147 ("net/ring: use EAL APIs in PMD specific API") >>> commit: a6992e961050 ("net/ring: set ethernet device field") >>> >>> already attempted to fix this issue in 17.08, which was fine at the >>> time. Adding the hook rte_eth_dev_probing_finish() however created this >>> bug, as the eth_dev exposed when this hook is executed is expected to be >>> complete. >>> >>> Remove the prior attempts to fix the issue in rte_pmd_ring_probe() and >>> write the pointer properly in do_eth_dev_ring_create(). >>> >>> Cc: stable@dpdk.org >>> Fixes: fbe90cdd776c ("ethdev: add probing finish function") >>> Cc: ferruh.yigit@intel.com >>> Cc: thomas@monjalon.net >>> Signed-off-by: Gaetan Rivet >> >> <...> >> >>> @@ -325,10 +346,17 @@ do_eth_dev_ring_create(const char *name, >>> data->kdrv = RTE_KDRV_NONE; >>> data->numa_node = numa_node; >>> >>> - /* finally assign rx and tx ops */ >>> + /* assign rx and tx ops */ >>> eth_dev->rx_pkt_burst = eth_ring_rx; >>> eth_dev->tx_pkt_burst = eth_ring_tx; >>> >>> + /* finally set the rte_device pointer in eth_dev. */ >>> + eth_dev->device = ring_device_from_name(name); >>> + if (eth_dev->device == NULL) { >>> + rte_errno = ENODEV; >>> + goto error; >>> + } >>> + >>> rte_eth_dev_probing_finish(eth_dev); >>> *eth_dev_p = eth_dev; >> >> Why not move the 'rte_eth_dev_probing_finish()' to the 'rte_pmd_ring_probe()', >> below where 'eth_dev->device' set? > > Hi Ferruh, > > Sure it would work. The reason I did it this way is two-fold: > > * I disliked having two places where eth_dev->device was conditionally > set. It makes it harder to read rte_pmd_ring_probe. Agree, what about using a 'goto' to have the assignment and 'rte_eth_dev_probing_finish()' in a single place? But check seems needed since creation may failed at that stage, if you think better check can be done on 'ret' instead of 'eth_dev'... > > * I was actually thinking, doing this patch, that we should modify > rte_eth_dev_allocate() to take an rte_device as parameter, as all > eth_dev are meant to be backed by an rte_device. Keeping this in > mind, I meant to move writing the pointer closer to the > rte_eth_dev_allocate() call. That is a bigger change, may affect many (if not all) PMDs, so I think this can be considered when that change is available. And although that change may fix the issues that 'eth_dev->device' is not set, which we had a few times before, not sure it worth to change all PMDs and ethdev API directly couple with rte_device, instead of PMD being the glue. Can be discussed more on its own patch. > > But you are right that it is needlessly verbose, using > vdev_bus->find_device() to do this stuff. I'm ok with changing it as you > described if you prefer. > That was the concern, that is too much code to take a value which is already available a few level up the stack.