From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by dpdk.org (Postfix) with ESMTP id F329F1F28 for ; Mon, 6 May 2019 20:26:32 +0200 (CEST) Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x46IIibq001357 for ; Mon, 6 May 2019 14:26:31 -0400 Received: from e17.ny.us.ibm.com (e17.ny.us.ibm.com [129.33.205.207]) by mx0a-001b2d01.pphosted.com with ESMTP id 2sar8kcy7j-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 06 May 2019 14:26:31 -0400 Received: from localhost by e17.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 6 May 2019 19:26:30 +0100 Received: from b01cxnp23032.gho.pok.ibm.com (9.57.198.27) by e17.ny.us.ibm.com (146.89.104.204) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Mon, 6 May 2019 19:26:29 +0100 Received: from b01ledav004.gho.pok.ibm.com (b01ledav004.gho.pok.ibm.com [9.57.199.109]) by b01cxnp23032.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x46IQSsf37093388 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 6 May 2019 18:26:28 GMT Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9C362112064; Mon, 6 May 2019 18:26:28 +0000 (GMT) Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 35047112061; Mon, 6 May 2019 18:26:28 +0000 (GMT) Received: from davids-mbp.randomparity.local (unknown [9.163.84.240]) by b01ledav004.gho.pok.ibm.com (Postfix) with ESMTP; Mon, 6 May 2019 18:26:28 +0000 (GMT) From: David Christensen To: Thomas Monjalon Cc: dev@dpdk.org References: <1556663603-39934-1-git-send-email-drc@linux.vnet.ibm.com> <6327337.9PMvuZf6XJ@xps> Date: Mon, 6 May 2019 11:26:26 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <6327337.9PMvuZf6XJ@xps> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 19050618-0040-0000-0000-000004EC00A4 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00011061; HX=3.00000242; KW=3.00000007; PH=3.00000004; SC=3.00000285; SDB=6.01199512; UDB=6.00629303; IPR=6.00980388; MB=3.00026760; MTD=3.00000008; XFM=3.00000015; UTC=2019-05-06 18:26:30 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19050618-0041-0000-0000-000008F808B6 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-05-06_10:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=806 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1905060153 Subject: Re: [dpdk-dev] [PATCH 4/4] test: fix memory barrier test failure on power CPUs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Mon, 06 May 2019 18:26:33 -0000 >> -#define ITER_MAX 0x100000000 >> +#define ITER_MAX 0x1000000 > > This is a revert of a change done in patch 3. I'll fix and resubmit. >> @@ -92,12 +92,19 @@ struct lcore_plock_test { >> other = self ^ 1; >> >> l->flag[self] = 1; >> +#ifdef RTE_ARCH_PPC_64 >> + rte_smp_wmb(); >> +#endif > > You should not have such #ifdef in a test case > supposed to run on all architectures with the same code. > What can be fixed in EAL? I'll go ahead and remove the ifdefs since the code for rte_smp_wmb() resolves to different architecture specific code (compiler memory barriers in the x86 case). Dave From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id DBAFBA0096 for ; Mon, 6 May 2019 20:26:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id C43A42B94; Mon, 6 May 2019 20:26:34 +0200 (CEST) Received: from mx0a-001b2d01.pphosted.com (mx0a-001b2d01.pphosted.com [148.163.156.1]) by dpdk.org (Postfix) with ESMTP id F329F1F28 for ; Mon, 6 May 2019 20:26:32 +0200 (CEST) Received: from pps.filterd (m0098409.ppops.net [127.0.0.1]) by mx0a-001b2d01.pphosted.com (8.16.0.27/8.16.0.27) with SMTP id x46IIibq001357 for ; Mon, 6 May 2019 14:26:31 -0400 Received: from e17.ny.us.ibm.com (e17.ny.us.ibm.com [129.33.205.207]) by mx0a-001b2d01.pphosted.com with ESMTP id 2sar8kcy7j-1 (version=TLSv1.2 cipher=AES256-GCM-SHA384 bits=256 verify=NOT) for ; Mon, 06 May 2019 14:26:31 -0400 Received: from localhost by e17.ny.us.ibm.com with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted for from ; Mon, 6 May 2019 19:26:30 +0100 Received: from b01cxnp23032.gho.pok.ibm.com (9.57.198.27) by e17.ny.us.ibm.com (146.89.104.204) with IBM ESMTP SMTP Gateway: Authorized Use Only! Violators will be prosecuted; (version=TLSv1/SSLv3 cipher=AES256-GCM-SHA384 bits=256/256) Mon, 6 May 2019 19:26:29 +0100 Received: from b01ledav004.gho.pok.ibm.com (b01ledav004.gho.pok.ibm.com [9.57.199.109]) by b01cxnp23032.gho.pok.ibm.com (8.14.9/8.14.9/NCO v10.0) with ESMTP id x46IQSsf37093388 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-GCM-SHA384 bits=256 verify=OK); Mon, 6 May 2019 18:26:28 GMT Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 9C362112064; Mon, 6 May 2019 18:26:28 +0000 (GMT) Received: from b01ledav004.gho.pok.ibm.com (unknown [127.0.0.1]) by IMSVA (Postfix) with ESMTP id 35047112061; Mon, 6 May 2019 18:26:28 +0000 (GMT) Received: from davids-mbp.randomparity.local (unknown [9.163.84.240]) by b01ledav004.gho.pok.ibm.com (Postfix) with ESMTP; Mon, 6 May 2019 18:26:28 +0000 (GMT) From: David Christensen To: Thomas Monjalon Cc: dev@dpdk.org References: <1556663603-39934-1-git-send-email-drc@linux.vnet.ibm.com> <6327337.9PMvuZf6XJ@xps> Date: Mon, 6 May 2019 11:26:26 -0700 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.14; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <6327337.9PMvuZf6XJ@xps> Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 7bit X-TM-AS-GCONF: 00 x-cbid: 19050618-0040-0000-0000-000004EC00A4 X-IBM-SpamModules-Scores: X-IBM-SpamModules-Versions: BY=3.00011061; HX=3.00000242; KW=3.00000007; PH=3.00000004; SC=3.00000285; SDB=6.01199512; UDB=6.00629303; IPR=6.00980388; MB=3.00026760; MTD=3.00000008; XFM=3.00000015; UTC=2019-05-06 18:26:30 X-IBM-AV-DETECTION: SAVI=unused REMOTE=unused XFE=unused x-cbparentid: 19050618-0041-0000-0000-000008F808B6 Message-Id: X-Proofpoint-Virus-Version: vendor=fsecure engine=2.50.10434:, , definitions=2019-05-06_10:, , signatures=0 X-Proofpoint-Spam-Details: rule=outbound_notspam policy=outbound score=0 priorityscore=1501 malwarescore=0 suspectscore=0 phishscore=0 bulkscore=0 spamscore=0 clxscore=1015 lowpriorityscore=0 mlxscore=0 impostorscore=0 mlxlogscore=806 adultscore=0 classifier=spam adjust=0 reason=mlx scancount=1 engine=8.0.1-1810050000 definitions=main-1905060153 Subject: Re: [dpdk-dev] [PATCH 4/4] test: fix memory barrier test failure on power CPUs X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" Message-ID: <20190506182626.GLZQfP8x12F11r7oy74WIPViFSQPe_3yl2-mTj9GzNw@z> >> -#define ITER_MAX 0x100000000 >> +#define ITER_MAX 0x1000000 > > This is a revert of a change done in patch 3. I'll fix and resubmit. >> @@ -92,12 +92,19 @@ struct lcore_plock_test { >> other = self ^ 1; >> >> l->flag[self] = 1; >> +#ifdef RTE_ARCH_PPC_64 >> + rte_smp_wmb(); >> +#endif > > You should not have such #ifdef in a test case > supposed to run on all architectures with the same code. > What can be fixed in EAL? I'll go ahead and remove the ifdefs since the code for rte_smp_wmb() resolves to different architecture specific code (compiler memory barriers in the x86 case). Dave