From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga07.intel.com (mga07.intel.com [134.134.136.100]) by dpdk.org (Postfix) with ESMTP id 2EF0E1B793 for ; Sat, 14 Apr 2018 12:04:06 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga003.jf.intel.com ([10.7.209.27]) by orsmga105.jf.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 14 Apr 2018 03:03:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.48,448,1517904000"; d="scan'208";a="43279014" Received: from aburakov-mobl.ger.corp.intel.com (HELO [10.252.4.7]) ([10.252.4.7]) by orsmga003.jf.intel.com with ESMTP; 14 Apr 2018 03:03:52 -0700 To: Adrien Mazarguil Cc: dev@dpdk.org References: <20180413155417.29643-1-adrien.mazarguil@6wind.com> <20180413183950.17625-1-adrien.mazarguil@6wind.com> <20180413183950.17625-2-adrien.mazarguil@6wind.com> From: "Burakov, Anatoly" Message-ID: Date: Sat, 14 Apr 2018 11:03:50 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101 Thunderbird/52.7.0 MIME-Version: 1.0 In-Reply-To: <20180413183950.17625-2-adrien.mazarguil@6wind.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH v3 2/2] eal: fix signed integers in fbarray X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Sat, 14 Apr 2018 10:04:07 -0000 On 13-Apr-18 7:43 PM, Adrien Mazarguil wrote: > While debugging startup issues encountered with Clang (see "eal: fix > undefined behavior in fbarray"), I noticed that fbarray stores indices, > sizes and masks on signed integers involved in bitwise operations. > > Such operations almost invariably cause undefined behavior with values that > cannot be represented by the result type, as is often the case with > bit-masks and left-shifts. > > This patch replaces them with unsigned integers as a safety measure and > promotes a few internal variables to larger types for consistency. > > Fixes: c44d09811b40 ("eal: add shared indexed file-backed array") > Cc: Anatoly Burakov > > Signed-off-by: Adrien Mazarguil > > -- > > v3 changes: > > - Added INT_MAX upper bound check in fully_validate() as suggested by > Anatoly. > - Added a sysconf() result check to appease Coverity since calc_data_size() > now takes an unsigned page size (Coverity issues 272598 and 272599). > > v2 changes: > > Removed unnecessary "(unsigned int)" cast leftovers. Acked-by: Anatoly Burakov -- Thanks, Anatoly