From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id C728B426AE; Tue, 3 Oct 2023 18:50:26 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id B1E57402A2; Tue, 3 Oct 2023 18:50:26 +0200 (CEST) Received: from NAM11-CO1-obe.outbound.protection.outlook.com (mail-co1nam11on2042.outbound.protection.outlook.com [40.107.220.42]) by mails.dpdk.org (Postfix) with ESMTP id 6117440262 for ; Tue, 3 Oct 2023 18:50:25 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=SS/D0cx00RT4laxrvbaL1PHaXpwv7Nn0NC2OV5+77UvzRGpc9X0mR2t2FbMnXoVoum3uWpurGEDc0SactRgd6+ZMXTQH95i64EvLVdP8n774eZTyjElrfCkT7/yHYfMQtccz4JwIC2RW9OtmcnWQ2RAG564or+ix7vGuFtqBTKzhhdscxjTbwqVfEwbiauZ+TAJwHzxBEgfVBnJmrTjht766jDIvU5M/+nibjhT7q/gFoLbSj4UGXL2TTtwcqPbeVhsQQ/VXdGW7IZ7zhc63n4cjEKGnx1/JG2PwYnbw1HmOhr3FOG6HLkA7qudJy++XrFw/HPB8GTWtSkemODnhSw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=rj2dyLLBVHnTNous4zTVurFprW4pxa88ACutqDWA4MA=; b=AlJ6Oa837TsfJMCRzCdWktwsJwNJcj8Wl05VRjUFuGT6VSDKAO1MomMXHzNaP/Ph/URoGGge+nosV0mEqpjM2F3tfLtq7yyogyEotTy9/zBba32mZmpcRw4yjYFqzWHLSTxNpk/jmhpUkfhFz2dn6Id9Yv16vNcNCYPnWNr9v//yqOtNOis9H2LSGPVXmM6ATNjCocuJ+Xvo49jbHaa2hmZBGhfGv6miwPUPqhrRQ+EPtXm9En50cGdX1Oyg3bqisTcp3UJ35bHKD2K/Ti0+hNkxi6nieFf38xMIVVnOHQrqyY9wnd+6XXe5V+uNLG/G7NxBxIQaxil6iyOnsMaVdA== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=rj2dyLLBVHnTNous4zTVurFprW4pxa88ACutqDWA4MA=; b=T6dH6jA3sc/bbZszc7xiL/OyNmlGAws4j5PvfFISvruiroITiO0+R/F3IHcMxvs5gwOhpJjkXLuknmQRi8DkzrsgGYDGMGmaLk2tJt4kkIGp8QJeL3mO0Q7LnPCMs2/K99F6kgsPryFQwy5VRjmia4Vuu6QG6bstcBm4aZ94FHM= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by SJ0PR12MB6806.namprd12.prod.outlook.com (2603:10b6:a03:478::7) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.6838.31; Tue, 3 Oct 2023 16:50:19 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::102f:c69b:d3e5:7fe8%4]) with mapi id 15.20.6838.024; Tue, 3 Oct 2023 16:50:19 +0000 Message-ID: Date: Tue, 3 Oct 2023 17:50:13 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v2 1/3] test: remove some strings from cmdline_etheraddr tests Content-Language: en-US To: Stephen Hemminger Cc: dev@dpdk.org References: <20230929163611.62691-1-stephen@networkplumber.org> <20231002183730.301163-1-stephen@networkplumber.org> <20231002183730.301163-2-stephen@networkplumber.org> <20231003093625.0e833f9f@hermes.local> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJjb9DJBQkC+3/YAAoJEFRTPtCK Km/6d94P/irGq3mPa7LamXMIioQ8i6ppMSjpr8g+SxH9RnzbmoUjUY6hVzCpXYxEejiJHubg 7lwD+bOocYpiU8Pe0UncVBhIPNk/dIWQAyH0IWK1nd+hOnjxHv3AQpP80Be2o1mUn3oq/b+B QYiyvvre2gIugYq0hzLcG7z4zREeT+Nl0DMDfnLx+Tj2FAOHrOfudUqjdr/VjF5PoTK0bxnb Brqulp0I0ft7hNsufhzf+TlqaB5l0eQO4gDo5xGTP97TT1cGYsXVMsyDhHqW6P3cuj8kkLkO Ch4oq8OLL8GElgRy5y5svU6CJu3f8hT9aiqIoaRpfNv6N8iEk6g4/HNN+uydb9YCA+1pbwBx skmDhtxQrmXpI+Fmfq0aX2NmqHcy6JR8Ekm/nfwLAW/aDpwoMImVN5pPXtOBSjYi4pj7hiJk UA0ZFi8HCW+fic85p8MXn1GPDmbO82Mm3JVJ1uJNAzGsBbW5SP1ol6+XTeaSxcmzFlrDs8vL XQJMRTpcG6Pti7GbbsOtldvmxRQpq9PmCgQg9IrPXpMoaKE3WwtiSiCALs0kYj4F+hhgAfjI RsOuaAJTnKYW31pC/QdroMNAEqIpLveql03jj+xD9ntJIVAsXiCitsLIXzKP0L5tcHkoVLC3 NAjVYq6XkAEssPF4mMRLoEwpvxOytHe1BCJoRl0YA0aQzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmNv0PAFCQL7f/8ACgkQVFM+0Ioqb/oU9hAAisAJJ09j/kiEeA1HGKUg3DyFnYW22zRL z1IHYmcHQanMx4+FAwsb1bonVldQMIYNJ9z69UNIU16zIqLZt3D5QK7Je5F5q4NZgfP2jtjX rc3jyu0PuDerFZQyxNcYhhmlF9JO9NV976WYbBAM3AAr0TDohUk+YicYTKab+ZHYOABXbqHX qi+bzDCH1vKBDfpJviprthhK1tIABUK5lsp9aFwFU2jfu2J3XX3pwQhPMjtn2C4v37XUnOqM SJPr2HLU27IW5I3BBpJn7dZE/BkmDmnceHF8E4tRlXCQ/cf81+eErL832sfhVJo1MpubKh3B j89ZLmw0cDXZP2hqlC9vdXnoWWHI8PDPkiw9z11yLrT9Wd4cTJTjFV49Z9G96rgnOtWDcZ1J xHBAnXYQ7V2k9abY+ZqY1PtAPr/smqzQfPHXyTAhRVZp2f3yQmj7UqB07FJuLQjJ4CGk97Qx ///qeSg7D8x/sGEA8Yp2jgIj6u7tspuz+RgBYrWpfI0VIHhWED0jNXzqztrVX18CzA6r0ReY SG+CSyycKkco6UI9ZeUrXFwnoUJqIJY9wTJo5gD9EgGIbItv3qWTq29dihLYpzd6dqB708k7 4RBz9051oLaFVGkguFw/tXmA17nx+c2uR5jx8wb4j68umG2X++0dSta5eHAVhmtXvrqPW6Ku 3FQ= In-Reply-To: <20231003093625.0e833f9f@hermes.local> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: LO3P265CA0007.GBRP265.PROD.OUTLOOK.COM (2603:10a6:600:bb::12) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|SJ0PR12MB6806:EE_ X-MS-Office365-Filtering-Correlation-Id: 9323b2d2-3516-4b4a-e44c-08dbc430d3d2 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: /LvDgkazxMobzhT+hhEg5/KsTBaQzenc+coORFTtu6COga38VHTO7yQ23KGnzqBzSSrUV1NhTElxqRV2+5ZH0w46s5qQHalvmjZBuXN4qbGaJXtZEBdO6UzyUPffSfzHSjCjVA04z/hJRG9QneDIbRSAsOI2DkvER+gkUsSk75As1JJhL48V/kAfYezN/+jrVH17izZfly+d8fbbTMdzSdIjz6mVkigbFYO68U/grbyvIl87cZ8vmhp9diux+YtrvCT6Dhxaxwnhxy1R8liWkpv9t+0G2Lv1Yvf1EO4MEkV+gAK/JPMfdX/Vyx0OkIx6TVnZ+GznmDhDuKCRQ+UUoF7eZAkqI+zGOP7LlaOKtrm2SCE0PIZ/tiHA4FRBKqN1UiNeusaIZ3z2yZwZaYYjgHmgmuB83v2fVm0jzZ6qtGZfPeDLTJKlpJmaEGY6ymjnFtsJAVFGgAtkinnMsdQLXE4a7H8hSq/e/49HkHLVckO+x2WU0bnsVPJbTGST7W3oxrdSCK9Ypv3xWJVVbjUc2P6a+/+pPpYjqDnjg4aqtTXdwSmym0e/O1OFLTF/limur2hFqqX+u5OLwRjXiBrDlp1qORirWqj8KSzGgFP+5mQdGBuDAsDdsojNyJEGgbSzzTJMcFyjEaz47UcpQoxLFQ== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230031)(376002)(39860400002)(346002)(396003)(366004)(136003)(230922051799003)(186009)(64100799003)(1800799009)(451199024)(478600001)(6486002)(36756003)(2616005)(6512007)(31696002)(86362001)(26005)(6506007)(53546011)(38100700002)(2906002)(6666004)(8936002)(8676002)(5660300002)(4326008)(41300700001)(66946007)(66476007)(66556008)(6916009)(31686004)(316002)(44832011)(43740500002)(45980500001); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?TXBKZy9CUHNPRmc3TE9veVdhRlVkS05YR0Nib21KaXpVelpYQmJCMFUrbkNw?= =?utf-8?B?WjhtckFLRjhtSk1lbCtRRk9kN1hwdTNRTXlEQXZ5cmR0aDlTUHhQSTV4N3d3?= =?utf-8?B?dEh3QVVDQVFUWDNZMkJUQmx5aE5sRmZJM3B3RjRHTjIwWE5idjkrVXZxU1VX?= =?utf-8?B?enVJdjNMZnptOHE3RzJtSzhlVmRFaHhqbHFxQmg5MDUwUTdJRURCMkNOSG5O?= =?utf-8?B?UENXc2s2akxMYWhSZjlpSjVLQUtYcjFBUTZXZWo3TkY1VDF1T3BKL2RldnU0?= =?utf-8?B?NUZTYlVvYnZjR0hxQlZsc09hZDc0YVBpeWxmQ2s4bkRmRGpYVmxaRi9mYUJy?= =?utf-8?B?emIyOEFZQ1ZVVlRuYnJzUXRJN0dPVVhqY0M1WUpFZDY3dGMwdkFPdnFjMStE?= =?utf-8?B?Q3h5WldLblJ5MW50ZmJyOCtnNkpSK2hCMXh1bDdsanllL1VNa2M1cGJEcWR4?= =?utf-8?B?VGozMG15WHJCYS9IS0NhdVpkUzBUTVBySnVSTlBsdENJR0krSUtjMXRIeDU4?= =?utf-8?B?enNqN0RLUjJxcmZXUkVzSnlVWlNvb21wVzdHWWsySEp4VGNjSklNQUs4QUFv?= =?utf-8?B?RCtYaUJYRFpmVk5aR015LzlFQzE2MEJSc1lSY2p2TFVIM0E1a00xRVFGZHRB?= =?utf-8?B?TWk3aFJzdzM2S0hhcTdwWW82OWxQTUNSZUxIYVFCTWVyZzhFSVZhbHMyUXZy?= =?utf-8?B?ZmNOMDZOcnVjVWs0b0ZBd2ZKbkZHcXFDYWMvaWZEdnpmOXQ3c0ZyeFhvQjI1?= =?utf-8?B?azV0Q1VKYy9ORkFuL29icWVKa1cwSjI0TFAwNkhXUWljdXJITzNzeFUvVXZn?= =?utf-8?B?YjdrRVF3dXI0UDNobTBvYXFuMTNGTWdzZG8xb3dNNkswQlpRV01ST3V6R0hY?= =?utf-8?B?YXgwOXpKOTlEUGtjVk0xU0h3elZXT2dQQ0s0WVdBVkJzTnQvNGMxdS9aSFpC?= =?utf-8?B?WDVnc2dFL29Tc3g4TVN0ckJrWDFsa0J6azBhc01YU1ZnYmxBNnZCNjhrRkYy?= =?utf-8?B?enVBSlpNaC9rN245UFozN2FPSitaZ1k1TjhQSUIxUlE4OEd4bFJjYlVhdjdH?= =?utf-8?B?NEsrN2hxeDh4dFpBREc5cFh0eU9uWTBOREdURTMrZzJ6ODgxMWdaUkRaZ0M5?= =?utf-8?B?NldOVVp5ZGdrdUtjMy9udlJtUS9hNmxDK1VNenAxUXcyNVk2RXlhdTYvSEZO?= =?utf-8?B?TzNJS0RBVFhpV25IQkt0dTNmZ1lUTDlPSW5VTjRRck5STklnOGU2RERtUU9W?= =?utf-8?B?aW9XUExXSXloT1RZRmRvZEpONGEwR2d3S2owWkJoNFMzSmlzUDlzVnFHeHJo?= =?utf-8?B?NjFlVlVXanczUjcvOGdRN2U5TGQvUmVEWldiNnBXa3RUN2pjQzZPRk5rbW5B?= =?utf-8?B?aUpIRVRGVHJBS0xwenVvSVlSaDdlTlJITnhZZWN6M25TMml0WlJNelJ0Q2Rn?= =?utf-8?B?M2hxejJobWx1dkswNVRRakcvVjJNWEkwMDQ3bko0S2xWZzBtK1dxQkJYMkNq?= =?utf-8?B?SHVxemdzWUplVXBlUFRKcTJPSWg3Mk1WZDVPVGRjWWxkOHdraVhhaHBJK0cw?= =?utf-8?B?ZDVDcExGaFBDeWpkd3BKUHJ2dkgxNnVLbGVCU3RGZ29IMzJCSjh2V2JkcnhM?= =?utf-8?B?aDdXK2p1STljY1lWU05VSFpHcm9ZcmYzdWtYYzVua1ZUVHJraWdWakZ5WFM5?= =?utf-8?B?U2Vic09YNGRaa2JRcENTZ3dhSDRJQ3ovc1hqSWw4bVR0R2lCeG5ZUGlBZGUz?= =?utf-8?B?aDM2emh0L3BPQkdrV2RIY1RSYURvY1J4ejhEMW5NVTRhaytmRDBJSkJVanRT?= =?utf-8?B?M2V3YU9Mb3JUSEpEQ21jYklYaHBINmFDNnRpb29NNmNNSVhMRExvSy9wMTdm?= =?utf-8?B?dGdzRUNiTXlYTjF6Mk1VT0h5MU5HdC9sSlh3UnZ0TXVsQ0VBaWo3SFprbDAv?= =?utf-8?B?cXJTL3ZYYnJMa3h4eExqa21ZTTlwN2hGa0tRU2NDQkNOeUk3UDJyVHhzMzdM?= =?utf-8?B?TXlUZGFJaUFCc3NycERQcy9IbzM4SzE0RGZRcHZuRzNxSlh2aEVTU0E5Z3dr?= =?utf-8?B?ckhhY3k4RDM3aUVYdG1PLzlxMTNxRHZWZzNMVVBURjVlZDNBSUloTXk4V3hh?= =?utf-8?Q?h03pCap/fiJ9jC+eYzdDAnthB?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 9323b2d2-3516-4b4a-e44c-08dbc430d3d2 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 03 Oct 2023 16:50:19.6440 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: UuZSDHpNyNcpA5ulRpqh3nAQJD1Iq9SveDZttSh7cUHzIc4ZTkzS4FqHNCV+HYy0 X-MS-Exchange-Transport-CrossTenantHeadersStamped: SJ0PR12MB6806 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 10/3/2023 5:36 PM, Stephen Hemminger wrote: > On Tue, 3 Oct 2023 11:47:51 +0100 > Ferruh Yigit wrote: > >> On 10/2/2023 7:37 PM, Stephen Hemminger wrote: >>> Some of the ethernet address formats which were invalid will >>> now become valid inputs when rte_ether_unformat_addr is modified >>> to allow leading zeros. >>> >>> Also, make local variables static. >>> >>> Signed-off-by: Stephen Hemminger >>> >> >> <...> >> >>> @@ -61,10 +60,8 @@ const char * ether_addr_invalid_strs[] = { >>> "INVA:LIDC:HARS", >>> /* misc */ >>> "01 23 45 67 89 AB", >>> - "01.23.45.67.89.AB", >>> "01,23,45,67,89,AB", >>> - "01:23:45\0:67:89:AB", >>> - "01:23:45#:67:89:AB", >>> >> >> Why these two are valid now? >> >> And I guess second one is still not valid, but first one is parsed as >> [1], is this expected? >> >> [1] 00:01:00:23:00:45 > > The code in cmdline converts the comment character # to a null byte. > So both test are the same. > > With new unformat, it allows a 3 part mac address with leading > zeros. > 01:23:45 is equivalent to 0001:0023:0045 > With 3 part MAC, omitting leading zeros looks confusing to me, because that omitted part becomes an octet in MAC. Like: 01:23:45 being equivalent to 00:01:00:23:00:45 As 3 part MAC, and 6 part MAC has separate functions, does it makes sense to require leading zeros in the 3 part MAC, what do you think?