DPDK patches and discussions
 help / color / mirror / Atom feed
From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Ali Alnubani <alialnu@nvidia.com>,
	Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Cc: bruce.richardson@intel.com, dev@dpdk.org,
	Matan Azrad <matan@nvidia.com>,
	 Shahaf Shuler <shahafs@nvidia.com>
Subject: Re: [dpdk-dev] [PATCH] net/mlx4: fix glue library name
Date: Mon, 2 Nov 2020 13:04:23 +0000	[thread overview]
Message-ID: <e2180564-3db1-6ce5-e9b9-45a2af77c2f2@intel.com> (raw)
In-Reply-To: <80f0c398-bac5-dc51-6c0f-cbb044181373@intel.com>

On 11/2/2020 1:01 PM, Ferruh Yigit wrote:
> On 10/26/2020 9:20 AM, Ali Alnubani wrote:
>> The MLX4 library wasn't being successfully initialized with
>> -Dibverbs_link=dlopen because it expected a shared object file
>> with a different name.
>>
> 
> The mlx4 glue library name seems changed in the patch pointed by Fixes line, but 
> mlx5 library name is still using old syntax: 'librte_pmd_mlx5_glue.so', can you 
> please fix that too in a separate patch?
> 

I should be a little more patient, the fix is already in the same thread ;) Thanks.

https://patches.dpdk.org/patch/82174/


>> Fixes: a20b2c01a7a1 ("build: standardize component names and defines")
>> Cc: bruce.richardson@intel.com
>>
>> Signed-off-by: Ali Alnubani <alialnu@nvidia.com>
>> ---
>>   drivers/net/mlx4/meson.build | 2 +-
>>   1 file changed, 1 insertion(+), 1 deletion(-)
>>
>> diff --git a/drivers/net/mlx4/meson.build b/drivers/net/mlx4/meson.build
>> index 404006515..c22a88875 100644
>> --- a/drivers/net/mlx4/meson.build
>> +++ b/drivers/net/mlx4/meson.build
>> @@ -10,7 +10,7 @@ endif
>>   static_ibverbs = (get_option('ibverbs_link') == 'static')
>>   dlopen_ibverbs = (get_option('ibverbs_link') == 'dlopen')
>> -LIB_GLUE_BASE = 'librte_pmd_mlx4_glue.so'
>> +LIB_GLUE_BASE = 'librte_net_mlx4_glue.so'
>>   LIB_GLUE_VERSION = '18.02.0'
>>   LIB_GLUE = LIB_GLUE_BASE + '.' + LIB_GLUE_VERSION
>>   if dlopen_ibverbs
>>
> 


  reply	other threads:[~2020-11-02 13:04 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2020-10-26  9:20 Ali Alnubani
2020-10-26  9:20 ` [dpdk-dev] [PATCH] common/mlx5: " Ali Alnubani
2020-11-01 10:35   ` Matan Azrad
2020-11-01 13:07   ` Raslan Darawsheh
2020-10-28  7:42 ` [dpdk-dev] [PATCH] net/mlx4: " Matan Azrad
2020-11-01 11:49 ` Raslan Darawsheh
2020-11-02 13:01 ` Ferruh Yigit
2020-11-02 13:04   ` Ferruh Yigit [this message]
2020-11-02 13:04   ` Ali Alnubani

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=e2180564-3db1-6ce5-e9b9-45a2af77c2f2@intel.com \
    --to=ferruh.yigit@intel.com \
    --cc=alialnu@nvidia.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=matan@nvidia.com \
    --cc=shahafs@nvidia.com \
    --cc=viacheslavo@nvidia.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).