From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id E04A8A04E7; Mon, 2 Nov 2020 14:04:32 +0100 (CET) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 5CB1CC840; Mon, 2 Nov 2020 14:04:31 +0100 (CET) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 999EEC82A for ; Mon, 2 Nov 2020 14:04:28 +0100 (CET) IronPort-SDR: iGGzNvcPmv5308Qcg3qzGNAGIyGydBuzjLVAukqDlPxxn+S4uyMsJ7IvCRqDIzA4RT+LR/wU4s IMduouOXA4/g== X-IronPort-AV: E=McAfee;i="6000,8403,9792"; a="156657231" X-IronPort-AV: E=Sophos;i="5.77,445,1596524400"; d="scan'208";a="156657231" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2020 05:04:26 -0800 IronPort-SDR: nG+b4wdiMlcOr/lM9MeAFy1xg8IXpaM7dHJU+3BHvCZrVOG+3ki4Wj4VePieLGTzHT6hq9a3Wl BPObw6gqd+kQ== X-IronPort-AV: E=Sophos;i="5.77,445,1596524400"; d="scan'208";a="538011926" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.219.143]) ([10.213.219.143]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 02 Nov 2020 05:04:24 -0800 From: Ferruh Yigit To: Ali Alnubani , Viacheslav Ovsiienko Cc: bruce.richardson@intel.com, dev@dpdk.org, Matan Azrad , Shahaf Shuler References: <20201026092035.11461-1-alialnu@nvidia.com> <80f0c398-bac5-dc51-6c0f-cbb044181373@intel.com> Message-ID: Date: Mon, 2 Nov 2020 13:04:23 +0000 MIME-Version: 1.0 In-Reply-To: <80f0c398-bac5-dc51-6c0f-cbb044181373@intel.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] net/mlx4: fix glue library name X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 11/2/2020 1:01 PM, Ferruh Yigit wrote: > On 10/26/2020 9:20 AM, Ali Alnubani wrote: >> The MLX4 library wasn't being successfully initialized with >> -Dibverbs_link=dlopen because it expected a shared object file >> with a different name. >> > > The mlx4 glue library name seems changed in the patch pointed by Fixes line, but > mlx5 library name is still using old syntax: 'librte_pmd_mlx5_glue.so', can you > please fix that too in a separate patch? > I should be a little more patient, the fix is already in the same thread ;) Thanks. https://patches.dpdk.org/patch/82174/ >> Fixes: a20b2c01a7a1 ("build: standardize component names and defines") >> Cc: bruce.richardson@intel.com >> >> Signed-off-by: Ali Alnubani >> --- >>   drivers/net/mlx4/meson.build | 2 +- >>   1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/drivers/net/mlx4/meson.build b/drivers/net/mlx4/meson.build >> index 404006515..c22a88875 100644 >> --- a/drivers/net/mlx4/meson.build >> +++ b/drivers/net/mlx4/meson.build >> @@ -10,7 +10,7 @@ endif >>   static_ibverbs = (get_option('ibverbs_link') == 'static') >>   dlopen_ibverbs = (get_option('ibverbs_link') == 'dlopen') >> -LIB_GLUE_BASE = 'librte_pmd_mlx4_glue.so' >> +LIB_GLUE_BASE = 'librte_net_mlx4_glue.so' >>   LIB_GLUE_VERSION = '18.02.0' >>   LIB_GLUE = LIB_GLUE_BASE + '.' + LIB_GLUE_VERSION >>   if dlopen_ibverbs >> >