From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 537A145656; Fri, 19 Jul 2024 17:31:27 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CCC3640EE5; Fri, 19 Jul 2024 17:31:26 +0200 (CEST) Received: from NAM10-MW2-obe.outbound.protection.outlook.com (mail-mw2nam10on2050.outbound.protection.outlook.com [40.107.94.50]) by mails.dpdk.org (Postfix) with ESMTP id 945024026A; Fri, 19 Jul 2024 17:31:20 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=INJnFaYLCJmJcGPoVXx/AuQAmDqEqYgWIZwNWHwYgAO5uzqNAY2ZYyXLIzxBj83+30VTDfm6Kpt9zTEYCRJIELYwio5CFganfx4fHUfPFLO+LGjGmA5s4nGAO+JzAEsRsFi71hU/qptjnADkjawvlGUxSflAzKlTQgO/hT2ERFDIHciqDGwMckk2VLldXTZMRmm8CYluoWTLUhQIohMdIHU4IimR8Ee1z/P+Eng5x7YHYKQqibFcDX0bH1GIHOwwtfVwI/Kb75cFjkY4uFSr2iT5qtFCZdUnnypKLfNV4OewSohj399KMlhZX9jG7CX+ftmfGWIkufh4ds2vW0toNA== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=BO8KtjzdyILg1zqtWm5ER6WQT7vBkIu7A1dr8wEQpXg=; b=qDg9zLGootSJmp7ZDq0aa1giEzsW5qGULjkl7kvjxnmNPew4Dn9z2HNFcvkgmeKLMLRyLuWNXF+X1vyRFk3UO+UyTa1UKoGistw48QuQpRkOxFs8juLmvlSPXiqiYGqt3RTabaCH5I9Qo6RDysQzz+uSVi5SQK5PbWw7lFEmSmgayTr+ZLQsjY6E9N3N5w3/Po7KZiAaikU6ig4YeEp2j1Ugqp9Yeh+xQlV/F/+qyKEipO/b3l+4TVIGlybm+Jycf9/s6t48b1ZneiBaR+dRk0yy/kk/mY9L0w19SKY9sVymqKDYlWaa840N0RJlYeY5PfgcNeSJLEkBiyt566DLlg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=BO8KtjzdyILg1zqtWm5ER6WQT7vBkIu7A1dr8wEQpXg=; b=WDeU2JDG5VWxp7Cf5Ze8KvvUM67o5Q1BvFtBuyk3KJ408fDMYuhLKp/0uOFtaDhxBEqp6Q6PbsXcBbF9kkkPqBkXDvWvDmO76U9+vgailZfIU5zvn+3CcmW8pImjhdAowH+FZJbR/Aff3kTNHcWWg0wspyniEajiXgD0bgtG7vc= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) by IA1PR12MB6187.namprd12.prod.outlook.com (2603:10b6:208:3e5::12) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.7784.16; Fri, 19 Jul 2024 15:31:15 +0000 Received: from CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::ebfb:2f9f:f9ca:82cd]) by CH2PR12MB4294.namprd12.prod.outlook.com ([fe80::ebfb:2f9f:f9ca:82cd%4]) with mapi id 15.20.7784.017; Fri, 19 Jul 2024 15:31:15 +0000 Message-ID: Date: Fri, 19 Jul 2024 16:31:11 +0100 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ethdev: fix device init without socket-local memory To: Bruce Richardson Cc: dev@dpdk.org, stable@dpdk.org, Padraig Connolly References: <20240711123500.483119-1-bruce.richardson@intel.com> <4f7e619a-0398-41cc-90a9-3c52b73d1c49@amd.com> <57b08bdb-5f45-4343-a8d2-598d66d82fe8@amd.com> Content-Language: en-US From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@amd.com; keydata= xsFNBGJDD3EBEAC/M7Tk/DfQSmP1K96vyzdhfSBzlCaGtcxNXorq4fALruqVsD3oi0yfyEz9 4YN8x7py0o9EL8ZdpOX0skc0AMCDAaw033uWhCn0GLMeGRKUbfOAPvL6ecSDvGD7CJIO9j0J eZUvasBgPdM/435PEr9DmC6Ggzdzt8IuG4PoLi5jpFSfcqxZFCCxLUDEo/w0nuguk2FTuYJg B2zEZ4JTBZrw7hIHiFh8D8hr6YA6a5uTofq1tr+l048lbtdFUl8TR0aIExVzE4Z8qKZlcE+9 RQaewjK5Al1jLE4sHdmd3GN+IvgDF3D/fLsi25SKJDeGSdeHkOmaX0qGeM4WKIfU6iARRCiQ N3AmBIxZ/A7UXBKLaOyZ+/i3sE6Wb53nrO4i8+0K2Qwyh6LjTeiJAIjYKN43ppxz3DaI+QwQ vI+uyHr4Gg0Da9EPPz/YyKauSeOZCfCB5gIfICO0j6x0SCl8uQ2nLpjxcZkf0gjcwUzP3h+S 3x6NfDji9YEij0zczW/dcSpGgZ6vsFpPrtnP9ZXy6J53yp0kJtOJoOlkEFFdU2yCZnCDseum CoudmGLZVvS0/DzHDJejq+3kK3FDGktZBOxZIIpal+nFqS7lVgOZc4+huVv3jyhzoAUOEyXA XK5j6o7g8STUY+z33QNnHpdLvecMwuzmvqy0jR54yAbZ64mB9QARAQABzSNGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBhbWQuY29tPsLBlwQTAQgAQQIbAwULCQgHAgYVCgkICwIEFgID AQIeAQIXgAIZARYhBEm7aYjps5XGsPHCElRTPtCKKm/6BQJkdyEEBQkE3meNAAoJEFRTPtCK Km/6UdcP/0/kEp49aIUhkRnQfmKmNVpcBEs4NqceNCWTQlaXdEwL1lxf1L49dsF5Jz1yvWi3 tMtq0Mk1o68mQ7q8iZAzIeLxGQAlievMNE0BzLWPFmuX+ac98ITBqKdnUAn6ig5ezR+jxrAU 58utUszDl16eMabtCu76sINL5izB8zCWcDEUB4UqM8iBSQZ7/a7TSBVS0jVBldAORg1qfFIs cGMPQn/skhy3QqbK3u3Rhc44zRxvzrQJmhY6T1rpeniHSyGOeIYqjpbpnMU5n1VWzQ4NXvAD VDkZ4NDw6CpvF4S2h2Ds7w7GKvT6RRTddrl672IaLcaWRiqBNCPm+eKh4q5/XkOXTgUqYBVg Ors8uS9EbQC/SAcp9VHF9fB+3nadxZm4CLPe5ZDJnSmgu/ea7xjWQYR8ouo2THxqNZtkercc GOxGFxIaLcJIR/XChh9d0LKgc1FfVARTMW8UrPgINVEmVSFmAVSgVfsWIV+NSpG9/e90E4SV gMLPABn1YpJ8ca/IwqovctqDDXfxZOvCPOVWTzQe/ut767W+ctGR1kRkxWcz470SycOcY+PW VRPJd91Af0GdLFkwzZgNzkd6Gyc9XXcv4lwwqBLhWrBhqPYB0aZXIG1E/cVTiRp4dWpFHAFD DcuLldjIw93lCDsIeEDM9rBizGVMWEoeFmqSe7pzGTPXzsFNBGJDD3EBEAC8fBFQHej8qgIG CBzoIEd1cZgPIARlIhRudODXoNDbwA+zJMKtOVwol3Hh1qJ2/yZP11nZsqrP4fyUvMxrwhDe WBWFVDbWHLnqXMnKuUU1vQMujbzgq/4Rb9wSMW5vBL6YxhZng+h71JgS/9nVtzyaTtsOTrJi 6nzFSDx6Wbza2jYvL9rlK0yxJcMEiKwZQ/if4KcOesD0rtxomU/iSEv6DATcJbGXP6T93nPl 90XksijRKAmOwvdu3A8IIlxiSSVRP0lxiHOeR35y6PjHY2usfEDZZOVOfDfhlCVAIBZUZALv VmFOVSTYXeKgYa6Ooaf72+cHM3SgJIbYnevJfFv8YQW0MEAJ/IXE7B1Lk+pHNxwU3VBCrKnA fd/PTvviesuYRkrRD6qqZnINeu3b2DouVGGt2fVcGA38BujCd3p8i7azoGc7A6cgF7z9ETnr ANrbg1/dJyDmkDxOxVrVquTBbxJbDy2HaIe9wyJTEK2Sznpy62DaHVY+gfDQzexBXM10geHC IIUhEnOUYVaq65X3ZDjyAQnNDBQ4uMqSHZk8DpJ22X+T+IMzWzWl+VyU4UZXjkLKPvlqPjJk 1RbKScek5L2GhxHQbPaD76Hx4Jiel0vm2G+4wei8Ay1+0YRFkhySxogU/uQVXHTv63KzQMak oIfnN/V2R0ucarsvMBW+gwARAQABwsF8BBgBCAAmAhsMFiEESbtpiOmzlcaw8cISVFM+0Ioq b/oFAmR3IPsFCQTeZ44ACgkQVFM+0Ioqb/qINhAAtcor9bevHy22HvJvXX17IOpPSklZJAeQ Az43ZEo5kRlJ8mElc2g3RzYCvL/V3fSiIATxIsLq/MDtYhO8AAvklxND/u2zeBd7BkRZTZZX W1V1cM3oTvfx3LOhDu4f2ExQzCGdkzbXTRswSJIe1W0qwsDp+YPekbrsKp1maZArGeu+6FuW honeosIrWS98QJmscEhP8ooyJkLDCCOgEk+mJ/JBjzcJGuYn6+Iy/ApMw/vqiLGL1UWekcTA g18mREHqIR+A3ZvypIufSFB52oIs1zD/uh/MgmL62bY/Cw6M2SxiVxLRsav9TNkF6ZaNQCgn GqifliCEMvEuLZRBOZSYH2A/PfwjYW0Ss0Gyfywmb2IA990gcQsXxuCLG7pAbWaeYazoYYEQ NYmWatZNMAs68ERI2zvrVxdJ/fBWAllIEd0uQ4P05GtAHPdTIDQYp545+TPV7oyF0LfXcsQs SFVZE6igdvkjfYmh+QOrHGZvpWXLTmffVf/AQ81wspzbfxJ7sYM4P8Mg5kKOsaoUdyA/2qVe cMh1CLUHXF1GlofpGbe1lj4KUJVse5g3qwV7i9VrseA8c4VIZewdIjkzAhmmbxl+8rM/LKBH dZUMTzME5PFCXJIZ83qkZQ795MTe2YScp9dIV7fsS5tpDwIs7BZNVM1l3NAdK+DLHqNxKuyO 8Zk= In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit X-ClientProxiedBy: FR3P281CA0075.DEUP281.PROD.OUTLOOK.COM (2603:10a6:d10:1f::23) To CH2PR12MB4294.namprd12.prod.outlook.com (2603:10b6:610:a9::11) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: CH2PR12MB4294:EE_|IA1PR12MB6187:EE_ X-MS-Office365-Filtering-Correlation-Id: 75eecc68-e917-4482-aded-08dca807d390 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|366016|1800799024|376014; X-Microsoft-Antispam-Message-Info: =?utf-8?B?a00rWnoxOUlnRWdEV1c4b0plSlBwVjJsa0tFR1ByZUMwT3dQWjN0d0xLSTJE?= =?utf-8?B?TTc2cTM3dSthcHFnaUYvdVU0NCs5QjFhS0VvOEltUHdRQzh2NjZsUWduN2xr?= =?utf-8?B?djB5dzdiWHBSVVd2aFUzbmY3UDRmV0o4aDRUaHVSSjkycjA0dUUwV3BwbmVP?= =?utf-8?B?REsxeG00ekF3Mno2UTlhOGp1WUwrQXBsQVVhRURIWGtTVWhWaERaMWZrUWRK?= =?utf-8?B?ZldXQ0I0U0xwSTJ3bTRLQjk3R0tQcUtLNnpYNVNMYmU1OXdNaUdXZUpBWWNl?= =?utf-8?B?UEFMTmlmNG5mb0JTOHEvM3hnZzNnY2RyR0M2a3ZvSFF6QzBnWkUwc2tEWXRS?= =?utf-8?B?SjZ5a0JQcXlINDdYTUlsWERabUVOcU5VdmtHVzd1R0VPY0d4cjlieWg1blhh?= =?utf-8?B?NjRsWVFPYUh2dWdQdUN5OFRiMmpaR291dDZwUmdoVk1oOTBLNFFvaC9tbjY0?= =?utf-8?B?cDNEakRmZlZGUjBQcE93QVBreHU1dGJVa0hGeFh5VWl3WkJKRFFZZURIaWhv?= =?utf-8?B?dis3QUFaeTRVNVMrc2VWMXNPMGY0SWJML0p4TkV5WDZrb2NoMDNKMnY3MU13?= =?utf-8?B?K294RnYydzQzWkJvcFhLcTl3c1VBcTlaQmQ3bllzczNyWmtOaVQ5N2d3QlM0?= =?utf-8?B?RFJBdWxYQlo1S01VNnJYeFpIaFplVzZlc0FtZXI4amlLRXNxcmVUcVFIclBy?= =?utf-8?B?c3JLdWhKR3ByL1ZmQ09ZUCtSc0ltcCswdTlLWVdmWjdvNDVkVmR5NUxleFVr?= =?utf-8?B?ME1Hd0ZSb3h0WlZidHB5aFlIOVhiZTlBcUZrYWpWOGovNFJ0N25ucDdYUkFU?= =?utf-8?B?R09qK0kySXhSTEd4ci9DcnZmb1h2TjhuSi94QnJCaGFOUlNNdHhnRmJEVUMw?= =?utf-8?B?TU53OHVCMjBEeWxhWC9ickxlNmdEUEdURUhiSzNEYUZVenJjeUhKWnpqUkZZ?= =?utf-8?B?SHFkNGljVjluMURHVzMxSkNHMVNXazVtZXY0WnFVMkNkY1ROS0hBRVQxY0ht?= =?utf-8?B?WHNpd2ZOMzRSRTVyV0RVUGZPMm9iYVExSUJYTzZ5S2EweUxvUC8wbmVpWFMv?= =?utf-8?B?eHd3bW90Yy9tb2dZQ3ZSNlhEak1TeWhIcS8xeUNpakQ4aHEyUlFodjVGMDh3?= =?utf-8?B?ZDg1VXpoYkg0RFFiM1RnLzN3OVprbFhBMzJOVVhoMFhpYXplTjdrY0xBb29X?= =?utf-8?B?ZFFLRjdvUDg2Y0Rtc0oxaGZkM1NYRFN3bm5ldTYvNGx3cWlBUGZVTUdaUjl3?= =?utf-8?B?K0NBeUgrc1BQYk5ieWd3NHNpaTl1c2JwWTIxbXN2T0ZRcWptRzRSdmlhUTR6?= =?utf-8?B?di9DNWhwU2NGd0JXY1FoN25SdU5iY01ibWZUd1h1U1o3MTNqcWhvbitYc0th?= =?utf-8?B?QUhNQjIxMThoWGRKdGJpSUVmSk9vVUxzZEp4NHA3RWFGSERHcWFEb1lhdUZ6?= =?utf-8?B?L3pycWp5WDVHNHRBTnhydVZrN0JLY25FWTMzaTVYU2xYSmIrSjVFWldnVjdB?= =?utf-8?B?QUJ0QmZaZTMwalpVN2tYQlkvenFocDM5djA1azBqQ3BMYzNITDkySXoyNWM1?= =?utf-8?B?NDBwUnFMV2d1MGxpT3pqYjNSVE1INCtITnRJNjFzemNsUmd5N0k0a1NucHlv?= =?utf-8?B?YUxTYUZRTUdxeG5WT0U3M3ZDUlluWnNZWWNvWi9OVFl5S1lDTkJULzlicGVk?= =?utf-8?B?alpyanlWUlFhZWtLc0JONlJPejZ0L05RYVpGeDBYa2JENEZzbVMvckpGdm9C?= =?utf-8?B?ejVyR2NmQmFYdEJ0Yit0aVR4N2hsbHlMZWI2UklXbXpHa2R1NmRZd3ZvS1k1?= =?utf-8?B?S053TDZtY0N2WUxmSGp2QT09?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:CH2PR12MB4294.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(366016)(1800799024)(376014); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?ZTBBN3BERncwYU1ySWpvOVQxT05hUVRUcHhHd3JDK2N4eE55Q3cvRGczU0RY?= =?utf-8?B?TDFqQnVTTjlnUTNZMGtOSGY5UjBpRk5DKzdBQTBVL2dUaG9ibXNlaU0zZ1J0?= =?utf-8?B?eTFOSE1hVEEvVlBIeGYxajFBWEtlcHlMajFlaU1MT0ErR0t2OFlGQklkc2My?= =?utf-8?B?clUvS25Hb2J2aGE5MXpKckhMUW1hL09MRFZNcVRYUVllRDdiNDZ3NUlrdDdQ?= =?utf-8?B?WC91SVRZdGlyeFh4K2ZsY0xtRDVPRDU0b2JSWnhEeHJYdGJHblk3dXRyS1I1?= =?utf-8?B?WXRIQlAyanFDVzNNSURNaW05LzZGNmc2NXlTRGZBeEd0M0oybkpoclVEdmlr?= =?utf-8?B?NW1RK1Y0TU1EZndlRWdMZ3NXWEZhQmpDVjRPelRnc1F0bTczR0ZNeXA5ZFpM?= =?utf-8?B?ZVZlb1VNNkMvSG1WWW1GTnhPVFd5SGI5Vlh6YS9ZVHVGczdqSllHelE5bElq?= =?utf-8?B?aHR4R2N2RDF5ZVU4NUZpdUVGci9SNXRodncyaWVtTjBMR1UxR0ovSlBFbmNQ?= =?utf-8?B?b0ZpUG96WFU0VlFYTHJLYnNJV0RRNTVnTm5Ka3VnUzA1c2F3QWo2MnpSU2xj?= =?utf-8?B?MXpIUkhXcVVTUlB1OWU4TXVFVzdZd1lPTmtITjU5Q1V5QzdpM2REanA2QTZn?= =?utf-8?B?NXpTMVhKeDBCZmxoVkhmcnVxUFdoeENRbDFoTlVwWXpML3hweHlheG5ZWXBE?= =?utf-8?B?Sys5Y3crYmJLcVk4cFZjNndJU2NSUWxxbWp3cEM3ZlRzVFduTWZSdVBWRVll?= =?utf-8?B?aHJTT1FaTVZPRVlOd3E5TVNaTjVsYVdQRUtnZ21oaHlWY0xjK2ZnbG1pOHBx?= =?utf-8?B?dUpzZjhTVnE3MGR2Smg5cW1YaXV2R3Y4ZnNQb1RpdDNlb1lycjdoNTVpZ2Mx?= =?utf-8?B?WEhwTVowYmdnbUhEQ2YwcHJXbVRUQ0NtL2xsclZtNlprM00rQnh0Qy9wZnNM?= =?utf-8?B?QlEwK09ENCs1WHZESjBTRU0rdGU1RmxNckR5Nll1UWxINFZOa24yU1dNZUNT?= =?utf-8?B?K29OSGhjajBjall2eHh2dFpCQkpPcGlaaXpUaG80dlJ0V2NsVTZqZW5aY3JD?= =?utf-8?B?TEVtQUMwNzlzQnlzQ0kyRS9KT0MrVnFNUElsNExHS1R2dUNMWEFhRFhaYUNS?= =?utf-8?B?Z0g1Qlp2WWFnTis4R1V4QXRlbjFxRmpSSHc4Nmx1Vko2ZEw4QWREU0ZLa3dM?= =?utf-8?B?MFZoSXgyMTlrVHdacTV0bU94YUN6R21KTTB2YUtZWStlU2RmdHVOZ1FzVFE1?= =?utf-8?B?NTRYTGJneUFqdUxsMW9xR1Zyb29UYWFRcFlGMFMvUXVNSGdSaXRaOWVHS3hr?= =?utf-8?B?WWRUejFvMm9hNW5qVzVUb3BDamZicS85UVh2YzNyRXErMi9xRzR5RWpocVNC?= =?utf-8?B?eUxGVTRFcVVmTy9sbHZyVFB2WG9OMWYrMzgrWVJWSjZtdTJ5dDNDNWpFOEpF?= =?utf-8?B?T2ZoclZXdFVNTElSOEZMSk1rZXZPeTJOYTNCOFE0QnE2NDVCT2w0S1FHRGYy?= =?utf-8?B?ak9XVDBpUDVhWHVCMDhZWDhEUlp5TXY0KzZZa2ZFOWNEcnJZZkxGNWc0YjZa?= =?utf-8?B?UWN0ellYTFVrYzVIN1pSbm5maEJ3OE1Rb3hMMmlXN3ZTd0dScFdzMzM3VTlz?= =?utf-8?B?bXlnUEtmcGdDNjFzWGcwMlFob000RE53RjZndlBIcXpldHFrSXppN2N1cTR0?= =?utf-8?B?aFpranNaZHMxQnFJVUhmSzFBd0E3ZEE4dFA1UUU5RFFqV1VaOC9FODJPL3V1?= =?utf-8?B?elpzOVBxRUlObG9CM3ovUnBYNkswSTNJWHA5a3d1QTFaalRWdlhtcUVzVjBm?= =?utf-8?B?Z1ZjKzZtZjlrT1MySnhvREpiNnoweWd0UGlrS0VEWUM5clhFWE50R2h3aEpq?= =?utf-8?B?SlY4Znp3NG5NMndzK2Y3alB5ZFpGdWUzZEJuTm1MY21PTFRBQk5FUGx1aHp3?= =?utf-8?B?NWh1dDBjZHNoamlWRDU3RTVOQ0o3QlFQaDl4ajkrbGVvbXI0SmxsTHNuUm0z?= =?utf-8?B?VE11OWFKc1B2MkYzWm1OUTFGMjdFTEl4RXFPWXE5VVAvK01LaHFmaXd2L2JU?= =?utf-8?B?d210QzVhT2lmS3F3RldBSFFGZUZZL05yVitWMDdVZkJnSW5aU1hmZDBuQ2ZO?= =?utf-8?Q?rzWz+eHAnK+lfVNfJie5pKj80?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 75eecc68-e917-4482-aded-08dca807d390 X-MS-Exchange-CrossTenant-AuthSource: CH2PR12MB4294.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 19 Jul 2024 15:31:15.4438 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: mXjlZAUdhzkbz73K71L69o57h5n+YNmv0F6BUE8+0hX70Om330jTRspa2phEOJJU X-MS-Exchange-Transport-CrossTenantHeadersStamped: IA1PR12MB6187 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 7/19/2024 2:22 PM, Bruce Richardson wrote: > On Fri, Jul 19, 2024 at 12:10:24PM +0100, Ferruh Yigit wrote: >> On 7/19/2024 10:57 AM, Bruce Richardson wrote: >>> On Fri, Jul 19, 2024 at 09:59:50AM +0100, Ferruh Yigit wrote: >>>> On 7/11/2024 1:35 PM, Bruce Richardson wrote: >>>>> When allocating memory for an ethdev, the rte_malloc_socket call used >>>>> only allocates memory on the NUMA node/socket local to the device. This >>>>> means that even if the user wanted to, they could never use a remote NIC >>>>> without also having memory on that NIC's socket. >>>>> >>>>> For example, if we change examples/skeleton/basicfwd.c to have >>>>> SOCKET_ID_ANY as the socket_id parameter for Rx and Tx rings, we should >>>>> be able to run the app cross-numa e.g. as below, where the two PCI >>>>> devices are on socket 1, and core 1 is on socket 0: >>>>> >>>>> ./build/examples/dpdk-skeleton -l 1 --legacy-mem --socket-mem=1024,0 \ >>>>> -a a8:00.0 -a b8:00.0 >>>>> >>>>> This fails however, with the error: >>>>> >>>>> ETHDEV: failed to allocate private data >>>>> PCI_BUS: Requested device 0000:a8:00.0 cannot be used >>>>> >>>>> We can remove this restriction by doing a fallback call to general >>>>> rte_malloc after a call to rte_malloc_socket fails. This should be safe >>>>> to do because the later ethdev calls to setup Rx/Tx queues all take a >>>>> socket_id parameter, which can be used by applications to enforce the >>>>> requirement for local-only memory for a device, if so desired. [If >>>>> device-local memory is present it will be used as before, while if not >>>>> present the rte_eth_dev_configure call will now pass, but the subsequent >>>>> queue setup calls requesting local memory will fail]. >>>>> >>>>> Fixes: e489007a411c ("ethdev: add generic create/destroy ethdev APIs") >>>>> Fixes: dcd5c8112bc3 ("ethdev: add PCI driver helpers") >>>>> Cc: stable@dpdk.org >>>>> >>>>> Signed-off-by: Bruce Richardson >>>>> Signed-off-by: Padraig Connolly >>>>> >>>> >>>> Hi Bruce, >>>> >>>> If device-local memory is present, behavior will be same, so I agree >>>> this is low impact. >>>> >>>> But for the case device-local memory is NOT present, should we enforce >>>> the HW setup is the question. This can be beneficial for users new to DPDK. >>>> >>> >>> No we should not do so, because if we do, there is no way for the user to >>> allow using remote memory - the probe/init and even configure call has NO >>> socket_id parameter in it, so the enforcement of local memory is an >>> internal assumption on the part of the API which is not documented >>> anywhere, and is not possible for the user to override. >>> >>>> Probably 'dev_private' on its own has small impact on the performance >>>> (although it may depend if these fields used in datapath), but it may be >>>> vehicle to enforce local memory. >>>> >>> >>> As I explain above in the cover letter, there are already other ways to >>> enforce local memory - we don't need another one. If the user only wants to >>> use local memory for a port, they can do so by setting the socket_id >>> parameter of the rx and tx queues. Enforcing local memory in probe >>> doesn't add anything to that, and just prevents other use-cases. >>> >>>> What is enabled by enabling app to run on cross-numa memory, since on a >>>> production I expect users would like to use device-local memory for >>>> performance reasons anyway? >>>> >>> >>> Mostly users want socket-local memory, but with increasing speeds of NICs >>> we are already seeing cases where users want to run cross-NUMA. For >>> example, a multi-port NIC may have some ports in use on each socket. >>> >> >> Ack. >> >>>> >>>> Also I am not sure if this is a fix, or change of a intentional behavior. >>>> >>> >>> I suppose it can be viewed either way. However, for me this is a fix, >>> because right now it is impossible for many users to run their applications >>> with memory on a different socket to the ports. Nowhere is it documented in >>> DPDK that there is a hard restriction that ports must have local memory, so >>> any enforcement of such a policy is wrong. >>> >> >> Although it seems this is done intentionally in the API, I agree that >> this is not documented in the API, or this restriction is not part of >> the API definition. >> >>> Turning things the other way around - I can't see how anything will break >>> or even slow down with this patch applied. As I point out above, the user >>> can already enforce local memory by passing the required socket id when >>> allocating rx and tx rings - this patch only pushed the failure for >>> non-local memory a bit later in the initialization sequence, where the user >>> can actually specify the desired NUMA behaviour. Is there some >>> case I'm missing where you forsee this causing problems? >>> >> >> A new user may not know that allocating memory from cross-numa impacts >> performance negatively and have this configuration unintentionally, >> current failure enforces the ideal configuration. >> >> One option can be adding a warning log to the fallback case, saying that >> memory allocated from non-local socket and performance will be less. >> Although this message may not mean much to a new user, it may still help >> via a support engineer or internet search... >> > > Yes, we could add a warning, but that is probably better in the app itself. > Thinking about where we get issues, they primarily stem from running the > cores on a different numa node Since the private_data struct is accessed > by cores not devices, any perf degradation will come from having it remote > to the cores. Because of that, I actually think the original implementation > should really have used "rte_socket_id()" rather than the device socket id > for the allocation. > Yes I guess private_data is not accessed by device, but it may be accessed by cores that is running the datapath. This API may be called by core that is not involved to the datapath, so it may not correct to allocate memory from its numa. Will it be wrong to assume that cores used for datapath will be same numa with device, if so allocating memory from that numa (which device is in) makes more sense. Am I missing something? > > For v2, will I therefore include a warning in the case that rte_socket_id() > != device socket_id? WDYT? > > /Bruce