From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 47D78A0503; Fri, 6 May 2022 14:32:20 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id DB24740395; Fri, 6 May 2022 14:32:19 +0200 (CEST) Received: from NAM02-DM3-obe.outbound.protection.outlook.com (mail-dm3nam07on2053.outbound.protection.outlook.com [40.107.95.53]) by mails.dpdk.org (Postfix) with ESMTP id 998F04014F for ; Fri, 6 May 2022 14:32:18 +0200 (CEST) ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=aMKHjMK+r3QzzQbnSjkyHuNpcOz1IH5nJY9KatX6sefD8UEXG/ttwFP+8pEIcG97bdxXHHBdpRK8wplzrdapOnLIL3e2eTzm89J32fm7UwxDjb/Bk/Fur83t6uoGTWczFvDCGmG/UlWkYONxZisRxur5YBq6T++QAJd3fbj0lpovuoNe7bNUqvLyNvOX8yI0ktfqSxBp0Z9vVPnKKgIh5aNNfZiJaVvWWZ3jjgNtxgn+zHDJDgOeFWl7xBjuWqkMAJQWdi8/Z/mMxVMa7FziwzTBEwxEyycTzKlrly8KeA923JgIztiKN+DU7gHO22BGXclpnh3IxPdw5v8B7yiMBQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=/1mOGU4y5wC2reY9h2WQAHj/6RbPL4Nd8A+BLrwCEYI=; b=TLrIDa4Oy1ws7aEpq4RDXD0iG4nKssgTwSba2aaJXZKR0elArQ5JVbUUXmYEnkeJmu3FJrSHPnGe5hHtqv1RJwCYACLQaidXtP9uRYbiZ7CxzikREB8vuzv/s5BCSQlBIUeQN3xo3gp0dFlT+JHOd70bBj011ZeNXPj4Vb5Xi12xxCph139bVgZIPoSZJcv4lNkvyLYNxqSZfV2LQ+KAsRPz17cUMmqg278GRq5lIEpACdjHvwaURbiQnl/BTcumUJ02WORmkAa5tVbIHAUoTKUruyRsSfVdJrDLWsluLYslZFoqFGz9RJLjPzHjKnEMlewfBGkIGvIoHu4hprm10g== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass (sender ip is 149.199.80.198) smtp.rcpttodomain=chelsio.com smtp.mailfrom=xilinx.com; dmarc=pass (p=none sp=none pct=100) action=none header.from=xilinx.com; dkim=none (message not signed); arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=xilinx.onmicrosoft.com; s=selector2-xilinx-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=/1mOGU4y5wC2reY9h2WQAHj/6RbPL4Nd8A+BLrwCEYI=; b=eBFnpk7OYJj8526b5kiCRtCS/EdfUrxFN3Kqt7hMJXw+C4OV5to3oUmDhJKA1Ru/QyTdsgeJsK0pLkR3SaxgDPOLEn7FZHRz8FF1qMxHDdnU10GOWlKbvqFDAekelNpiuGCPWOh77ZmbI3iCL68x3MOsVZv0YyqCahUYLf8PySw= Received: from DM6PR06CA0020.namprd06.prod.outlook.com (2603:10b6:5:120::33) by BN6PR02MB3137.namprd02.prod.outlook.com (2603:10b6:405:62::23) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24; Fri, 6 May 2022 12:32:15 +0000 Received: from DM3NAM02FT047.eop-nam02.prod.protection.outlook.com (2603:10b6:5:120:cafe::f0) by DM6PR06CA0020.outlook.office365.com (2603:10b6:5:120::33) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.5206.24 via Frontend Transport; Fri, 6 May 2022 12:32:14 +0000 X-MS-Exchange-Authentication-Results: spf=pass (sender IP is 149.199.80.198) smtp.mailfrom=xilinx.com; dkim=none (message not signed) header.d=none;dmarc=pass action=none header.from=xilinx.com; Received-SPF: Pass (protection.outlook.com: domain of xilinx.com designates 149.199.80.198 as permitted sender) receiver=protection.outlook.com; client-ip=149.199.80.198; helo=xir-pvapexch01.xlnx.xilinx.com; Received: from xir-pvapexch01.xlnx.xilinx.com (149.199.80.198) by DM3NAM02FT047.mail.protection.outlook.com (10.13.4.114) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.20.5227.15 via Frontend Transport; Fri, 6 May 2022 12:32:13 +0000 Received: from xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2176.14; Fri, 6 May 2022 13:32:12 +0100 Received: from smtp.xilinx.com (172.21.105.197) by xir-pvapexch01.xlnx.xilinx.com (172.21.17.15) with Microsoft SMTP Server id 15.1.2176.14 via Frontend Transport; Fri, 6 May 2022 13:32:12 +0100 Envelope-to: rahul.lakkireddy@chelsio.com, dev@dpdk.org Received: from [10.71.119.95] (port=51547) by smtp.xilinx.com with esmtp (Exim 4.90) (envelope-from ) id 1nmx7z-0007nU-Mn; Fri, 06 May 2022 13:32:12 +0100 Message-ID: Date: Fri, 6 May 2022 13:32:11 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:91.0) Gecko/20100101 Thunderbird/91.8.1 Subject: Re: [PATCH 4/5] net/cxgbe: track packets dropped by TP due to congestion Content-Language: en-US To: Rahul Lakkireddy CC: References: <323a4fe735f784ec49c6c93b18a2b21cde1d05c3.1650297776.git.rahul.lakkireddy@chelsio.com> From: Ferruh Yigit In-Reply-To: Content-Type: text/plain; charset="UTF-8"; format=flowed Content-Transfer-Encoding: 7bit X-EOPAttributedMessage: 0 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 72c1c63a-d36b-4943-afec-08da2f5c7318 X-MS-TrafficTypeDiagnostic: BN6PR02MB3137:EE_ X-Microsoft-Antispam-PRVS: X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: DL+D9zKiGigocHHNuJYnqFewIEkMzj6tyyl58szR1uK/KuGaW8rWOe4QEEizrAblEaUC52AhDbAB2Yg2kzK41RRbISJ5dK9Q2pSBNwzlJXeKKSG1sEMZQiH415GuIU7Li4XQ4xPS5KjiyajSPXgldbbvWn5+Ut8N/5EfYQTdpLWKcC9GCX5MFPAQHdD0ob4cHCbV2Kd4Tmcybf00rtIqvdnG2cS2OONy/LyIWYxyN0PObY4gzruMYDO91vVcYmvdcVXEeE7MEBQpnfVvYpkmrYNB1me4WMw3Kz/HSdReU6baaTyVt8ghCXIsvZgUgJTwPVGeRK7I8nctGeam/6kTbe/5BbeCMaSoQX5DA4Z4vHnKB2d8XC979qXKf9C4JBOyoFrER+U9hBWGwvH416BI6AMqPn+p6VxPgygaG9KnW6jQpMiFVSZ2aAeC7EOEhqIl0/HYSszZ7Sr50KT35YBiYg8gA7+8P/3gVBz/4plTYp0DC0GxslbqPqG1HBNdZD4Vg+D1XCA5w1sSOUlyFUMKqN7MleCajVnwVezLIF6u9+5kYGwJPspIx0xfw3KA9BcBXZotFfJuqHW6Uo3kGEagaUUjiNGgNVqqoFx71Mpc08qWxKNQghqLr0jbeuzbGpUS94Enz40GomkHv2XuDE+gkCXD58N7mCTIGuPPVsmNUG5R3wGQZqwzYgnnwLpw6dKxE2Vj+BBNEwy1EposM51KtdE7u1qE4M6W5NUcftGddAI= X-Forefront-Antispam-Report: CIP:149.199.80.198; CTRY:IE; LANG:en; SCL:1; SRV:; IPV:CAL; SFV:NSPM; H:xir-pvapexch01.xlnx.xilinx.com; PTR:unknown-80-198.xilinx.com; CAT:NONE; SFS:(13230001)(4636009)(40470700004)(36840700001)(46966006)(53546011)(26005)(336012)(426003)(2616005)(47076005)(186003)(9786002)(6916009)(8936002)(70586007)(70206006)(4326008)(8676002)(83380400001)(2906002)(356005)(40460700003)(316002)(5660300002)(7636003)(44832011)(508600001)(31696002)(36860700001)(31686004)(82310400005)(36756003)(50156003)(43740500002); DIR:OUT; SFP:1101; X-OriginatorOrg: xilinx.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 May 2022 12:32:13.8497 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: 72c1c63a-d36b-4943-afec-08da2f5c7318 X-MS-Exchange-CrossTenant-Id: 657af505-d5df-48d0-8300-c31994686c5c X-MS-Exchange-CrossTenant-OriginalAttributedTenantConnectingIp: TenantId=657af505-d5df-48d0-8300-c31994686c5c; Ip=[149.199.80.198]; Helo=[xir-pvapexch01.xlnx.xilinx.com] X-MS-Exchange-CrossTenant-AuthSource: DM3NAM02FT047.eop-nam02.prod.protection.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Anonymous X-MS-Exchange-CrossTenant-FromEntityHeader: HybridOnPrem X-MS-Exchange-Transport-CrossTenantHeadersStamped: BN6PR02MB3137 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 5/6/2022 12:09 PM, Rahul Lakkireddy wrote: > On Thursday, May 05/05/22, 2022 at 17:28:55 +0100, Ferruh Yigit wrote: >> On 4/18/2022 11:24 PM, Rahul Lakkireddy wrote: >>> Rx packets can get dropped at TP due to congestion and this info >>> will not get propagated to MPS. Track these Rx dropped packets >>> in imissed counter. Also add xstats for these counters. >>> >>> Signed-off-by: Rahul Lakkireddy >> >> What 'TP' stands for? As far as I understand it is a kind of FW (TP >> Microcode) but I didn't able to find any reference to it. > > Transport Processor (TP) on the NIC delivers the incoming packets > from the wire to NIC's DMA engine to place the packets in Rx buffers. > TP sends signal towards the Multi-Port Switch (MPS) near the MAC when > the Rxqs run out of Rx buffers posted by driver. These MPS buffer drop > stats are already accounted for in imissed counters. However, if a > large number of Rxqs run out of Rx buffers simultaneously, then the > TP can start dropping packets by itself without informing to the MPS > if there is heavy congestion on the channel. These packets dropped by > TP that could not be informed to MPS are now being accounted for in > imissed counters in this patch. > Thanks Rahul, this is clearer explanation than the original commit log. Can you please put what abbreviations stands for (as you did in above paragraph) in the commit log in next version? Like: 'Transport Processor (TP)', 'Multi-Port Switch (MPS)'