From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <anatoly.burakov@intel.com> Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id ACDC02C6D for <dev@dpdk.org>; Fri, 3 May 2019 17:52:13 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 May 2019 08:52:12 -0700 X-ExtLoop1: 1 Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.251.90.134]) ([10.251.90.134]) by orsmga002.jf.intel.com with ESMTP; 03 May 2019 08:52:11 -0700 To: Thomas Monjalon <thomas@monjalon.net> Cc: dev@dpdk.org References: <20190503153539.17993-1-thomas@monjalon.net> From: "Burakov, Anatoly" <anatoly.burakov@intel.com> Message-ID: <e23d38df-cfde-4d5c-b4bb-2b42fa279a3f@intel.com> Date: Fri, 3 May 2019 16:52:10 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190503153539.17993-1-thomas@monjalon.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] ipc: replace bool checks with explicit non-zero X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> X-List-Received-Date: Fri, 03 May 2019 15:52:14 -0000 On 03-May-19 4:35 PM, Thomas Monjalon wrote: > The function check_input() was returning a bool as error code. > It is changed to return an int, semantically more correct. > While at it, make checks of validate_action_name() return > explicit as described in the coding guidelines. > > Signed-off-by: Thomas Monjalon <thomas@monjalon.net> > --- Acked-by: Anatoly Burakov <anatoly.burakov@intel.com> -- Thanks, Anatoly From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: <dev-bounces@dpdk.org> Received: from dpdk.org (dpdk.org [92.243.14.124]) by dpdk.space (Postfix) with ESMTP id 8A0E0A0AC5 for <public@inbox.dpdk.org>; Fri, 3 May 2019 17:52:16 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 83D825F2D; Fri, 3 May 2019 17:52:15 +0200 (CEST) Received: from mga17.intel.com (mga17.intel.com [192.55.52.151]) by dpdk.org (Postfix) with ESMTP id ACDC02C6D for <dev@dpdk.org>; Fri, 3 May 2019 17:52:13 +0200 (CEST) X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga002.jf.intel.com ([10.7.209.21]) by fmsmga107.fm.intel.com with ESMTP/TLS/DHE-RSA-AES256-GCM-SHA384; 03 May 2019 08:52:12 -0700 X-ExtLoop1: 1 Received: from aburakov-mobl1.ger.corp.intel.com (HELO [10.251.90.134]) ([10.251.90.134]) by orsmga002.jf.intel.com with ESMTP; 03 May 2019 08:52:11 -0700 To: Thomas Monjalon <thomas@monjalon.net> Cc: dev@dpdk.org References: <20190503153539.17993-1-thomas@monjalon.net> From: "Burakov, Anatoly" <anatoly.burakov@intel.com> Message-ID: <e23d38df-cfde-4d5c-b4bb-2b42fa279a3f@intel.com> Date: Fri, 3 May 2019 16:52:10 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:60.0) Gecko/20100101 Thunderbird/60.6.1 MIME-Version: 1.0 In-Reply-To: <20190503153539.17993-1-thomas@monjalon.net> Content-Type: text/plain; charset="UTF-8"; format="flowed" Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [PATCH] ipc: replace bool checks with explicit non-zero X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions <dev.dpdk.org> List-Unsubscribe: <https://mails.dpdk.org/options/dev>, <mailto:dev-request@dpdk.org?subject=unsubscribe> List-Archive: <http://mails.dpdk.org/archives/dev/> List-Post: <mailto:dev@dpdk.org> List-Help: <mailto:dev-request@dpdk.org?subject=help> List-Subscribe: <https://mails.dpdk.org/listinfo/dev>, <mailto:dev-request@dpdk.org?subject=subscribe> Errors-To: dev-bounces@dpdk.org Sender: "dev" <dev-bounces@dpdk.org> Message-ID: <20190503155210.xJR8lRbj0GJpxddiEbMAvI8pOzTNA3HrsEWfdyEde8w@z> On 03-May-19 4:35 PM, Thomas Monjalon wrote: > The function check_input() was returning a bool as error code. > It is changed to return an int, semantically more correct. > While at it, make checks of validate_action_name() return > explicit as described in the coding guidelines. > > Signed-off-by: Thomas Monjalon <thomas@monjalon.net> > --- Acked-by: Anatoly Burakov <anatoly.burakov@intel.com> -- Thanks, Anatoly