From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from dpdk.org (dpdk.org [92.243.14.124])
	by inbox.dpdk.org (Postfix) with ESMTP id 32D7EA04C0;
	Thu, 17 Sep 2020 17:34:15 +0200 (CEST)
Received: from [92.243.14.124] (localhost [127.0.0.1])
	by dpdk.org (Postfix) with ESMTP id 1E6EE1D67A;
	Thu, 17 Sep 2020 17:34:15 +0200 (CEST)
Received: from dispatch1-us1.ppe-hosted.com (dispatch1-us1.ppe-hosted.com
 [67.231.154.164]) by dpdk.org (Postfix) with ESMTP id 53D2D1D449
 for <dev@dpdk.org>; Thu, 17 Sep 2020 17:34:13 +0200 (CEST)
Received: from mx1-us1.ppe-hosted.com (unknown [10.110.50.144])
 by dispatch1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id
 EA0E7200D8; Thu, 17 Sep 2020 15:34:12 +0000 (UTC)
Received: from us4-mdac16-60.at1.mdlocal (unknown [10.110.50.153])
 by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTP id E7268800A9; 
 Thu, 17 Sep 2020 15:34:12 +0000 (UTC)
X-Virus-Scanned: Proofpoint Essentials engine
Received: from mx1-us1.ppe-hosted.com (unknown [10.110.49.107])
 by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 64F4E40060; 
 Thu, 17 Sep 2020 15:34:12 +0000 (UTC)
Received: from webmail.solarflare.com (uk.solarflare.com [193.34.186.16])
 (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits))
 (No client certificate requested)
 by mx1-us1.ppe-hosted.com (PPE Hosted ESMTP Server) with ESMTPS id 9155B28008A;
 Thu, 17 Sep 2020 15:34:08 +0000 (UTC)
Received: from [127.0.0.27] (10.17.10.39) by ukex01.SolarFlarecom.com
 (10.17.10.4) with Microsoft SMTP Server (TLS) id 15.0.1497.2; Thu, 17 Sep
 2020 16:33:52 +0100
To: Ajit Khaparde <ajit.khaparde@broadcom.com>, Andrey Vesnovaty
 <andreyv@nvidia.com>
CC: NBU-Contact-Thomas Monjalon <thomas@monjalon.net>, Ori Kam
 <orika@nvidia.com>, Slava Ovsiienko <viacheslavo@nvidia.com>,
 "jerinj@marvell.com" <jerinj@marvell.com>, Andrew Rybchenko
 <arybchenko@solarflare.com>, dpdk-dev <dev@dpdk.org>, "jer@marvell.com"
 <jer@marvell.com>, Jerin Jacob <jerinjacobk@gmail.com>, Ferruh Yigit
 <ferruh.yigit@intel.com>, Stephen Hemminger <stephen@networkplumber.org>,
 Bruce Richardson <bruce.richardson@intel.com>, Ori Kam <orika@mellanox.com>,
 Viacheslav Ovsiienko <viacheslavo@mellanox.com>, "andrey.vesnovaty@gmail.com"
 <andrey.vesnovaty@gmail.com>, Ray Kinsella <mdr@ashroe.eu>, Neil Horman
 <nhorman@tuxdriver.com>, Thomas Monjalon <tmonjalon@nvidia.com>, Samik Gupta
 <samik.gupta@broadcom.com>
References: <20200702120511.16315-1-andreyv@mellanox.com>
 <20200708213946.30108-1-andreyv@mellanox.com>
 <20200708213946.30108-2-andreyv@mellanox.com>
 <CACZ4nhsopFOU6O1zSxj8zbn+Msis2M=2HcQ3G=QzHiHmmJiHDg@mail.gmail.com>
 <MWHPR1201MB25257988BEBB99B2845CA913DB200@MWHPR1201MB2525.namprd12.prod.outlook.com>
 <CACZ4nhsHedmi-02WiXFJUqAww9iKFK5r+VChJ0-t0oKuBCa5ow@mail.gmail.com>
 <MWHPR1201MB2525C25AED0C6A2EC1242170DB210@MWHPR1201MB2525.namprd12.prod.outlook.com>
 <CACZ4nhuYP+ZnH3bDusPQumCcs8Azk2OAFm1=BQY6QmuMa=-Y4A@mail.gmail.com>
From: Andrew Rybchenko <arybchenko@solarflare.com>
Message-ID: <e24d0489-526e-b576-a770-9ced86d55ae4@solarflare.com>
Date: Thu, 17 Sep 2020 18:33:46 +0300
User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:68.0) Gecko/20100101
 Thunderbird/68.12.0
MIME-Version: 1.0
In-Reply-To: <CACZ4nhuYP+ZnH3bDusPQumCcs8Azk2OAFm1=BQY6QmuMa=-Y4A@mail.gmail.com>
Content-Type: text/plain; charset="utf-8"; format=flowed
Content-Language: en-US
Content-Transfer-Encoding: 7bit
X-Originating-IP: [10.17.10.39]
X-ClientProxiedBy: ocex03.SolarFlarecom.com (10.20.40.36) To
 ukex01.SolarFlarecom.com (10.17.10.4)
X-TM-AS-Product-Ver: SMEX-12.5.0.1300-8.6.1012-25670.006
X-TM-AS-Result: No-7.179800-8.000000-10
X-TMASE-MatchedRID: VPleTT1nwdR0nsJmoztmWPZvT2zYoYOwC/ExpXrHizyPiMW+3YzkgrqS
 NKTkl986XQS0szagh4NHvPWyFe6hU/3OUDZboT0w1JdCMvZkkjI6En2bnefhoIe/yi1B5QhCZJ2
 3hwfoyRtqlM/UPbbakoWSkHf6Tb2DhJOsiG/B2u+KR0fcRBoRNa/WVJNdLUTFQzcrLK1tq+ejxY
 yRBa/qJQPTK4qtAgwIIC0OoeD/hCbQLWxBF9DMQcRB0bsfrpPIx1FPlNAAmcDUrUBLaYGH4wXMy
 JNxaW7EDxFGFpr2S9fMvxJiu6zy0Z6oP1a0mRIj
X-TM-AS-User-Approved-Sender: Yes
X-TM-AS-User-Blocked-Sender: No
X-TMASE-Result: 10--7.179800-8.000000
X-TMASE-Version: SMEX-12.5.0.1300-8.6.1012-25670.006
X-MDID: 1600356852-Uup9mdC4YBCC
Subject: Re: [dpdk-dev] [PATCH v2 1/6] ethdev: add flow shared action API
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

On 9/16/20 10:20 PM, Ajit Khaparde wrote:
> On Wed, Sep 16, 2020 at 8:52 AM Andrey Vesnovaty <andreyv@nvidia.com> wrote:
>>
>> Hi Ajit
>>
>> For shared action configuration I have following suggestion:
>>
>> struct rte_flow_shared_action_conf {
>>          uint32_t no_ingress: 1;
>>          uint32_t no_egress: 1;
>> };
>> /*...*/
>> rte_flow_shared_action_create(..., const struct rte_flow_shared_action_conf *conf, ...);
>>
>> What do you think?
> Andrey, I think this is good.
> Application can specify the direction and PMD can decide whether if
> it needs to honor it or ignore it.
> Please send the updated version of the patch.

Personally I dislike negative flags, offloads, fields etc.
Don't we have a policy to avoid it. At least we have it for
offloads. I see no string reasons here to use negative
instead of positive here.