From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <ferruh.yigit@intel.com>
Received: from mga06.intel.com (mga06.intel.com [134.134.136.31])
 by dpdk.org (Postfix) with ESMTP id 6BA361B602;
 Thu,  2 Nov 2017 19:35:43 +0100 (CET)
Received: from fmsmga004.fm.intel.com ([10.253.24.48])
 by orsmga104.jf.intel.com with ESMTP; 02 Nov 2017 11:35:38 -0700
X-ExtLoop1: 1
X-IronPort-AV: E=Sophos;i="5.44,335,1505804400"; d="scan'208";a="331241156"
Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.241.226.36])
 ([10.241.226.36])
 by fmsmga004.fm.intel.com with ESMTP; 02 Nov 2017 11:35:35 -0700
To: John Daley <johndale@cisco.com>
Cc: dev@dpdk.org, stable@dpdk.org
References: <20171102015908.6953-1-johndale@cisco.com>
 <20171102054710.25010-1-johndale@cisco.com>
From: Ferruh Yigit <ferruh.yigit@intel.com>
Message-ID: <e25087f9-274c-9e5f-8071-1f535f890f60@intel.com>
Date: Thu, 2 Nov 2017 11:35:35 -0700
User-Agent: Mozilla/5.0 (Windows NT 10.0; WOW64; rv:52.0) Gecko/20100101
 Thunderbird/52.4.0
MIME-Version: 1.0
In-Reply-To: <20171102054710.25010-1-johndale@cisco.com>
Content-Type: text/plain; charset=utf-8
Content-Language: en-US
Content-Transfer-Encoding: 7bit
Subject: Re: [dpdk-dev] [PATCH v2] net/enic: fix TSO for packets greater
	than 9208 bytes
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.15
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
X-List-Received-Date: Thu, 02 Nov 2017 18:35:44 -0000

On 11/1/2017 10:47 PM, John Daley wrote:
> A check was previously added to drop Tx packets greater than what the Nic
> is capable of sending since such packets can freeze the send queue. The
> check did not account for TSO packets however, so TSO was limited to 9208
> bytes.
> 
> Check packet length only for non-TSO packets. Also insure that TSO packet
> segment size plus the headers do not exceed what the Nic is capable of
> since this also can freeze the send queue.
> 
> Use the PKT_TX_TCP_SEG ol_flag instead of m->tso_segsz which is the
> preferred way to check for TSO.
> 
> Fixes: ed6e564c214e ("net/enic: fix memory leak with oversized Tx packets")
> Cc: stable@dpdk.org
> 
> Signed-off-by: John Daley <johndale@cisco.com>

Applied to dpdk-next-net/master, thanks.