From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 1B53B45C89; Wed, 6 Nov 2024 01:38:16 +0100 (CET) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id A65954027E; Wed, 6 Nov 2024 01:38:15 +0100 (CET) Received: from NAM12-MW2-obe.outbound.protection.outlook.com (mail-mw2nam12on2050.outbound.protection.outlook.com [40.107.244.50]) by mails.dpdk.org (Postfix) with ESMTP id 27DE340270 for ; Wed, 6 Nov 2024 01:38:14 +0100 (CET) ARC-Seal: i=1; a=rsa-sha256; s=arcselector10001; d=microsoft.com; cv=none; b=JJLKMSJkdjZQc1WpPGAkrEP9pkum2WR8N+0Prz6U1yMWBpGrF8QamJg8oEq8xaQ3YpkTUC3ga+9oDpniwNliPKpMIKP8l7jOe+cgsh6Y96XYT1cYpuKCH8MzB1jsDsJPmMehxdE4k1oij90rfJDWMEfon9puZQqh9q8LXAhNyGncKYLL2+s1NpRF3JqWJPwDhp7LdpRiJCjoNLwv9XVxktZjbXWfX06Eu3JvSa2stNLIOlQs0yR3iz9HtyKVEmWp6yKfnzx9staOzhOmdOW43xv+c7q7LBNtEgiUUchSPpgTFKMpqeF7Y7nTcwtrohRhZk6Wm9BXCaKNJGIA/zVZQw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector10001; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-AntiSpam-MessageData-ChunkCount:X-MS-Exchange-AntiSpam-MessageData-0:X-MS-Exchange-AntiSpam-MessageData-1; bh=ibTrUECgZ5Ks5EbWTzTKsTTpubiNs2nU2LH1hbaQsck=; b=Xj3X7rKd6hVHi8+HV3PSj5I3XOP/S5md5TMLJxF/rkX1OwUfzjDfEEmPQRw/5SXZUZbwYoc/GC6Av76WIsWiHyRwS4yWqS2c02N6puSZUmhAgihKL8LmEMj2r5IujCsTmXpHzVuEEsFXoUAn5wQAryS08rwFdtzEJcZH/6uB2n4Y8ibJoJoXTefVSkJKkGoQZU3pQbM5zo1nxXTqT2+Y2EPoYuoUgEeOwGYf4gKewEdRL0S9txKsP/WSEoGug6AqNpnP7zpKWEgUhCv5FDuP47TWG+aOzu+ANMv44hC3XRIqa+CZAtUsJ8yFkmK+xdwhfwnUhXWcE5Dyl40kmNSVBg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=amd.com; dmarc=pass action=none header.from=amd.com; dkim=pass header.d=amd.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=amd.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=ibTrUECgZ5Ks5EbWTzTKsTTpubiNs2nU2LH1hbaQsck=; b=mG/mrMXlRWChAr/P/MAtGuhSasURmc4zzA3Ffa+KBdUrX6t1SVqd6XTKeYZwYxcamwQ9McepyjqMgWJ4tvaXniswkYsL8IIM6aFjJZ1S91H3meLi8PPDMnaq288YnAvJ6h1vbGW2BNCg7qNErWc6nGKlmThfCBfQW4xqLGNV4ts= Authentication-Results: dkim=none (message not signed) header.d=none;dmarc=none action=none header.from=amd.com; Received: from SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) by CY8PR12MB7313.namprd12.prod.outlook.com (2603:10b6:930:53::17) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.8114.29; Wed, 6 Nov 2024 00:38:09 +0000 Received: from SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055]) by SJ2PR12MB8830.namprd12.prod.outlook.com ([fe80::c3eb:df02:eaa9:2055%3]) with mapi id 15.20.8114.031; Wed, 6 Nov 2024 00:38:09 +0000 Message-ID: Date: Wed, 6 Nov 2024 00:38:03 +0000 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v9 0/9] net/zxdh: introduce net zxdh driver To: Junlong Wang , thomas@monjalon.net, aconole@redhat.com Cc: dev@dpdk.org, dpdklab@iol.unh.edu, stephen@networkplumber.org References: <20241101062156.2637339-1-wang.junlong1@zte.com.cn> <20241105093925.2838469-1-wang.junlong1@zte.com.cn> Content-Language: en-US From: Ferruh Yigit In-Reply-To: <20241105093925.2838469-1-wang.junlong1@zte.com.cn> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit X-ClientProxiedBy: LO4P123CA0209.GBRP123.PROD.OUTLOOK.COM (2603:10a6:600:1a5::16) To SJ2PR12MB8830.namprd12.prod.outlook.com (2603:10b6:a03:4d0::9) MIME-Version: 1.0 X-MS-PublicTrafficType: Email X-MS-TrafficTypeDiagnostic: SJ2PR12MB8830:EE_|CY8PR12MB7313:EE_ X-MS-Office365-Filtering-Correlation-Id: 1b0c90b5-c315-427e-535c-08dcfdfb49a1 X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0;ARA:13230040|376014|1800799024|366016; X-Microsoft-Antispam-Message-Info: =?utf-8?B?a1dmeHZjT0NSakZ1dFlRc1dySGVkU2VJSTdxaEVIajJKY3h5Q2JZYVlhMFR2?= =?utf-8?B?d3BPSmt5TUp2NXlJUm5OMVo5WDBiVzVuQWtXaUhtQS8vOUo5R1lzaU1ScDg2?= =?utf-8?B?QVI3OVVHVlc5SURzWmtvVS9xVGFNOTYvb1VsVTd6NkFXdnFYME9EU2NWMnRz?= =?utf-8?B?cHhKNWc3WXpuQk4yVGR2VlM4WThIeHB3cWtyeUVwRDNqcC9ueTU3ZlVHOURi?= =?utf-8?B?QzJqdkIzK2x6UmRuSXRubkc0dFR3OW5XNi9MZmhNdEpEZlc5SmZJd0tOalFa?= =?utf-8?B?ajRpWHhQR1QzYXdVemJ2V1ZlUVloYzNtQkhJMnFET0ZBQjZNbkV6MVJSTnBW?= =?utf-8?B?RXJtZFU5am5FTnZzcG1Ka09YV1M4Sk05aHhDSTlBZVE2MjhWc0drL1dWQkhB?= =?utf-8?B?STNNMUZNZW9HUWYvdGdGNTBMZFlqMDJIbjJCaW1waGk5cHNCMVBkSjFvcldM?= =?utf-8?B?Q1BMTEczS1RGaFRjV3RSanUrcDNENzZXWWt1VWJuanc3Vml3Q0h4a0tOVlJX?= =?utf-8?B?TzZYeE5FTG1uWU1DU1lZMG5keVNOaEtvcGk2emMybVJ4S1FTY3Q4M0prS3lF?= =?utf-8?B?RFhRd0VaYU5Ldnk1V0lXZGNJNzhGc3FBTG9ETUdVcjM1WExiZGk5RVl4UnNV?= =?utf-8?B?R1g2bVJJYU15TEkrbE83ZG5PR3Vja1A5OEpBblh5ZUVLYml2bXQ5SnVOTDhz?= =?utf-8?B?VmJzNkNJQjFEVndJTHJkdDVpRW54OTUraW5xL0NSOWNmVnhFSTBNNkpSQmVR?= =?utf-8?B?ZGZtS2ZqRHRQNm5WY2VQbnJ0S0RNeGdmdTg1NGdNbDd0M3pqQXBPbHRMT3I1?= =?utf-8?B?RzFIbUlCNytWU1VQczdDeTE2ZEIxM1VTbXl5Y1k2algzYXh1dTJRWFIrRk9T?= =?utf-8?B?K0NZTGRXOGtEeUt5VWNVL0IxaHkyMlhyUGNBYU8xcFdROUVVTVh0WWE2cEo5?= =?utf-8?B?UmM5MTJYQTN5RjRWSC9iVVhTb0g1T1Y2NUFTQXVXMWMrZjcyVjMwL3dlQmZC?= =?utf-8?B?ZGMxSWxsUlVNL2N6SWFoWWU4REx4ckxqaGtpYlhwRXArZTBoa2lpSTBQY0VC?= =?utf-8?B?VXMzaHZxOUFLL1Y1Y1hkTXp0eEZONFhZYVZVaEJtRitrUHY2ZzBQd09OS3Y2?= =?utf-8?B?VHZMdjMrMnIweUgxMjB1N21wc3FPV2l1eWN5dkFNNFZ5S0lNemVqUFVkME5P?= =?utf-8?B?UXJwbENhNm4vdDkxS2Qyd0tScC8zbis5R3VBNWlpK2MvSmVVdHZsbE41Uk4y?= =?utf-8?B?MVA2aGtTZHd1MUxVSTU4NFZSVXg0cllQOFI3UGNUdzVDM1ZKWGN5UW9CVFYx?= =?utf-8?B?VFM3clk4TG1rcXp4UHQrRCtVMEZQZ3RLckV2cCtFM2htcVRvaStRcHFtVzlj?= =?utf-8?B?dXR2cjdaem9ZeW9POTNpSjY5UGM4dVFGUXdZeXdCaGFjaHZ1d0ovUTN0UEY2?= =?utf-8?B?YUVYdU90TldBc1Y0UVpUUmxQdkR5azlNT01DTklieHhLT3I4alJQZnBLNU5n?= =?utf-8?B?eDJDZkhyUEFRMjl6MkJyeTQvZzRCdENJeFAwNzR4MzZRdyt2TU9CR0R2Y1RB?= =?utf-8?B?SXVTeHFsalNOV0NqUXRncFM5YkdBRXhsWUVFQTJBWmdRY1RrTDlSeDlUL2l2?= =?utf-8?B?VjNpclhCVFVZSVNaTXZBMU12ZWtNYVpldWRVc2RmbWVaVjNlRi9oMTZ1Q1NG?= =?utf-8?B?dHFUdDJXSFRkQnBjVVRMKzFtY3dPdHB1SWQxWnJWUjdBQnV1amR0OGJhQjA5?= =?utf-8?Q?Z8BCAu8IXBgq1osHCwQNM6JzHlAScJskhQbBQPG?= X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:SJ2PR12MB8830.namprd12.prod.outlook.com; PTR:; CAT:NONE; SFS:(13230040)(376014)(1800799024)(366016); DIR:OUT; SFP:1101; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?SURPNkttZExRMDJheWZEdzJHek1nd1hHZWlEM2lnU0YvOVB3ZVBCUFZPeVlC?= =?utf-8?B?UGJDVkY1Sy9kMjBmendPUVpadkpWbUdENEhNSzNGYkJyajE2RTRKRnVaY0c3?= =?utf-8?B?Ni8yQnlwdFQxSEZIRzc5YTlkNmdlWG14SnhRZm1pcFNKYnNWVjUzM1FLUVll?= =?utf-8?B?dW0yVTlxYkZqYnFLekRmV2hKUEpzdlFYQVJCdVVjOVpSZEk0ZEkvQUd1UUhm?= =?utf-8?B?d3k1Si83TWxVeHdoeS9Wa2d0K21TY3FRYi90VVFWUk9vYzBhOVpZelBkL0Nx?= =?utf-8?B?NCtwUy9qaGZvaHNHQisvMGdkTnduVStQVGxhOUlTZDJORUNlVkFmcWdneDZm?= =?utf-8?B?RGRDTmY3M2dVYlZYZ1NTeHNmcXhybHlhVDlKQzkvNGZCV0lzaTI1UHBYcmFF?= =?utf-8?B?U2RKbGYyaDFsY1hrdDM0dG16eE5rU2RqWjJ1S3RlNDM2ZXNkeTYrTWZXWVZO?= =?utf-8?B?TWVIdHpTd3pkOUJCdDVBb1FNMUxpUTJLRFRVaWxBZ3BhanJMN0k5WFJQNUFX?= =?utf-8?B?NHFrUVNWT2N5ZmF5dVJVbFlja3A0dzM2dkhHYU5ZL1k4TzJLWlN3eTdRQUhi?= =?utf-8?B?UUR2RUJ0MktFSS9tcGt5elZGdmtqaHQ0OHRTVW93d3lQUEdyMVdLYkpyejU5?= =?utf-8?B?Z0RiTlAyVUJTb3JKZEI3R0tMYjBiYmhScFNnTjFUemlxd1dFQ0pEOGpjSEJi?= =?utf-8?B?T0dQUDB0RTlCaERXNmpySHA5dm5yUzlieVhIckVZdmIyazhqNVJwYXd1YmJ4?= =?utf-8?B?STZ3aDhKSWtaZGk3V1ZHY2ZVUFZtSG01ZzgvcDY0dmY2Vm5jK1Z1d2ttMU9Y?= =?utf-8?B?bUkxRUFZclI4Q2xZSlBHV09VVklsb3lTL29hQ1RQUGpjUlZObWRZSVhMOFcx?= =?utf-8?B?M0RDVllkL1NBT2FibWlFU3RNelM3UlRzNU5mbXVyQ1ljbDRSUmtJeDlSZ3R3?= =?utf-8?B?cEVaMUZTOUk0VHhUaVVyMGZCdTIxQi9uUWJvNndKeGRwRXNHblpRNXdYbDBl?= =?utf-8?B?eGNjZnF0MHh3NEprcnFEcWQ0REEvT2t4QTBSbVJzTGVKU203bVczTVJjbzF5?= =?utf-8?B?dGU3amwzRnpnWWppeVlLeXBvdlhOWGQxTHhoZC9WVHFDb1BuNk42VGI4dHNl?= =?utf-8?B?TVFvOTNTVGdTcFltUW9GQXdFRS8xL0s0RkJxU0pVUHVETlI0aUk5RUxOSWx1?= =?utf-8?B?UUpoWmpqZFMrUzU2UzZqOGNjSFBHdS9FUkIrTXY0M2VObFdOTFlWbzdybzN2?= =?utf-8?B?RTBWdHE1Z1VFNURJdXlXN1U4aVJVbzZwWkdFelZkK0hXU2dsQm5PeVd0WE0z?= =?utf-8?B?WURLYVN0eWdDSSttSGpxVmdDaWRNaE9nNFROUHhPL1pDYVpjaUkyU05CMGpE?= =?utf-8?B?YlYyNkgyR3N2NzJMMVUvaDJWeVRXanlscDVMOWdhUUhxeEppUk5ISmFoaXBz?= =?utf-8?B?eFNuWldDQnZ4YlhvU3F3b001bEhHNDZjMUZ3MGdDZ1hwUDAyMjluck5sbGVm?= =?utf-8?B?TjdkenVteHptV01WZm9HQi9HSUlnQjhYcnhtZGtlWHpralZWWnAvRXFneGNq?= =?utf-8?B?d2tFQlk1d1pmMFIzcksvUERNQ3BTRW1TeUtqUXhXeFE4Ly9yd0tXNlp6Tlp6?= =?utf-8?B?UHN0OXBJd3BUaXpRYTNVK0l1dUNrVUNZdTlmSUtNa1NYdisveWxWUWdlSE44?= =?utf-8?B?V21XWm53bCtVV3ZMZldYMVJzZnlvOUs1WlhWbkQ2TU5kYWtNOXV1QkpISCsy?= =?utf-8?B?OGUyMzhGREYwMkFIUjRHWWs3WmV4a3BCMHkrNXpsQ2xWQnZQVTVhb3kxdURT?= =?utf-8?B?NFFwL2Z0KytDZUNsNEV4R1F0SGc1T0czRSt3Vk11OC9LVG80dWJMRzcxRW9V?= =?utf-8?B?WEpSRVVDMFNNWFVzcXB6citjdERrblk4czN4TE5ZTGloZVNMdWpleFlBL3JB?= =?utf-8?B?V3Jqc2tXK29XN3lrWDNBY2p4VVNtOEJoS2YyL1pqak9POXhKWVJxZFh2ZDBn?= =?utf-8?B?VkNQVWd1bUtjK2tWcHJHQldZektrc204QlY2ak5uMkM3c016UHQ4bGZGcHc1?= =?utf-8?B?bU5DamhLbzB3RUpHNzVTckZBVlBuWXpESEZWM1BZUXlETkdabmxlK2tUNmJk?= =?utf-8?Q?tomvElN8NAvON8hsod/cfDewv?= X-OriginatorOrg: amd.com X-MS-Exchange-CrossTenant-Network-Message-Id: 1b0c90b5-c315-427e-535c-08dcfdfb49a1 X-MS-Exchange-CrossTenant-AuthSource: SJ2PR12MB8830.namprd12.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 06 Nov 2024 00:38:09.6375 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 3dd8961f-e488-4e60-8e11-a82d994e183d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: bgn5+zh4LiASm/UZRm/71dbFgmUcI3LE5l7xmD+fLpgKMMOf6NlcZDc2Pf6RvmLV X-MS-Exchange-Transport-CrossTenantHeadersStamped: CY8PR12MB7313 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 11/5/2024 9:39 AM, Junlong Wang wrote: >> > > >> Hi Junlong, >> > > > >> > > >> I can see not all of the eth_dev_ops implemented, and datapath not >> > > >> implemented, so driver is not functional right now. >> > > > >> > > >> What happens if you want to run testpmd with the current state of the >> > > >> driver, I assume it crashes? >> > > > >> > > >> And what is the plan for the driver? Are you planning to upstream >> > > >> remaining support in this release or in future releases? >> > > > >> > > >> As the driver is not functional yet, to set the expectation right for >> > > >> the users, I suggest marking driver as experimental in the maintainers >> > > >> file and document the restrictions in the driver documentation, also >> > > >> clarify this in the release notes update, what do you think? >> > > > > >> > > > Hi Ferruh, >> > > >       The complete driver function has been implemented. At present, the driver function is integrated in batches. >> > > >       The integrated PMD does not cause the crash but cannot support all PMD functions.We plan to integrate the driver in this version and finally provide a complete and available driver. >> > > >       In the current phase, we will marking driver as experimental in the maintainers file and document the restrictions in the driver documentation, also clarify this in the release notes update. >> > > >       Thanks. >> > > >> > > Sounds good, thanks. >> > > >> > > >> > > Btw, build should be fine after each patch, but in this patch series >> > > there are warnings in some early patches, can you please fix them in >> > > next version? >> > > >> > > @Aaron, @David, what do you think to add patch by patch build to the CI? >> > > I hit the same issue in multiple series in this release. >> >  >> > Sure. But I cannot see these Warnings in the [v9] net/zxdh CI/ > check Description. >> > What do I need to do to see these Warnings？ > >> You need to test compilation after each patch locally. >> You can use "git rebase -i --exec ninja" for instance. > > Sorry, I have tried multiple times to use 'git rebase -i -- > exec ninja' locally after each patch, but I couldn't find the warnings. > I have no idea how to solve it. Is there any other way to see the warnings? > Hi Junlong, I can't reproduce it, and v10 also looks good, so I will proceed with the driver. >From my logs I can see patch by path fails in 'net/r8169', not this driver, probably I confused them as I reviewed them next to each other, sorry about confusion caused.