From: Luca Vizzarro <Luca.Vizzarro@arm.com>
To: Patrick Robb <probb@iol.unh.edu>
Cc: dev@dpdk.org, "Juraj Linkeš" <juraj.linkes@pantheon.tech>,
"Jeremy Spewock" <jspewock@iol.unh.edu>,
"Paul Szczepanek" <paul.szczepanek@arm.com>
Subject: Re: [PATCH v2 1/2] dts: update mypy static checker
Date: Tue, 28 May 2024 13:00:37 +0100 [thread overview]
Message-ID: <e2606f0e-99fa-4bde-917d-046da3b2dd93@arm.com> (raw)
In-Reply-To: <CAJvnSUAToxGse3Ak-hDoj9=hMv=XBFCAYZ0xAe7PtzUEy=QF=g@mail.gmail.com>
On 24/05/2024 15:51, Patrick Robb wrote:
> I think this is fine. Another option would be to move sut_nodes and
> tg_nodes up as DTSRunner attributes. I like preserving the type hint,
> but it also might just be cluttering the code to do this... up to you.
I made the change because of a complaint coming from mypy...
I think it was complaining that the function is not being type checked?
The other solution was to add a mypy ignore attribute.
next prev parent reply other threads:[~2024-05-28 12:00 UTC|newest]
Thread overview: 34+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-05-09 10:57 [PATCH 0/2] dts: update mypy and clean up Luca Vizzarro
2024-05-09 10:57 ` [PATCH 1/2] dts: update mypy static checker Luca Vizzarro
2024-05-13 16:02 ` Juraj Linkeš
2024-05-14 11:30 ` Luca Vizzarro
2024-05-29 11:22 ` Juraj Linkeš
2024-05-09 10:57 ` [PATCH 2/2] dts: clean up config types Luca Vizzarro
2024-05-13 16:12 ` Juraj Linkeš
2024-05-14 11:30 ` Luca Vizzarro
2024-05-29 11:41 ` Juraj Linkeš
2024-05-14 11:34 ` [PATCH v2 0/2] dts: update mypy and clean up Luca Vizzarro
2024-05-14 11:34 ` [PATCH v2 1/2] dts: update mypy static checker Luca Vizzarro
2024-05-24 14:51 ` Patrick Robb
2024-05-28 12:00 ` Luca Vizzarro [this message]
2024-05-29 10:58 ` Juraj Linkeš
2024-05-29 11:39 ` Juraj Linkeš
2024-05-29 15:20 ` Luca Vizzarro
2024-05-14 11:34 ` [PATCH v2 2/2] dts: clean up config types Luca Vizzarro
2024-05-24 16:13 ` Patrick Robb
2024-05-20 15:37 ` [PATCH v2 0/2] dts: update mypy and clean up Nicholas Pratte
2024-05-21 14:59 ` Luca Vizzarro
2024-05-24 13:47 ` Nicholas Pratte
2024-05-24 16:17 ` Patrick Robb
2024-05-28 12:05 ` Luca Vizzarro
2024-05-29 10:44 ` Juraj Linkeš
2024-05-30 15:19 ` [PATCH v3 " Luca Vizzarro
2024-05-30 15:19 ` [PATCH v3 1/2] dts: update mypy static checker Luca Vizzarro
2024-05-30 20:23 ` Jeremy Spewock
2024-05-31 9:29 ` Juraj Linkeš
2024-06-17 15:28 ` Nicholas Pratte
2024-05-30 15:19 ` [PATCH v3 2/2] dts: clean up config types Luca Vizzarro
2024-05-30 20:23 ` Jeremy Spewock
2024-05-31 9:29 ` Juraj Linkeš
2024-06-17 15:30 ` Nicholas Pratte
2024-06-19 23:02 ` [PATCH v3 0/2] dts: update mypy and clean up Thomas Monjalon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=e2606f0e-99fa-4bde-917d-046da3b2dd93@arm.com \
--to=luca.vizzarro@arm.com \
--cc=dev@dpdk.org \
--cc=jspewock@iol.unh.edu \
--cc=juraj.linkes@pantheon.tech \
--cc=paul.szczepanek@arm.com \
--cc=probb@iol.unh.edu \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).