From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <dev-bounces@dpdk.org>
Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124])
	by inbox.dpdk.org (Postfix) with ESMTP id DCA85440F4;
	Tue, 28 May 2024 14:00:42 +0200 (CEST)
Received: from mails.dpdk.org (localhost [127.0.0.1])
	by mails.dpdk.org (Postfix) with ESMTP id 6E3D640648;
	Tue, 28 May 2024 14:00:42 +0200 (CEST)
Received: from foss.arm.com (foss.arm.com [217.140.110.172])
 by mails.dpdk.org (Postfix) with ESMTP id C554F402E4
 for <dev@dpdk.org>; Tue, 28 May 2024 14:00:40 +0200 (CEST)
Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14])
 by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 61C0E339;
 Tue, 28 May 2024 05:01:04 -0700 (PDT)
Received: from [10.57.68.52] (unknown [10.57.68.52])
 by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPSA id 1EFB23F641;
 Tue, 28 May 2024 05:00:38 -0700 (PDT)
Message-ID: <e2606f0e-99fa-4bde-917d-046da3b2dd93@arm.com>
Date: Tue, 28 May 2024 13:00:37 +0100
MIME-Version: 1.0
User-Agent: Mozilla Thunderbird
Subject: Re: [PATCH v2 1/2] dts: update mypy static checker
Content-Language: en-GB
To: Patrick Robb <probb@iol.unh.edu>
Cc: dev@dpdk.org, =?UTF-8?Q?Juraj_Linke=C5=A1?= <juraj.linkes@pantheon.tech>, 
 Jeremy Spewock <jspewock@iol.unh.edu>,
 Paul Szczepanek <paul.szczepanek@arm.com>
References: <20240509105704.1162449-1-luca.vizzarro@arm.com>
 <20240514113446.1948050-1-luca.vizzarro@arm.com>
 <20240514113446.1948050-2-luca.vizzarro@arm.com>
 <CAJvnSUAToxGse3Ak-hDoj9=hMv=XBFCAYZ0xAe7PtzUEy=QF=g@mail.gmail.com>
From: Luca Vizzarro <Luca.Vizzarro@arm.com>
In-Reply-To: <CAJvnSUAToxGse3Ak-hDoj9=hMv=XBFCAYZ0xAe7PtzUEy=QF=g@mail.gmail.com>
Content-Type: text/plain; charset=UTF-8; format=flowed
Content-Transfer-Encoding: 7bit
X-BeenThere: dev@dpdk.org
X-Mailman-Version: 2.1.29
Precedence: list
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <https://mails.dpdk.org/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://mails.dpdk.org/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <https://mails.dpdk.org/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org

On 24/05/2024 15:51, Patrick Robb wrote:
> I think this is fine. Another option would be to move sut_nodes and
> tg_nodes up as DTSRunner attributes. I like preserving the type hint,
> but it also might just be cluttering the code to do this... up to you.

I made the change because of a complaint coming from mypy...
I think it was complaining that the function is not being type checked?

The other solution was to add a mypy ignore attribute.