From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mx1.redhat.com (mx1.redhat.com [209.132.183.28]) by dpdk.org (Postfix) with ESMTP id 49AE769EC for ; Fri, 17 Mar 2017 12:07:20 +0100 (CET) Received: from smtp.corp.redhat.com (int-mx04.intmail.prod.int.phx2.redhat.com [10.5.11.14]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 4D3C4C05B1C5 for ; Fri, 17 Mar 2017 11:07:20 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mx1.redhat.com 4D3C4C05B1C5 Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; dmarc=none (p=none dis=none) header.from=redhat.com Authentication-Results: ext-mx08.extmail.prod.ext.phx2.redhat.com; spf=pass smtp.mailfrom=echaudro@redhat.com DKIM-Filter: OpenDKIM Filter v2.11.0 mx1.redhat.com 4D3C4C05B1C5 Received: from rhvm.imac (ovpn-116-30.ams2.redhat.com [10.36.116.30]) by smtp.corp.redhat.com (Postfix) with ESMTP id EEF115DD6E for ; Fri, 17 Mar 2017 11:07:19 +0000 (UTC) References: <1489661496-12818-1-git-send-email-alejandro.lucero@netronome.com> To: dev@dpdk.org From: Eelco Chaudron Organization: Red Hat Message-ID: Date: Fri, 17 Mar 2017 12:07:18 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:45.0) Gecko/20100101 Thunderbird/45.8.0 MIME-Version: 1.0 In-Reply-To: <1489661496-12818-1-git-send-email-alejandro.lucero@netronome.com> Content-Type: text/plain; charset=windows-1252; format=flowed Content-Transfer-Encoding: 7bit X-Scanned-By: MIMEDefang 2.79 on 10.5.11.14 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.32]); Fri, 17 Mar 2017 11:07:20 +0000 (UTC) Subject: Re: [dpdk-dev] [PATCH] vfio: add hotplug support X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list Reply-To: echaudro@redhat.com List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Fri, 17 Mar 2017 11:07:20 -0000 On 16/03/17 11:51, Alejandro Lucero wrote: > Current device hotplug is just when using UIO. This patch adds > same functionality with VFIO. > > It has been validated through tests using IOMMU and also with VFIO > and no-iommu mode. > > Signed-off-by: Alejandro Lucero > --- > lib/librte_eal/common/eal_common_pci.c | 2 +- > lib/librte_eal/linuxapp/eal/eal_pci.c | 5 +- > lib/librte_eal/linuxapp/eal/eal_pci_init.h | 1 + > lib/librte_eal/linuxapp/eal/eal_pci_vfio.c | 82 ++++++++++- > lib/librte_eal/linuxapp/eal/eal_vfio.c | 193 +++++++++++++++++++------ > lib/librte_eal/linuxapp/eal/eal_vfio.h | 11 +- > lib/librte_eal/linuxapp/eal/eal_vfio_mp_sync.c | 23 ++- > lib/librte_ether/rte_ethdev.c | 2 +- > 8 files changed, 263 insertions(+), 56 deletions(-) Thanks Alex for providing this patch to add the VFIO hotplug functionality, and to incorporate my offline review comments. I also tested this patch in combination with Open vSwitch 2.70's hotplug feature and did not see any problems. //Eelco Reviewed-by: Eelco Chaudron Tested-by: Eelco Chaudron