From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from dpdk.org (dpdk.org [92.243.14.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0BF99A04B2; Tue, 1 Sep 2020 13:17:35 +0200 (CEST) Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 9D1B42B89; Tue, 1 Sep 2020 13:17:34 +0200 (CEST) Received: from mga18.intel.com (mga18.intel.com [134.134.136.126]) by dpdk.org (Postfix) with ESMTP id 4BED41DBD for ; Tue, 1 Sep 2020 13:17:32 +0200 (CEST) IronPort-SDR: jhDI0uZk9FFcUJtTWx/nUu0ZqExmQlg1tXvqeca2HDez8BB5tJwxxTFxXIZ5n/6bXs1gWz4aIq /9e3ZeI8n/ZQ== X-IronPort-AV: E=McAfee;i="6000,8403,9730"; a="144835790" X-IronPort-AV: E=Sophos;i="5.76,378,1592895600"; d="scan'208";a="144835790" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga006.jf.intel.com ([10.7.209.51]) by orsmga106.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Sep 2020 04:17:29 -0700 IronPort-SDR: MbfGNuiR4txK0Srw/T/XDHBp4ao7TMJZQXtZRDJhHVy35tdXjRyOq7tv4pgwPwdAvDaWiLIHvp wnFo6hscrIYg== X-IronPort-AV: E=Sophos;i="5.76,378,1592895600"; d="scan'208";a="301408183" Received: from fyigit-mobl.ger.corp.intel.com (HELO [10.213.211.143]) ([10.213.211.143]) by orsmga006-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 01 Sep 2020 04:17:28 -0700 To: Ed Czeck , dev@dpdk.org, bruce.richardson@intel.com Cc: shepard.siegel@atomicrules.com, john.miller@atomicrules.com References: <20200819153539.32698-1-ed.czeck@atomicrules.com> <20200827161130.14978-1-ed.czeck@atomicrules.com> <20200827161130.14978-2-ed.czeck@atomicrules.com> From: Ferruh Yigit Autocrypt: addr=ferruh.yigit@intel.com; prefer-encrypt=mutual; keydata= mQINBFXZCFABEADCujshBOAaqPZpwShdkzkyGpJ15lmxiSr3jVMqOtQS/sB3FYLT0/d3+bvy qbL9YnlbPyRvZfnP3pXiKwkRoR1RJwEo2BOf6hxdzTmLRtGtwWzI9MwrUPj6n/ldiD58VAGQ +iR1I/z9UBUN/ZMksElA2D7Jgg7vZ78iKwNnd+vLBD6I61kVrZ45Vjo3r+pPOByUBXOUlxp9 GWEKKIrJ4eogqkVNSixN16VYK7xR+5OUkBYUO+sE6etSxCr7BahMPKxH+XPlZZjKrxciaWQb +dElz3Ab4Opl+ZT/bK2huX+W+NJBEBVzjTkhjSTjcyRdxvS1gwWRuXqAml/sh+KQjPV1PPHF YK5LcqLkle+OKTCa82OvUb7cr+ALxATIZXQkgmn+zFT8UzSS3aiBBohg3BtbTIWy51jNlYdy ezUZ4UxKSsFuUTPt+JjHQBvF7WKbmNGS3fCid5Iag4tWOfZoqiCNzxApkVugltxoc6rG2TyX CmI2rP0mQ0GOsGXA3+3c1MCdQFzdIn/5tLBZyKy4F54UFo35eOX8/g7OaE+xrgY/4bZjpxC1 1pd66AAtKb3aNXpHvIfkVV6NYloo52H+FUE5ZDPNCGD0/btFGPWmWRmkPybzColTy7fmPaGz cBcEEqHK4T0aY4UJmE7Ylvg255Kz7s6wGZe6IR3N0cKNv++O7QARAQABtCVGZXJydWggWWln aXQgPGZlcnJ1aC55aWdpdEBpbnRlbC5jb20+iQJsBBMBCgBWAhsDAh4BAheABQsJCAcDBRUK CQgLBRYCAwEABQkKqZZ8FiEE0jZTh0IuwoTjmYHH+TPrQ98TYR8FAl6ha3sXGHZrczovL2tl eXMub3BlbnBncC5vcmcACgkQ+TPrQ98TYR8uLA//QwltuFliUWe60xwmu9sY38c1DXvX67wk UryQ1WijVdIoj4H8cf/s2KtyIBjc89R254KMEfJDao/LrXqJ69KyGKXFhFPlF3VmFLsN4XiT PSfxkx8s6kHVaB3O183p4xAqnnl/ql8nJ5ph9HuwdL8CyO5/7dC/MjZ/mc4NGq5O9zk3YRGO lvdZAp5HW9VKW4iynvy7rl3tKyEqaAE62MbGyfJDH3C/nV/4+mPc8Av5rRH2hV+DBQourwuC ci6noiDP6GCNQqTh1FHYvXaN4GPMHD9DX6LtT8Fc5mL/V9i9kEVikPohlI0WJqhE+vQHFzR2 1q5nznE+pweYsBi3LXIMYpmha9oJh03dJOdKAEhkfBr6n8BWkWQMMiwfdzg20JX0o7a/iF8H 4dshBs+dXdIKzPfJhMjHxLDFNPNH8zRQkB02JceY9ESEah3wAbzTwz+e/9qQ5OyDTQjKkVOo cxC2U7CqeNt0JZi0tmuzIWrfxjAUulVhBmnceqyMOzGpSCQIkvalb6+eXsC9V1DZ4zsHZ2Mx Hi+7pCksdraXUhKdg5bOVCt8XFmx1MX4AoV3GWy6mZ4eMMvJN2hjXcrreQgG25BdCdcxKgqp e9cMbCtF+RZax8U6LkAWueJJ1QXrav1Jk5SnG8/5xANQoBQKGz+yFiWcgEs9Tpxth15o2v59 gXK5Ag0EV9ZMvgEQAKc0Db17xNqtSwEvmfp4tkddwW9XA0tWWKtY4KUdd/jijYqc3fDD54ES YpV8QWj0xK4YM0dLxnDU2IYxjEshSB1TqAatVWz9WtBYvzalsyTqMKP3w34FciuL7orXP4Ai bPtrHuIXWQOBECcVZTTOdZYGAzaYzxiAONzF9eTiwIqe9/oaOjTwTLnOarHt16QApTYQSnxD UQljeNvKYt1lZE/gAUUxNLWsYyTT+22/vU0GDUahsJxs1+f1yEr+OGrFiEAmqrzpF0lCS3f/ 3HVTU6rS9cK3glVUeaTF4+1SK5ZNO35piVQCwphmxa+dwTG/DvvHYCtgOZorTJ+OHfvCnSVj sM4kcXGjJPy3JZmUtyL9UxEbYlrffGPQI3gLXIGD5AN5XdAXFCjjaID/KR1c9RHd7Oaw0Pdc q9UtMLgM1vdX8RlDuMGPrj5sQrRVbgYHfVU/TQCk1C9KhzOwg4Ap2T3tE1umY/DqrXQgsgH7 1PXFucVjOyHMYXXugLT8YQ0gcBPHy9mZqw5mgOI5lCl6d4uCcUT0l/OEtPG/rA1lxz8ctdFB VOQOxCvwRG2QCgcJ/UTn5vlivul+cThi6ERPvjqjblLncQtRg8izj2qgmwQkvfj+h7Ex88bI 8iWtu5+I3K3LmNz/UxHBSWEmUnkg4fJlRr7oItHsZ0ia6wWQ8lQnABEBAAGJAjwEGAEKACYC GwwWIQTSNlOHQi7ChOOZgcf5M+tD3xNhHwUCXqFrngUJCKxSYAAKCRD5M+tD3xNhH3YWD/9b cUiWaHJasX+OpiuZ1Li5GG3m9aw4lR/k2lET0UPRer2Jy1JsL+uqzdkxGvPqzFTBXgx/6Byz EMa2mt6R9BCyR286s3lxVS5Bgr5JGB3EkpPcoJT3A7QOYMV95jBiiJTy78Qdzi5LrIu4tW6H o0MWUjpjdbR01cnj6EagKrDx9kAsqQTfvz4ff5JIFyKSKEHQMaz1YGHyCWhsTwqONhs0G7V2 0taQS1bGiaWND0dIBJ/u0pU998XZhmMzn765H+/MqXsyDXwoHv1rcaX/kcZIcN3sLUVcbdxA WHXOktGTQemQfEpCNuf2jeeJlp8sHmAQmV3dLS1R49h0q7hH4qOPEIvXjQebJGs5W7s2vxbA 5u5nLujmMkkfg1XHsds0u7Zdp2n200VC4GQf8vsUp6CSMgjedHeF9zKv1W4lYXpHp576ZV7T GgsEsvveAE1xvHnpV9d7ZehPuZfYlP4qgo2iutA1c0AXZLn5LPcDBgZ+KQZTzm05RU1gkx7n gL9CdTzVrYFy7Y5R+TrE9HFUnsaXaGsJwOB/emByGPQEKrupz8CZFi9pkqPuAPwjN6Wonokv ChAewHXPUadcJmCTj78Oeg9uXR6yjpxyFjx3vdijQIYgi5TEGpeTQBymLANOYxYWYOjXk+ae dYuOYKR9nbPv+2zK9pwwQ2NXbUBystaGyQ== Message-ID: Date: Tue, 1 Sep 2020 12:17:23 +0100 MIME-Version: 1.0 In-Reply-To: <20200827161130.14978-2-ed.czeck@atomicrules.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH 2/2] net/ark: remove RTE_LIBRTE_ARK_PAD_TX configuration macro X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/27/2020 5:11 PM, Ed Czeck wrote: > Replace behavior with RTE_LIBRTE_ARK_MIN_TX_PKTLEN > with a default value of 0. > Update documentation as needed. Can you please use versions in the patches, it makes easier to follow them? Like '[PATCH v4 2/2]', -v# option to "git format-patch" or "git send-email" does it automatically for you. Also a changelog history that documents what changes in each version helps, a good place to put it is just below the '---' after sign off, this way although it stays in the patch, it is removed automatically by git while merging the patch. > > Signed-off-by: Ed Czeck > --- > doc/guides/nics/ark.rst | 16 ++++++++---- > drivers/net/ark/ark_ethdev_tx.c | 43 ++++++++++++++++++--------------- > drivers/net/ark/ark_logs.h | 8 ------ > 3 files changed, 35 insertions(+), 32 deletions(-) > > diff --git a/doc/guides/nics/ark.rst b/doc/guides/nics/ark.rst > index c3ffcbbc2..c7ed4095f 100644 > --- a/doc/guides/nics/ark.rst > +++ b/doc/guides/nics/ark.rst > @@ -126,11 +126,10 @@ Configuration Information > > The following configuration options are available for the ARK PMD: > > - * **CONFIG_RTE_LIBRTE_ARK_PMD** (default y): Enables or disables inclusion > - of the ARK PMD driver in the DPDK compilation. > - Hi Ed, Can you leave out this piece in this patch? Yes it will go away eventually, but it is not related logically to this change. Let's leave removing it to the patch that removes Makefile which will be removing all relevant pieces as a whole. > - * **CONFIG_RTE_LIBRTE_ARK_PAD_TX** (default y): When enabled TX > - packets are padded to 60 bytes to support downstream MACS. > + * **RTE_LIBRTE_ARK_MIN_TX_PKTLEN** (default 0): Sets the minimum > + packet length for tx packets to the FPGA. Packets less than this > + length are padded to meet the requirement. This allows padding to > + be offloaded or remain in host software. > > > Building DPDK > @@ -144,6 +143,13 @@ By default the ARK PMD library will be built into the DPDK library. > For configuring and using UIO and VFIO frameworks, please also refer :ref:`the > documentation that comes with DPDK suite `. > > +To build with a non-zero minimum tx packet length, set the above macro in your > +CFLAGS environment prior to the meson build step. I.e., > + > + export CFLAGS="-DRTE_LIBRTE_ARK_MIN_TX_PKTLEN=60" > + meson build > + > + > Supported ARK RTL PCIe Instances > -------------------------------- > > diff --git a/drivers/net/ark/ark_ethdev_tx.c b/drivers/net/ark/ark_ethdev_tx.c > index 72624deb3..52ce2ed41 100644 > --- a/drivers/net/ark/ark_ethdev_tx.c > +++ b/drivers/net/ark/ark_ethdev_tx.c > @@ -14,6 +14,11 @@ > #define ARK_TX_META_OFFSET (RTE_PKTMBUF_HEADROOM - ARK_TX_META_SIZE) > #define ARK_TX_MAX_NOCHAIN (RTE_MBUF_DEFAULT_DATAROOM) > > +#ifndef RTE_LIBRTE_ARK_MIN_TX_PKTLEN > +#define ARK_MIN_TX_PKTLEN 0 > +#else > +#define ARK_MIN_TX_PKTLEN RTE_LIBRTE_ARK_MIN_TX_PKTLEN > +#endif > > /* ************************************************************************* */ > struct ark_tx_queue { > @@ -104,28 +109,28 @@ eth_ark_xmit_pkts(void *vtxq, struct rte_mbuf **tx_pkts, uint16_t nb_pkts) > ++nb) { > mbuf = tx_pkts[nb]; > > - if (ARK_TX_PAD_TO_60) { > - if (unlikely(rte_pktmbuf_pkt_len(mbuf) < 60)) { > - /* this packet even if it is small can be split, > - * be sure to add to the end mbuf > +#if ARK_MIN_TX_PKTLEN != 0 Previous "if (...)" approach was better, compiler was checking the code independent from 'RTE_LIBRTE_ARK_MIN_TX_PKTLEN' defined or not, and compiler was optimizing out the code if it is not defined. With the '#if' macro, we are losing the compiler check. If there is no explicit reason, can you keep the old behavior here?