From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 532E943DB2; Tue, 2 Apr 2024 08:05:47 +0200 (CEST) Received: from mails.dpdk.org (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id D4B204028C; Tue, 2 Apr 2024 08:05:46 +0200 (CEST) Received: from mail.lysator.liu.se (mail.lysator.liu.se [130.236.254.3]) by mails.dpdk.org (Postfix) with ESMTP id 247804026F for ; Tue, 2 Apr 2024 08:05:45 +0200 (CEST) Received: from mail.lysator.liu.se (localhost [127.0.0.1]) by mail.lysator.liu.se (Postfix) with ESMTP id 3F21276EB for ; Tue, 2 Apr 2024 08:05:44 +0200 (CEST) Received: by mail.lysator.liu.se (Postfix, from userid 1004) id 327217780; Tue, 2 Apr 2024 08:05:44 +0200 (CEST) X-Spam-Checker-Version: SpamAssassin 4.0.0 (2022-12-13) on hermod.lysator.liu.se X-Spam-Level: X-Spam-Status: No, score=-1.3 required=5.0 tests=ALL_TRUSTED,AWL, T_SCC_BODY_TEXT_LINE autolearn=disabled version=4.0.0 X-Spam-Score: -1.3 Received: from [192.168.1.59] (h-62-63-215-114.A163.priv.bahnhof.se [62.63.215.114]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by mail.lysator.liu.se (Postfix) with ESMTPSA id 41EFA7673; Tue, 2 Apr 2024 08:05:42 +0200 (CEST) Message-ID: Date: Tue, 2 Apr 2024 08:05:41 +0200 MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v1 0/2] deque: add multithread unsafe deque library To: Stephen Hemminger , Aditya Ambadipudi Cc: "dev@dpdk.org" , "jackmin@nvidia.com" , "matan@nvidia.com" , "viacheslavo@nvidia.com" , "roretzla@linux.microsoft.com" , "konstantin.v.ananyev@yandex.ru" , "konstantin.ananyev@huawei.com" , "mb@smartsharesystems.com" , Honnappa Nagarahalli , Dhruv Tripathi , Wathsala Wathawana Vithanage , nd References: <20230821060420.3509667-1-honnappa.nagarahalli@arm.com> <20240401013729.1466298-1-aditya.ambadipudi@arm.com> <20240401070503.737db4f5@hermes.local> <20240401174758.3a03f6b9@hermes.local> Content-Language: en-US From: =?UTF-8?Q?Mattias_R=C3=B6nnblom?= In-Reply-To: <20240401174758.3a03f6b9@hermes.local> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit X-Virus-Scanned: ClamAV using ClamSMTP X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org On 2024-04-02 02:47, Stephen Hemminger wrote: > On Mon, 1 Apr 2024 22:28:52 +0000 > Aditya Ambadipudi wrote: > >> Thanks, Stephen, for the comment. >> >> Unfortunately, we don't have the dev setup nor the resources to test out this change using MSVC. >> >> Thank you, >> Aditya Ambadipudi > > All it requires is the community version of MSVC which is free. And setting up a Windows > VM with KVM is free and easy. > > IMHO all new libraries have to build on all environments, unless they are enabling > platform specific features. Requiring all contributors to build and test on what is, in this context, a pretty obscure platform with a pretty obscure compiler seems like a bad idea to me. It will raise the bar for contributions further. In principle I agree though. Your contribution should not only build, but also run (and be tested) on all platforms. Otherwise, Windows isn't supported in the upstream, but rather we have a Windows port (which happens to live in the same source tree). I never tested any contribution on a FreeBSD system, but at least those use the de-facto standard compilers and a standard API (POSIX), so the likelihood of things actually working is greater (but maybe not great enough). Surely, this is something the tech board must have discussed when it agreed to supporting Windows *and* MSVC. Many if not most of the man-hours involved won't be spent by the Windows maintainer, but the individual future contributors.