From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 0468EA0C4E; Fri, 13 Aug 2021 14:02:35 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id 883AF4069C; Fri, 13 Aug 2021 14:02:34 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by mails.dpdk.org (Postfix) with ESMTP id AC52E40140 for ; Fri, 13 Aug 2021 14:02:32 +0200 (CEST) X-IronPort-AV: E=McAfee;i="6200,9189,10074"; a="215277864" X-IronPort-AV: E=Sophos;i="5.84,318,1620716400"; d="scan'208";a="215277864" Received: from fmsmga003.fm.intel.com ([10.253.24.29]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Aug 2021 05:02:31 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.84,318,1620716400"; d="scan'208";a="518103010" Received: from orsmsx603.amr.corp.intel.com ([10.22.229.16]) by FMSMGA003.fm.intel.com with ESMTP; 13 Aug 2021 05:02:31 -0700 Received: from orsmsx607.amr.corp.intel.com (10.22.229.20) by ORSMSX603.amr.corp.intel.com (10.22.229.16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Fri, 13 Aug 2021 05:02:30 -0700 Received: from orsmsx602.amr.corp.intel.com (10.22.229.15) by ORSMSX607.amr.corp.intel.com (10.22.229.20) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10; Fri, 13 Aug 2021 05:02:30 -0700 Received: from ORSEDG601.ED.cps.intel.com (10.7.248.6) by orsmsx602.amr.corp.intel.com (10.22.229.15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256) id 15.1.2242.10 via Frontend Transport; Fri, 13 Aug 2021 05:02:30 -0700 Received: from NAM12-DM6-obe.outbound.protection.outlook.com (104.47.59.172) by edgegateway.intel.com (134.134.137.102) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.1.2242.10; Fri, 13 Aug 2021 05:02:30 -0700 ARC-Seal: i=1; a=rsa-sha256; s=arcselector9901; d=microsoft.com; cv=none; b=FqEosaKWOSqMnnfcWk+j0jdHXKrOqj44loyYMIzWmPGhSGK99Z6N4O24VcXfdiBjZ0ehf+I/sj3mWj2cY3z1fe7++FEJULYrwYcViC+lKDRqyn855uGreTxKxFCFhC9iJ+yvxRyG7mKzbnvj2sZMjozw/Gtk+/4XTalZyFGHxjCG2Rc1khIUKhy74d0UhyvLCo8aihWMbO4c2n5s1pKSIomPKVxnCqsiK4npdvvAMFRp1bMTDV517YFqdP6Kv6IU2PZ0c+IO3rRjO5wcGhZmdaywS44UmrmQkno/iqWAgfgsKuvwVERHgfkVfMGHgDGihBwMqMhCqI1NYJL7LnIoMw== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=microsoft.com; s=arcselector9901; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yrDVU3jnD/gGfAjyvnvUZzFjz8/+Siq8UCnZ2WDDN0g=; b=QA3wtAqRjf6ai2Z28m4dvkB+L3yjFIUbFTPBV3S/jlHp6igeaTcj1QCo8CIuCTVKJaGrqHcz+b5U8vGu/rxic4asa/08tam5rNKgH2QXi1XghbhEP7ZgZZZ/vkTdIq2ZaUIqb3OVpKqMREBcEI2KkzicIBPs7YslOcYRBn0yc6bFsaRGF6L6CwwWoN2ROuH+4wzfJ0/d2WLqdkoLKjEnYE0eWq3lPlvuN8SaPnaKD1tRJB8pGbqA6LWShxsIAqA3JG/qMBbiFKRD45bWRAynsQVzh4UsKqfCXY3lxie3+YLogZCo7PqqydEGFz9KIkgNFr5xgxrcs2kderQjTJAihg== ARC-Authentication-Results: i=1; mx.microsoft.com 1; spf=pass smtp.mailfrom=intel.com; dmarc=pass action=none header.from=intel.com; dkim=pass header.d=intel.com; arc=none DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=intel.onmicrosoft.com; s=selector2-intel-onmicrosoft-com; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version:X-MS-Exchange-SenderADCheck; bh=yrDVU3jnD/gGfAjyvnvUZzFjz8/+Siq8UCnZ2WDDN0g=; b=jv5eWDDk7oZYnmC27lR3sbpQ4nHmVVCY24O0Wl0VMEqPYBmXGNj+KKEw5cR5OGT3xVEypG9eWyg522EWft/VNN2vi0EDLWuZfBXx5hDZzXH5D/ggkf4l+/RowDBmUK34GmP+I9ECHYgw5bmG4JoQVrrmLsmPRc56KX7OBakXdfw= Authentication-Results: intel.com; dkim=none (message not signed) header.d=none;intel.com; dmarc=none action=none header.from=intel.com; Received: from PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) by PH0PR11MB4775.namprd11.prod.outlook.com (2603:10b6:510:34::22) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.16; Fri, 13 Aug 2021 12:02:26 +0000 Received: from PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::2979:70ca:38a:dbaf]) by PH0PR11MB5000.namprd11.prod.outlook.com ([fe80::2979:70ca:38a:dbaf%7]) with mapi id 15.20.4415.019; Fri, 13 Aug 2021 12:02:26 +0000 To: Wenjun Wu , , , References: <20210802083659.1003658-1-wenjun1.wu@intel.com> From: Ferruh Yigit X-User: ferruhy Message-ID: Date: Fri, 13 Aug 2021 13:02:21 +0100 In-Reply-To: <20210802083659.1003658-1-wenjun1.wu@intel.com> Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 8bit X-ClientProxiedBy: PR0P264CA0267.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1::15) To PH0PR11MB5000.namprd11.prod.outlook.com (2603:10b6:510:41::19) MIME-Version: 1.0 X-MS-Exchange-MessageSentRepresentingType: 1 Received: from [192.168.0.206] (37.228.236.146) by PR0P264CA0267.FRAP264.PROD.OUTLOOK.COM (2603:10a6:100:1::15) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_GCM_SHA384) id 15.20.4415.14 via Frontend Transport; Fri, 13 Aug 2021 12:02:25 +0000 X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-Correlation-Id: 1cdca12d-0efd-4560-40f0-08d95e5237ca X-MS-TrafficTypeDiagnostic: PH0PR11MB4775: X-LD-Processed: 46c98d88-e344-4ed4-8496-4ed7712e255d,ExtAddr X-MS-Exchange-Transport-Forked: True X-Microsoft-Antispam-PRVS: X-MS-Oob-TLC-OOBClassifiers: OLM:60; X-MS-Exchange-SenderADCheck: 1 X-MS-Exchange-AntiSpam-Relay: 0 X-Microsoft-Antispam: BCL:0; X-Microsoft-Antispam-Message-Info: hG4L4dO8Bq9x1RhUCRk3u2TQV1UnRonhJlYnvjL+xZPTwUGYSckfn/1a9FQXy/l7Eh1Fk7QWm8TvHRfTCVTq68w5uNe6iVx5eRKZMIED9rASS5gJlIzbAO7klgZnBXhsETBKvS9xiJuWNaNqjWRwCBLEQF6MwGoASpMILP9pauYGs2SzklRrmin/JW1/WwWPuywtQbm8C7OLoGsGDS58T3kL+G4PT7J3gma0OdFysnZUmQsl3EtV9OQbrzI9Z15HCDxzkiN2Jug34Nil69FN+J3ag925KsuEsCxKhhjowG3prFZMa2VUf2E2kNIxeypC+AMIH5fjCys7sXqabZ5r/UUhBF2tN76eSrT99y8sXOvxPu9sQ6CRy8woCVwnXshrV1+FdOZwJKNUH5h6PSZwKT6l8tFAM02Lafs9AViiP/WiwdidHEWGlB2M7gD4tR1jD4sCQaTwMolEgfnrmxptsGGs5G27yhUD6bN0N++TO+ODLT1YZGSW2EMRW+wmbNW4UPQvkF76bZf9ZSTpp7A5Pw/mUiJnGfYevhuKdNI1PvYvK7YQJkXBkERCkf/HhV4OBqeHmZUpEqs8jHRNoQ3QzErPHqW8vPhx5YTOK0WMslAHhlwD4USa945tw2UUh4KdEN0JI1OJW27VBoTP5Zv31JzEoJHBdt9Q6M4YXXlEvLfzuhp5TZuinsFvWgIQUnzXmNkeV3IH4HFD0xrIc8enVw== X-Forefront-Antispam-Report: CIP:255.255.255.255; CTRY:; LANG:en; SCL:1; SRV:; IPV:NLI; SFV:NSPM; H:PH0PR11MB5000.namprd11.prod.outlook.com; PTR:; CAT:NONE; SFS:(4636009)(396003)(346002)(136003)(366004)(39860400002)(376002)(6486002)(36756003)(66476007)(66556008)(31686004)(66946007)(44832011)(26005)(186003)(2906002)(8676002)(6636002)(31696002)(83380400001)(38100700002)(956004)(478600001)(2616005)(5660300002)(316002)(16576012)(8936002)(53546011)(6666004)(86362001)(45980500001); DIR:OUT; SFP:1102; X-MS-Exchange-AntiSpam-MessageData-ChunkCount: 1 X-MS-Exchange-AntiSpam-MessageData-0: =?utf-8?B?Q0pDdWtKT1hTeExoSVAyWGxmYnErVGZsTWoybFdrS05YeXAvcFlrR2swQnVM?= =?utf-8?B?bktENzk2OFNBQjRsMnAwa0xVUlRmZnhWV1ZtbkV6dzdSd0lIc2xZODZ0VERs?= =?utf-8?B?Tk10STg1SzZMRWpnUGRYSTRTY2tVcDlKZEQ1b2kwMmZQb2xLNVFtZXNmczdO?= =?utf-8?B?bW5iV2lFWEozR0xTTmZVTzVvanYyRElwUVpkYnJaOWRtN3JCR0NPYjFmTlBM?= =?utf-8?B?eW5mVi9FQzdWWEwxVG9BRFBVZEVJT1RxV3Q0MEhURlpZQWluM3F5bitEelln?= =?utf-8?B?ZGVBZXo0K01vbWdOck0zMktJMzlGTWhtYmtNcGNNdktHaW1DbzN1MkFCZU1B?= =?utf-8?B?MGtUdGllYVR1TGxRSzlzRWlHcWo0NWpRZytIaFJYRmdTNE5tUUwySDlkZE5p?= =?utf-8?B?Q2NJL0FBY0NRVVQ4VDZTc3BvNlY5WGI1VkxGN0p2WVdqdTdvbEljSlpIZk96?= =?utf-8?B?c2JYZFkwZTEyWWI1Rjk3QzRnRFFSdE1IOVcxaXdwU2lPeW5DV3VsclBWODFG?= =?utf-8?B?Q2xja0RnUVNxc2c3UFV1bXVqakZXTi92ak9UaDdsSFNkUmY0UzNHcmsvYWU0?= =?utf-8?B?ak1XTjFVVzZJVGMrV1hscUZFUXcxTlZxYlJxc0ZyUjh0dXhKSlRWK0ZLaHla?= =?utf-8?B?OWliN3huaGptalJNUGhUekxGWG96TXV2blpnckg5cHFRNW1YdHFpK240aktS?= =?utf-8?B?NFhtUjhsTWhJVGNVd1pEemQ5NVhzdlBoQUJJV0xUQ0tLWTI4K2xqOW1pcG9Z?= =?utf-8?B?bGQxdFkvemRuVTZadEx6MExObktjTTRVaEhDdnNYQjQ4RGxMeURYTzdIN202?= =?utf-8?B?a1VmanlIcURWVEVRUVVxMTZGc1RCV3VsNVpTTng0M0N1d3UvcFI0RUpLZFBS?= =?utf-8?B?aDU5ZE5Ub3d5MzFlYVd2SXJpZC90QnlhdHZockpYdmlxVUdpb0N3STdWZ0tn?= =?utf-8?B?bG5HWXdpdGgzU2xaYURmeUV5WUlIeXE5TVhzQmlXQVJJYi83VnR3VWRyUXE0?= =?utf-8?B?SCtXTGNzNkI5QkdxaHhTT292RlZEQ1RBMEJDdjR6Vk5tbGQ1dG9rWkNkV3BX?= =?utf-8?B?aEh6czlKVnlEQU5vSVZETmsvbUxiWEphV1pzUnZRSE0rWUNENzRHSGVsTzlR?= =?utf-8?B?bmxlM0lQdElFdW9JdWZXNFJuRWRMK0pGVlgzWVNTZ2pnWFFaYnVUeG1DajlF?= =?utf-8?B?aVQ4cWswSWN1d05WTHY2UDIzUFdGK1FmOGxBdTlFOXdKUlVqaUZ4dE1rRlA0?= =?utf-8?B?R1QwbWxQc2VhZ2NyNk9CVlhNdkNMZWh3TkxSdFJNWk8rY1R5MCs3M0NJVEJN?= =?utf-8?B?eVl2K2hTQkc5R09HT1N6WnlTc0hIVEs5cWxwMVJpallDSmZ5aUVLanlCazJR?= =?utf-8?B?dEJVQWNvYWRoRDc3blkzdFJRSm5LS1A2Tys1eVVrcFhRVTVSWnliWDNvbkxx?= =?utf-8?B?cWhLWU5Eb2l6YXQ5QmFlTnVpVGZiMGI2MDJONXRxQTRRZ0dmMUJaT1NEN2U1?= =?utf-8?B?VG1mMmVUaUpJaUtVWXBVOFdNeGJQY3BMR053WUdiQzZpc256U0sxM3hHcVlQ?= =?utf-8?B?SlJkNzY0K0Q0QTdPcWppWS9pSVY0NW43bVc1eXIrcGhYbVVhVmhiVkc4NGFa?= =?utf-8?B?cERKZ2ZkWk1adm0xbmpCT1RvcC9YTU0reFExem00WjNnMndsdkUweWtGR0RM?= =?utf-8?B?SmtCT215UjB2aVFhVmZtS1pEOEczYXFvQS9XUFdUY29sdUxQMWxwK1RwTXEx?= =?utf-8?Q?O6BoATYIxKPbVgbDuzz3TjaRf5E1ig03/6PPHQE?= X-MS-Exchange-CrossTenant-Network-Message-Id: 1cdca12d-0efd-4560-40f0-08d95e5237ca X-MS-Exchange-CrossTenant-AuthSource: PH0PR11MB5000.namprd11.prod.outlook.com X-MS-Exchange-CrossTenant-AuthAs: Internal X-MS-Exchange-CrossTenant-OriginalArrivalTime: 13 Aug 2021 12:02:26.7281 (UTC) X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: 46c98d88-e344-4ed4-8496-4ed7712e255d X-MS-Exchange-CrossTenant-MailboxType: HOSTED X-MS-Exchange-CrossTenant-UserPrincipalName: A0FGryMWgHV9s9DWNH0ESexCn0eaYUM6mwdBLVi6CRYKp9BG0hNhdHqDlEnNa4s/ihUHKVkiGKuTYoRmBpOG1w== X-MS-Exchange-Transport-CrossTenantHeadersStamped: PH0PR11MB4775 X-OriginatorOrg: intel.com Subject: Re: [dpdk-dev] [PATCH v1 2/2] net/ice: remove redundant default RSS field for IP fragment packets X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 8/2/2021 9:36 AM, Wenjun Wu wrote: > This patch removes redundant default RSS field for IP fragment packets, > only src MAC address and dst MAC address are needed. > Same comments with first patch. Impact is not clear, and this patch seems a little different from first path, this clears one flag from 'cfg.hash_flds', why and if this is not causing any impact (that is what I understand from description) can you explain in the commit log why it doesn't change the behavior of the code? Also again long patch title. > Signed-off-by: Wenjun Wu > --- > drivers/net/ice/ice_ethdev.c | 4 ++-- > 1 file changed, 2 insertions(+), 2 deletions(-) > > diff --git a/drivers/net/ice/ice_ethdev.c b/drivers/net/ice/ice_ethdev.c > index a4cd39c954..64ee569525 100644 > --- a/drivers/net/ice/ice_ethdev.c > +++ b/drivers/net/ice/ice_ethdev.c > @@ -2975,7 +2975,7 @@ ice_rss_hash_set(struct ice_pf *pf, uint64_t rss_hf) > > if (rss_hf & ETH_RSS_FRAG_IPV4) { > cfg.addl_hdrs = ICE_FLOW_SEG_HDR_IPV4 | ICE_FLOW_SEG_HDR_IPV_FRAG; > - cfg.hash_flds = ICE_FLOW_HASH_IPV4 | BIT_ULL(ICE_FLOW_FIELD_IDX_IPV4_ID); > + cfg.hash_flds = ICE_FLOW_HASH_IPV4; > ret = ice_add_rss_cfg_wrap(pf, vsi->idx, &cfg); > if (ret) > PMD_DRV_LOG(ERR, "%s IPV4_FRAG rss flow fail %d", > @@ -2984,7 +2984,7 @@ ice_rss_hash_set(struct ice_pf *pf, uint64_t rss_hf) > > if (rss_hf & ETH_RSS_FRAG_IPV6) { > cfg.addl_hdrs = ICE_FLOW_SEG_HDR_IPV6 | ICE_FLOW_SEG_HDR_IPV_FRAG; > - cfg.hash_flds = ICE_FLOW_HASH_IPV6 | BIT_ULL(ICE_FLOW_FIELD_IDX_IPV6_ID); > + cfg.hash_flds = ICE_FLOW_HASH_IPV6; > ret = ice_add_rss_cfg_wrap(pf, vsi->idx, &cfg); > if (ret) > PMD_DRV_LOG(ERR, "%s IPV6_FRAG rss flow fail %d", >