From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mails.dpdk.org (mails.dpdk.org [217.70.189.124]) by inbox.dpdk.org (Postfix) with ESMTP id 2890CA0A0C; Wed, 4 Aug 2021 14:14:28 +0200 (CEST) Received: from [217.70.189.124] (localhost [127.0.0.1]) by mails.dpdk.org (Postfix) with ESMTP id CE3D44014F; Wed, 4 Aug 2021 14:14:27 +0200 (CEST) Received: from mail-108-mta48.mxroute.com (mail-108-mta48.mxroute.com [136.175.108.48]) by mails.dpdk.org (Postfix) with ESMTP id 385F64003E for ; Wed, 4 Aug 2021 14:14:26 +0200 (CEST) Received: from filter004.mxroute.com ([149.28.56.236] filter004.mxroute.com) (Authenticated sender: mN4UYu2MZsgR) by mail-108-mta48.mxroute.com (ZoneMTA) with ESMTPSA id 17b1116074300074ba.001 for (version=TLSv1/SSLv3 cipher=ECDHE-RSA-AES128-GCM-SHA256); Wed, 04 Aug 2021 12:14:21 +0000 X-Zone-Loop: 332e2324d57478a41747a4954003fbcd2c2339858b18 X-Originating-IP: [149.28.56.236] DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=ashroe.eu; s=x; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version:Date: Message-ID:From:References:To:Subject:Sender:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=+Rdo2j3krV7g++NeWV3th1wd3TckX+e+UF7dCOaRe9E=; b=L8rgdvh2azVlhFqy1Jz/eIMnLD X+ZTDEMsjm+M0+txX3n0PmF4m9o9Ap+BKwJp8CwYIh4uB4zUt8eQEhyP5OqwoVir2RkuN/CmCHBkr E1vzX0YkOOJmiUxmD6W1yb9zCrRllEIx/xedpcKgZDehl4Uj+jxDm5trsuRWItEmVy/jltlgGKgAF rzBSo93NCOMIDvlCyOlzLu9zyUsmN7SKl8OsR2Q8sMqIUJwJPCkrjDE7vhi1BpYHFcGQVSwda1rel a4DvEp//AmpR8YGaeUOjXxqBxlPJ3RBB+/i198g4lwIYwtQRCmFt5OlSFWuvMcJLqwJnRpWn14nne BrI80k2Q==; To: "Xueming(Steven) Li" , dpdk-dev References: <20210623000349.631468-2-xuemingl@nvidia.com> <20210625114726.776425-2-xuemingl@nvidia.com> <59178654-a28f-500f-ed76-a501a6e5b6f3@ashroe.eu> <97d5d1b3-40c3-09ac-2978-83c984b30af0@ashroe.eu> From: "Kinsella, Ray" Message-ID: Date: Wed, 4 Aug 2021 13:14:18 +0100 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.12.0 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8 Content-Language: en-US Content-Transfer-Encoding: 7bit X-AuthUser: mdr@ashroe.eu X-Zone-Spam-Resolution: no action X-Zone-Spam-Status: No, score=-0.1, required=15, tests=[ARC_NA=0, TO_DN_ALL=0, RCPT_COUNT_TWO=0, FROM_HAS_DN=0, MIME_GOOD=-0.1, FROM_EQ_ENVFROM=0, MIME_TRACE=0, RCVD_COUNT_ZERO=0, NEURAL_SPAM=0, MID_RHS_MATCH_FROM=0] Subject: Re: [dpdk-dev] [PATCH v6 2/2] bus/auxiliary: introduce auxiliary bus X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.29 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 04/08/2021 13:11, Xueming(Steven) Li wrote: > > >> -----Original Message----- >> From: Kinsella, Ray >> Sent: Wednesday, August 4, 2021 7:46 PM >> To: Xueming(Steven) Li >> Subject: Re: [PATCH v6 2/2] bus/auxiliary: introduce auxiliary bus >> >> >> >> On 04/08/2021 12:21, Xueming(Steven) Li wrote: >>> >>> >>>> -----Original Message----- >>>> From: Kinsella, Ray >>>> Sent: Wednesday, August 4, 2021 6:00 PM >>>> To: Xueming(Steven) Li >>>> Cc: dev@dpdk.org; Wang Haiyue ; >>>> NBU-Contact-Thomas Monjalon ; Neil Horman >>>> >>>> Subject: Re: [PATCH v6 2/2] bus/auxiliary: introduce auxiliary bus >>>> >>>> >>>> >>>> On 25/06/2021 12:47, Xueming Li wrote: >>>>> Auxiliary bus [1] provides a way to split function into >>>>> child-devices representing sub-domains of functionality. Each >>>>> auxiliary device represents a part of its parent functionality. >>>>> >>>>> Auxiliary device is identified by unique device name, sysfs path: >>>>> /sys/bus/auxiliary/devices/ >>>>> >>>>> Devargs legacy syntax ofauxiliary device: >>>>> -a auxiliary:[,args...] >>>>> Devargs generic syntax of auxiliary device: >>>>> -a bus=auxiliary,name=,,/class=,,/driver=,, >>>>> >>>>> [1] kernel auxiliary bus document: >>>>> https://www.kernel.org/doc/html/latest/driver-api/auxiliary_bus.html >>>>> >>>>> Signed-off-by: Xueming Li >>>>> Cc: Wang Haiyue >>>>> Cc: Thomas Monjalon >>>>> Cc: Kinsella Ray >>>>> --- >>>>> MAINTAINERS | 5 + >>>>> doc/guides/rel_notes/release_21_08.rst | 6 + >>>>> drivers/bus/auxiliary/auxiliary_common.c | 411 >>>>> ++++++++++++++++++++++ drivers/bus/auxiliary/auxiliary_params.c | >>>>> ++++++++++++++++++++++ 59 ++++ >>>>> drivers/bus/auxiliary/linux/auxiliary.c | 141 ++++++++ >>>>> drivers/bus/auxiliary/meson.build | 16 + >>>>> drivers/bus/auxiliary/private.h | 74 ++++ >>>>> drivers/bus/auxiliary/rte_bus_auxiliary.h | 201 +++++++++++ >>>>> drivers/bus/auxiliary/version.map | 7 + >>>>> drivers/bus/meson.build | 1 + >>>>> 10 files changed, 921 insertions(+) create mode 100644 >>>>> drivers/bus/auxiliary/auxiliary_common.c >>>>> create mode 100644 drivers/bus/auxiliary/auxiliary_params.c >>>>> create mode 100644 drivers/bus/auxiliary/linux/auxiliary.c >>>>> create mode 100644 drivers/bus/auxiliary/meson.build create mode >>>>> 100644 drivers/bus/auxiliary/private.h create mode 100644 >>>>> drivers/bus/auxiliary/rte_bus_auxiliary.h >>>>> create mode 100644 drivers/bus/auxiliary/version.map >>>>> >>>> >>>> Acked-by: Ray Kinsella >>> >>> Thanks, but this patch already integrated :) >> >> It appears in the order in which I am going through my email is incorrect. :-) >> >>> >>> Would you like to have a look at another deprecation notice? Andrew reviewed RFC: >>> https://mails.dpdk.org/archives/dev/2021-August/216007.html >>> >> >> Its not strictly a depreciation notice though, you are not breaking anything right. >> Since you are not breaking anything, don't think the notice is required in the 21.11 timeframe. >> >> Now if you where doing it in 21.08, it would be an ABI change and that would be a different story. > > Thanks for looking at this! > Yes, it targets to 21.11. The offloading flag is fine, but the shared_group does break ABI, detail: > https://mails.dpdk.org/archives/dev/2021-July/215575.html Right ... its a new field, not a depreciation as such. What I mean by this is that no existing code is broken. 21.11 is a new ABI in any case and you are not depreciating anything, so no notice is required.