From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by dpdk.org (Postfix) with ESMTP id 0EC8429D1 for ; Thu, 15 Sep 2016 12:12:53 +0200 (CEST) Received: from fmsmga005.fm.intel.com ([10.253.24.32]) by fmsmga101.fm.intel.com with ESMTP; 15 Sep 2016 03:12:53 -0700 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.30,338,1470726000"; d="scan'208";a="8681701" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.237.220.135]) ([10.237.220.135]) by fmsmga005.fm.intel.com with ESMTP; 15 Sep 2016 03:12:51 -0700 To: Pablo de Lara , dev@dpdk.org References: <1473877521-2234-1-git-send-email-pablo.de.lara.guarch@intel.com> From: Ferruh Yigit Message-ID: Date: Thu, 15 Sep 2016 11:12:51 +0100 User-Agent: Mozilla/5.0 (Windows NT 6.3; WOW64; rv:45.0) Gecko/20100101 Thunderbird/45.3.0 MIME-Version: 1.0 In-Reply-To: <1473877521-2234-1-git-send-email-pablo.de.lara.guarch@intel.com> Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 8bit Subject: Re: [dpdk-dev] [PATCH] kni: support RHEL 7.3 X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , X-List-Received-Date: Thu, 15 Sep 2016 10:12:54 -0000 On 9/14/2016 7:25 PM, Pablo de Lara wrote: > Add support for RHEL 7.3, which uses kernel 3.10, > but backported features from newer kernels. > > Signed-off-by: Pablo de Lara > --- > lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h b/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h > index bdd0806..1e20a9e 100644 > --- a/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h > +++ b/lib/librte_eal/linuxapp/kni/ethtool/igb/kcompat.h > @@ -3891,7 +3891,7 @@ skb_set_hash(struct sk_buff *skb, __u32 hash, __always_unused int type) > #if (( LINUX_VERSION_CODE >= KERNEL_VERSION(3,19,0) ) \ > || ( RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7,2) )) > #define HAVE_NDO_DFLT_BRIDGE_ADD_MASK > -#if (!( RHEL_RELEASE_CODE >= RHEL_RELEASE_VERSION(7,2) )) > +#if (!( RHEL_RELEASE_CODE == RHEL_RELEASE_VERSION(7,2) )) What about following to simplify the logic: +#if ( RHEL_RELEASE_CODE != RHEL_RELEASE_VERSION(7,2) ) Thanks, ferruh